로그인 인증 #40
Merged
로그인 인증 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichul7493
reviewed
Sep 3, 2024
| isLoading, | ||
| }) | ||
| rerender(<LoginPage />) | ||
| expect(screen.getByRole('button')).not.toHaveTextContent('카카오로 시작하기') | ||
| }) | ||
|
|
||
| it('로그인 성공시 signup 라우팅', async () => { |
There was a problem hiding this comment.
테스트의 설명이 직접 구현하거나 코드의 작동 구조를 면밀히 살피지 않으면 이해하기 어려운 거 같습니다.
테스트 해야 될 대상에 대해 조금 더 알기 쉽게 작성하면 유지보수에도 좋을 거 같습니다.
(다른 사람이 작성한 거라 이해하기 힘든가 싶어서 제가 작성한 걸 보고 왔는데, 제가 작성한 것도 시간이 지나니 뭔소린지 모르겠네요ㅋㅋ 저도 고쳐놔야겠습니다)
There was a problem hiding this comment.
그러게요 ㅠㅠ 어려운 일인 것 같습니다
src/features/auth/api/index.tsx
Outdated
| isSignup: boolean | ||
| } | ||
|
|
||
| export const kakaoLogin = async ({ |
There was a problem hiding this comment.
함수 이름을 봤을 때는 카카오 로그인을 하는 함수인거 같은데, 구현을 보면 카카오 로그인 이후에 받아온 정보로 백엔드 서버에 로그인하는 기능인 것 같네요. 함수 이름을 조금 더 구체적으로 변경해보는건 어떨까요?
| } | ||
| }, [session.accessToken]) | ||
|
|
||
| const signInKakao = async () => { |
There was a problem hiding this comment.
setIsLoading 순서가 요청이 시작될 때 true, 끝날때 false일거 같은데, 반대로 되어 있는거 같아요
그리고 성공했을때 ,실패했을때 작동하는 공통로직(setIsLoading(false))을 finally로 처리하면 반복을 줄일 수 있을거 같아요
There was a problem hiding this comment.
넵 좋은 것 같습니다
오류 찾아주셔서 감사합니다 :)
jun0811
force-pushed
the
feature/#33-next-auth
branch
2 times, most recently
from
d9dbc5b to
19e6c21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next auth 로그인 구현입니다
[로그인 로직]