[멘토님] 코드리뷰PR #43
Open
[멘토님] 코드리뷰PR #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
공통 시간 entity 생성
암호화를 먼저 적용하면 헷갈릴 것 같아 주석처리 해뒀습니다
응답코드가 추가된 형태입니다
…leDTO > position int로 변환
Refactor/no calculate dayoff
Refactor/front requirements
#4 error refactor
This was
linked to
issues
Aug 23, 2023
Open
Open
Open
Open
Open
Open
Jungdahee
reviewed
Aug 28, 2023
There was a problem hiding this comment.
여러분 모두 미니 프로젝트 진행하시느라 고생 많으셨습니다.
따로 코드 리뷰에 대한 니즈가 없어서 제가 코드를 대략적으로 보고, 전체적인 리뷰를 진행하려고 해요!
먼저, 공통 응답에 대한 클래스를 util로 만들어 활용한 부분 잘하셨네요!
Exception도 다양한 상황에 맞게 잘 구성해주셨는데, 저라면 CustomException 클래스를 하나만 만들어서 그 안에서 HttpStatus를 활용하여 처리할 것 같습니다! 지금처럼 Exception 400, 401 등 별도의 클래스로 분리하여 운용하려고 한다면 status가 생기거나 삭제될 때마다 파일 개수가 수정이 되기 때문에 유지보수 측면에서 불리하게 작용할 수 있어요!
그리고 validation 체크 부분이 꼼꼼하게 잘 작성되어 있어 좋았습니다.
모두 수고 많으셨어요! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
email: " [email protected]", password: "1234"
email: "[email protected]", password" "1234"
Issues가 세분화되어 있는 링크로 가서 보시는게 편하실거 같습니다..