-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: ikostova.
|
Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@ibaltadzhieva). In order for your PR to be reviewed and merged, please follow the directions at the link above. Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above. If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin |
…or choosing bus, register methods
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: ikostova.
|
"codelyzer": "~4.5.0", | ||
"electron": "^4.0.4", | ||
"electron-packager": "^13.0.1", | ||
"glue-interop-api-impl": "^1.1.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency was not found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When contributed, I've validated the build of the production bundle, which completes successfully, although this missing dependency gets flagged as optional but missing:
npm WARN @plexus-interop/[email protected] requires a peer of rxjs@^5.4.2 but none is installed. You must install peer dependencies yourself.
npm WARN @plexus-interop/[email protected] requires a peer of rxjs@^5.4.2 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] No repository field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/tick42-glue-core):
npm WARN 404 SKIPPING OPTIONAL DEPENDENCY: Not Found - GET https://registry.npmjs.org/tick42-glue-core - Not found
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/glue-interop-api-impl):
npm WARN 404 SKIPPING OPTIONAL DEPENDENCY: Not Found - GET https://registry.npmjs.org/glue-interop-api-impl - Not found
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/com-glue42-finos-fdc3-api-impl):
npm WARN 404 SKIPPING OPTIONAL DEPENDENCY: Not Found - GET https://registry.npmjs.org/com-glue42-finos-fdc3-api-impl - Not found
These the steps to reproduce it:
npm install -g node-license-validator
git clone [email protected]:Tick42/finos-fdc3-appd-toolbar.git
cd finos-fdc3-appd-toolbar/
npm install --production
cd toolbar-ui-angular
npm install --production
More info on this JIRA comment; hope this helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ikostova-Tick42 @lspiro-Tick42 Any background or context that the FDC3 PMC should consider re the change from "glue-fdc3-access-impl": "^1.0.11" to glue-interop-api-impl": "^1.1.4" does in the 2nd set of commits on this PR from 4/24?
@finos-cla-bot[bot] check |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: ikostova.
|
The cla-bot has been summoned, and re-checked this pull request! |
As the FDC3 PMC does its checks, please do note there are two sets of commits on this PR, including a set from April 24, at 348fbb0 |
Closing in favour of #2 |
No description provided.