Skip to content
This repository has been archived by the owner on Nov 16, 2019. It is now read-only.

Adding Toolbar v1.0 #1

Closed
wants to merge 2 commits into from
Closed

Conversation

ikostova-Tick42
Copy link

No description provided.

@finos-admin
Copy link
Contributor

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: ikostova.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@finos-admin
Copy link
Contributor

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@ibaltadzhieva). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin

@finos-admin
Copy link
Contributor

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: ikostova.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

"codelyzer": "~4.5.0",
"electron": "^4.0.4",
"electron-packager": "^13.0.1",
"glue-interop-api-impl": "^1.1.4",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency was not found.

Copy link

@maoo maoo May 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When contributed, I've validated the build of the production bundle, which completes successfully, although this missing dependency gets flagged as optional but missing:

npm WARN @plexus-interop/[email protected] requires a peer of rxjs@^5.4.2 but none is installed. You must install peer dependencies yourself.
npm WARN @plexus-interop/[email protected] requires a peer of rxjs@^5.4.2 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] No repository field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/tick42-glue-core):
npm WARN 404 SKIPPING OPTIONAL DEPENDENCY: Not Found - GET https://registry.npmjs.org/tick42-glue-core - Not found
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/glue-interop-api-impl):
npm WARN 404 SKIPPING OPTIONAL DEPENDENCY: Not Found - GET https://registry.npmjs.org/glue-interop-api-impl - Not found
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/com-glue42-finos-fdc3-api-impl):
npm WARN 404 SKIPPING OPTIONAL DEPENDENCY: Not Found - GET https://registry.npmjs.org/com-glue42-finos-fdc3-api-impl - Not found

These the steps to reproduce it:

npm install -g node-license-validator
git clone [email protected]:Tick42/finos-fdc3-appd-toolbar.git
cd finos-fdc3-appd-toolbar/
npm install --production
cd toolbar-ui-angular
npm install --production

More info on this JIRA comment; hope this helps.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikostova-Tick42 @lspiro-Tick42 Any background or context that the FDC3 PMC should consider re the change from "glue-fdc3-access-impl": "^1.0.11" to glue-interop-api-impl": "^1.1.4" does in the 2nd set of commits on this PR from 4/24?

@maoo
Copy link

maoo commented May 17, 2019

@finos-cla-bot[bot] check

@finos-admin
Copy link
Contributor

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: ikostova.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@finos-admin
Copy link
Contributor

The cla-bot has been summoned, and re-checked this pull request!

@brooklynrob
Copy link

As the FDC3 PMC does its checks, please do note there are two sets of commits on this PR, including a set from April 24, at 348fbb0

@rikoe
Copy link

rikoe commented Jun 14, 2019

Closing in favour of #2

@rikoe rikoe closed this Jun 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants