Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<fix>(model,precompiled): add tx, receipt and block java native calculate hash methods, fix feature check. #857

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

kyonRay
Copy link
Member

@kyonRay kyonRay commented Dec 27, 2023

No description provided.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 772 lines in your changes are missing coverage. Please review.

Comparison is base (d79ce90) 38.62% compared to head (304b901) 37.46%.
Report is 8 commits behind head on release-3.6.0.

Files Patch % Lines
...ager/transactionv2/AssembleTransactionService.java 4.70% 162 Missing ⚠️
...ntract/precompiled/balance/BalancePrecompiled.java 0.00% 131 Missing ⚠️
.../java/org/fisco/bcos/sdk/v3/contract/Contract.java 7.50% 107 Missing and 4 partials ⚠️
...ansactionv2/AssembleEIP1559TransactionService.java 0.00% 96 Missing ⚠️
...transactionv2/utils/TransactionRequestBuilder.java 0.00% 51 Missing ⚠️
...ger/transactionv2/ProxySignTransactionManager.java 0.00% 48 Missing ⚠️
...3/contract/precompiled/balance/BalanceService.java 0.00% 46 Missing ⚠️
...nager/transactionv2/DefaultTransactionManager.java 0.00% 30 Missing ⚠️
.../manager/transactionv2/dto/TransactionRequest.java 0.00% 21 Missing ⚠️
...rg/fisco/bcos/sdk/v3/model/TransactionReceipt.java 17.39% 19 Missing ⚠️
... and 11 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##             release-3.6.0     #857      +/-   ##
===================================================
- Coverage            38.62%   37.46%   -1.17%     
- Complexity            2031     2054      +23     
===================================================
  Files                  400      408       +8     
  Lines                15676    16467     +791     
  Branches              1754     1813      +59     
===================================================
+ Hits                  6055     6169     +114     
- Misses                9085     9755     +670     
- Partials               536      543       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyonRay kyonRay merged commit 985e86b into FISCO-BCOS:release-3.6.0 Dec 28, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants