v0.0.3 #30
v0.0.3 #30
Conversation
Signed-off-by: Joe McCain III <[email protected]>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Signed-off-by: Joe McCain III <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
|
|
||
| fn from_str(s: &str) -> Result<Self, Self::Err> { | ||
| if let Ok(flat) = s.parse::<FlatSymbol>() { | ||
| return Ok(Self::Flat(flat)); |
Check warning
Code scanning / clippy
unneeded return statement Warning
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
| pub fn to_string(&self) -> String { | ||
| match self { | ||
| Pitches::Flat(note) => format!("{note}♭"), | ||
| Pitches::Sharp(note) => format!("{note}#"), | ||
| Pitches::Natural(note) => format!("{note}"), | ||
| } | ||
| } |
Check failure
Code scanning / clippy
type pitch::class::Pitches implements inherent method to_string(&self) -> String which shadows the implementation of Display Error
| mod pitch { | ||
| use super::Natural; | ||
| use core::marker::PhantomData; | ||
|
|
||
| // pub type D<K = Natural, T = i8> = PitchClass<2, K>; | ||
|
|
||
| // pub type E<K = Natural, T = i8> = PitchClass<4, K>; | ||
|
|
||
| // pub type F<K = Natural, T = i8> = PitchClass<5, K>; | ||
|
|
||
| // pub type G<K = Natural, T = i8> = PitchClass<7, K>; | ||
|
|
||
| // pub type A<K = Natural, T = i8> = PitchClass<9, K>; | ||
|
|
||
| // pub type B<K = Natural, T = i8> = PitchClass<11, K>; | ||
|
|
||
| pub struct PitchClass<const N: usize, K = Natural> { | ||
| _kind: PhantomData<K>, | ||
| } | ||
| } |
Check warning
Code scanning / clippy
module has the same name as its containing module Warning
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
Signed-off-by: Joe McCain III <[email protected]>
No description provided.