Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gruntfile: Add flag to skip building nwjs #762

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

kiike
Copy link
Contributor

@kiike kiike commented Jul 11, 2024

This PR adds a flag to allow skipping building the executable with nwjs. When this flag is passed, we skip the nwjs task, which is beneficial in NixOS so that we don't download any extra binaries; the system already has an nwjs package. Let me know if you think this flag is fine or if you prefer another style --skip-build-nwjs or --skip-nwjs, for instance.

@kiike kiike marked this pull request as draft July 11, 2024 09:09
@cavearr
Copy link
Member

cavearr commented Jul 11, 2024

I'm trying it and worsk as spected! thanks!

@cavearr cavearr marked this pull request as ready for review July 11, 2024 09:31
@cavearr cavearr merged commit 15d4513 into FPGAwars:develop Jul 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants