Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gruntfile: Allow a none platform to skip platform-specific tasks #764

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

kiike
Copy link
Contributor

@kiike kiike commented Jul 11, 2024

A change in distPlatformTasks allows passing --platform=none so that no platform-specific tasks are executed. With this, we avoid running tasks that would not be necessary if, for instance, we are not going to use the zipfile or the AppImage, like the actions we carry out in the Nix package.

Without the --platform=none flag on linux64:

┌─────────┬─────────────────────────┐
│ (index) │ Values                  │
├─────────┼─────────────────────────┤
│ 0       │ 'jshint'                │
│ 1       │ 'clean:dist'            │
│ 2       │ 'nggettext_compile'     │
│ 3       │ 'copy:dist'             │
│ 4       │ 'json-minify'           │
│ 5       │ 'nwjs'                  │
│ 6       │ 'compress:linux64'      │
│ 7       │ 'shell:appImageLinux64' │
│ 8       │ 'clean:tmp'             │
└─────────┴─────────────────────────┘

With the --platform=none flag:

┌─────────┬─────────────────────┐
│ (index) │ Values              │
├─────────┼─────────────────────┤
│ 0       │ 'jshint'            │
│ 1       │ 'clean:dist'        │
│ 2       │ 'nggettext_compile' │
│ 3       │ 'copy:dist'         │
│ 4       │ 'json-minify'       │
│ 5       │ 'nwjs'              │
│ 6       │ 'clean:tmp'         │
└─────────┴─────────────────────┘

@kiike kiike changed the title gruntfile: Allow an empty platform to skip platform-specific tasks gruntfile: Allow a none platform to skip platform-specific tasks Jul 11, 2024
@kiike kiike marked this pull request as ready for review July 11, 2024 10:42
@cavearr
Copy link
Member

cavearr commented Jul 11, 2024

One more! 👍

@cavearr cavearr merged commit 34ca7e5 into FPGAwars:develop Jul 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants