Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Calls to SetCommand #3238

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Remove Calls to SetCommand #3238

merged 1 commit into from
Dec 16, 2023

Conversation

Aws0mee
Copy link
Contributor

@Aws0mee Aws0mee commented Dec 16, 2023

Remove SetCommand in the voting menu. fixes #3237

SetCommand was removed
@FPtje
Copy link
Owner

FPtje commented Dec 16, 2023

Thanks!

@FPtje FPtje merged commit 7287eec into FPtje:master Dec 16, 2023
2 checks passed
@FPtje
Copy link
Owner

FPtje commented Dec 16, 2023

I don't have the ability to do a workshop update right now sadly

@Aws0mee Aws0mee changed the title RemoveCcalls to SetCommand Remove Calls to SetCommand Dec 16, 2023
@Aws0mee
Copy link
Contributor Author

Aws0mee commented Dec 16, 2023

Thanks!

You're welcome 😃

I don't have the ability to do a workshop update right now sadly

That's fine. Hopefully other server owners will be able to find my issue #3237 and realize the solution is to update to this PR. Also, I don't think it's a huge issue. My players first reported this to me about a day or two ago, so if other server owners haven't figured it out by now they likely don't care very much.

@Aws0mee
Copy link
Contributor Author

Aws0mee commented Dec 16, 2023

I'm honestly a little confused as to why it was even removed I don't think it was deprecated, but I might be mistaken. Either way the voting menu should work fine without it, so we're all set I believe.

@FlorianLeChat
Copy link
Contributor

I'm honestly a little confused as to why it was even removed I don't think it was deprecated, but I might be mistaken. Either way the voting menu should work fine without it, so we're all set I believe.

I suspect they were removed at the same time as when Rubat fixed some "unspecified security vulnerabilities", so maybe that has something to do with it.

@Aws0mee
Copy link
Contributor Author

Aws0mee commented Dec 16, 2023

I'm honestly a little confused as to why it was even removed I don't think it was deprecated, but I might be mistaken. Either way the voting menu should work fine without it, so we're all set I believe.

I suspect they were removed at the same time as when Rubat fixed some "unspecified security vulnerabilities", so maybe that has something to do with it.

Maybe, they seem to be hush hush about security vulnerabilities whenever there is one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voting menu causes error, SetCommand was removed
3 participants