Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Maintenance ] Reworked Dependency Checker #3256

Merged
merged 7 commits into from
Mar 20, 2024
Merged

[ Maintenance ] Reworked Dependency Checker #3256

merged 7 commits into from
Mar 20, 2024

Conversation

PhoneDroid
Copy link
Contributor

I used far too much time to get this just right, god I love shell scripting 💀

Description

I reworked the dependency-modification-checking workflow / script

Workflow

  • Now uses checkout v4
  • Runs on latest ubuntu instead

Script

  • Added various info comments
  • Added info messages ( echo )
  • General refactoring / code rework
  • Reworked to use GitHub summary for better visualization
    • Prints out markdown as seen in the below screenshots
    • Links to the repo in question
    • Lists what files were problematic

image
image

@PhoneDroid PhoneDroid marked this pull request as ready for review March 20, 2024 03:29
FPtje
FPtje requested changes Mar 20, 2024
View reviewed changes
Copy link
Owner

@FPtje FPtje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is much appreciated. I have some comments, but overall I'm very happy with this.

.editorconfig Outdated Show resolved Hide resolved
.editorconfig Show resolved Hide resolved
.github/scripts/check-modified-subtree.sh Outdated Show resolved Hide resolved
.github/scripts/check-modified-subtree.sh Show resolved Hide resolved
.github/scripts/check-modified-subtree.sh Outdated Show resolved Hide resolved
@PhoneDroid PhoneDroid force-pushed the Maintenance-Scripts branch from ed4c132 to 0dfeebc Compare March 20, 2024 07:52
@PhoneDroid
Copy link
Contributor Author

In case you prefer Discord for questions, my username is the same as on here~

@PhoneDroid PhoneDroid force-pushed the Maintenance-Scripts branch from 5611520 to 6644a97 Compare March 20, 2024 21:24
FPtje
FPtje approved these changes Mar 20, 2024
View reviewed changes
Copy link
Owner

@FPtje FPtje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet stuff! Thanks a lot for the contribution, and thanks for discussing it on Discord!

@FPtje FPtje merged commit fd59b6c into FPtje:master Mar 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FPtje FPtje FPtje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhoneDroid @FPtje