Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server console database checking #3273

Merged
merged 3 commits into from
Dec 29, 2024
Merged

Fix server console database checking #3273

merged 3 commits into from
Dec 29, 2024

Conversation

Seef0x
Copy link
Contributor

@Seef0x Seef0x commented Dec 29, 2024

No description provided.

@FPtje
Copy link
Owner

FPtje commented Dec 29, 2024

Thanks for the PR! It looks like the IsValid check should already be covered by the IsSuperAdmin check and the getworld check.

I think I'm missing some context. What problem does this solve?

@Seef0x
Copy link
Contributor Author

Seef0x commented Dec 29, 2024

Sorry for lack of detail!

It fixes a lua error if u try to check db with server console

image

@Seef0x
Copy link
Contributor Author

Seef0x commented Dec 29, 2024

Hmm
Display func will still send a net

@FPtje
Copy link
Owner

FPtje commented Dec 29, 2024

Ah, thanks for the detail! Interesting, it looks like the ply ~= game.GetWorld() check doesn't work. That one should exit the if-statement before it gets to the superadmin check.

@Seef0x
Copy link
Contributor Author

Seef0x commented Dec 29, 2024

World check isnt for singleplayer mod?

@FPtje
Copy link
Owner

FPtje commented Dec 29, 2024

Did something change in console commands, that instead of ply being Entity(0), it is now NULL?

@Seef0x
Copy link
Contributor Author

Seef0x commented Dec 29, 2024

Hmm no
image
Or only in concommands

@FPtje
Copy link
Owner

FPtje commented Dec 29, 2024

Yeah in con commands, the ply parameter

@Seef0x
Copy link
Contributor Author

Seef0x commented Dec 29, 2024

Rip
image

@FPtje
Copy link
Owner

FPtje commented Dec 29, 2024

Thanks!

@FPtje FPtje merged commit 251b843 into FPtje:master Dec 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants