Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve possible compatibility #338

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Improve possible compatibility #338

merged 2 commits into from
Oct 19, 2024

Conversation

Astralcircle
Copy link
Contributor

Some addons can overwrite ent.OldColor with a non-color which causes errors like these:

[falcos-prop-protection-master] addons/falcos-prop-protection-master/lua/fpp/server/antispam.lua:9: attempt to index field 'OldColor' (a number value)
1. GhostFreeze - addons/falcos-prop-protection-master/lua/fpp/server/antispam.lua:9
 2. fn - addons/gmod_anticrash-main/lua/autorun/server/sv_anticrash_main.lua:47
  3. unknown - addons/ulib-master/lua/ulib/shared/hook.lua:109

Copy link
Owner

@FPtje FPtje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would it be an idea to rename OldColor to something like FPPOldColor? That way there would be no name conflict.

@Astralcircle
Copy link
Contributor Author

This option would also be suitable

@Astralcircle Astralcircle requested a review from FPtje October 15, 2024 02:11
@FPtje
Copy link
Owner

FPtje commented Oct 15, 2024

Thanks! The code looks good. I will run it on my local computer to run some extra tests. It may take a couple of days before I have the time to do that, so apologies for the delay.

@FPtje
Copy link
Owner

FPtje commented Oct 19, 2024

It works as expected. Merging.
These addon incompatibilities are very hard for me to discover, so I very much appreciate the PR fixing it. Thank you for taking the effort to make a PR!

@FPtje FPtje merged commit 1ef8894 into FPtje:master Oct 19, 2024
1 check passed
@FPtje
Copy link
Owner

FPtje commented Oct 19, 2024

The workshop, DarkRP and DarkRP's workshop have now also been updated with the fix 👍

@Astralcircle Astralcircle deleted the fix branch October 19, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants