Finding the owner of an Weapon correctly

[Astralcircle]

We already do this for weapons created by toolgun, but not for those given out via Q-menu or other means. I did this because some addons like Wiremod use CanTool for CPPI checks. But since we can't interact with our weapon, some functions stop working (like weapon core).
It might be worth overwriting the weapon owner to always match :GetOwner(), but I'm not sure if that's what you want to do, so I copied the PlayerSpawnedSWEP behavior

[FPtje]

Thanks for the PR!

I did this because some addons like Wiremod use CanTool for CPPI checks. But since we can't interact with our weapon, some functions stop working (like weapon core).

I'm not sure I understand the problem you're describing. What are weapon core functions and what does "stop working" entail specifically?

[Astralcircle]

I'm not sure I understand the problem you're describing. What are weapon core functions and what does "stop working" entail specifically?

The problem is that the player doesn't own his weapon. We also get :DropWeapon() support to know who dropped it

[FPtje]

Why was this closed?

[Astralcircle]

I thought that this is not what should be added.

[FPtje]

Oh, I think I may have come across differently than I intended. Sorry about that. My questions were asking for clarification on what problem it solves exactly. You may indeed be right in that this is a good solution.

So as I understand it now, the CPPIOwner is not set for carried weapons. I guess some addons don't realize that these entities are carried weapons (e.g. E2) , so instead of using .Owner they try to get the CPPIOwner, which fails due to the missing owner. Is that correct?

[Astralcircle]

Yes. That's what I'm trying to get across.

[FPtje]

Ah, I see. I think in that case the solution looks good. I have just one small comment. Thanks for your patience!