FRML-146 Migrate Preprocessing toward dataset for independent dataset processing #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the preprocessing step for our image and the label encoding are tightly coupled together, which causes large complicated workarounds. For example, leveraging the
on_before_batch_transfer
in ourLightningModule
inherited classes, then within that function, calling a 2-deep functionpreprocess
, which made the complexity skyrocket.We believe that the preprocessing should live within the dataset, specifically, the image processing.
However, we realized that if we preprocessed the tree labels in the dataset, results (as numbers) wouldn't make sense. Therefore, we're still opting to encode and decode that within the model, which makes sense in the long run as it can be then inferred standalone.
Major Changes
on_before_batch_transfer
is vastly simplified to just nan-mask out missing y labelsStandardScaler
andOrdinalEncoder
are now done internally in theFRDCDataset
andFRDCModule
respectivelyFRDCModule
to reduce redundancy betweenMixMatch
andFixMatch
. This module handles:X_step
code signature consistency, due to our batch being an uncommon schematicon_before_batch_transfer
for nan-mask preprocessing of missing y labelsStandardScaler
from training to be transfered to validation and test sets within the training scripts