Skip to content

Commit

Permalink
tests: Reduce wait intervals in test_bgp_snmp_bgp4v2mib
Browse files Browse the repository at this point in the history
Remove sleep time in test_bgp_snmp_bgp4v2mib before run_and_expect and
reduce wait intervals for faster test convergence.

Signed-off-by: Martin Winter <[email protected]>
Signed-off-by: David Schweizer <[email protected]>
  • Loading branch information
davischw committed Feb 7, 2024
1 parent 961667e commit 1bd9636
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions tests/topotests/bgp_snmp_bgp4v2mib/test_bgp_snmp_bgp4v2mib.py
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ def __get_notif_bgp4_in_trap_file(router):
pytest.skip(error_msg)

rr.vtysh_cmd("clear bgp *")
_, result = topotest.run_and_expect(_snmptrap_ipv4, True, count=2, wait=10)
_, result = topotest.run_and_expect(_snmptrap_ipv4, True, count=30, wait=1)
assertmsg = "Can't fetch SNMP trap for ipv4"
assert result, assertmsg

Expand Down Expand Up @@ -308,8 +308,7 @@ def __get_notif_bgp4v2_in_trap_file(router):
r2.vtysh_cmd("conf\nbgp snmp traps bgp4-mibv2")
r2.vtysh_cmd("conf\nno bgp snmp traps rfc4273")
rr.vtysh_cmd("clear bgp *")
sleep(30)
_, result = topotest.run_and_expect(_snmptrap_ipv6, True, count=2, wait=10)
_, result = topotest.run_and_expect(_snmptrap_ipv6, True, count=60, wait=1)
assertmsg = "Can't fetch SNMP trap for ipv6"
assert result, assertmsg

Expand Down

0 comments on commit 1bd9636

Please sign in to comment.