mgmtd: fix printing an empty data tree

We don't need to create an actual tree to print an empty tree, libyang handles NULL just fine. The actual problem is that `yang_dnode_new` creates a tree by validating it, and the validation creates all implicit default nodes. Therefore, when called with "with-default" flags, instead of getting an empty tree, we get a tree with all top-level default set. Signed-off-by: Igor Ryzhov <[email protected]>
FRRouting · Jan 28, 2024 · 2e4ec82 · 2e4ec82
1 parent f8c7e73
commit 2e4ec82
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/mgmtd/mgmt_fe_adapter.c b/mgmtd/mgmt_fe_adapter.c
@@ -1086,7 +1086,6 @@ static int fe_adapter_send_tree_data(struct mgmt_fe_session_ctx *session,
 
 {
 	struct mgmt_msg_tree_data *msg;
-	struct lyd_node *empty = NULL;
 	uint8_t *buf = NULL;
 	int ret = 0;
 
@@ -1098,11 +1097,6 @@ static int fe_adapter_send_tree_data(struct mgmt_fe_session_ctx *session,
 	msg->partial_error = partial_error;
 	msg->result_type = result_type;
 
-	if (!tree) {
-		empty = yang_dnode_new(ly_native_ctx, false);
-		tree = empty;
-	}
-
 	ret = yang_print_tree_append(&buf, tree, result_type,
 				     (wd_options | LYD_PRINT_WITHSIBLINGS));
 	/* buf may have been reallocated and moved */
@@ -1126,8 +1120,6 @@ static int fe_adapter_send_tree_data(struct mgmt_fe_session_ctx *session,
 	ret = fe_adapter_send_native_msg(session->adapter, buf, darr_len(buf),
 					 short_circuit_ok);
 done:
-	if (empty)
-		yang_dnode_free(empty);
 	darr_free(buf);
 
 	return ret;