Skip to content

Commit

Permalink
lib: fix setting temporary log options for libyang
Browse files Browse the repository at this point in the history
By calling `ly_log_options` with `LY_LOSTORE`, the current code
effectively disables libyang logging and never enables it back. The call
is done to get the current logging options, but we don't really need
that. When looking for a schema node, we don't want neither to log nor
to store the error, so simply set the temporary options to 0.

Signed-off-by: Igor Ryzhov <[email protected]>
  • Loading branch information
idryzhov committed Feb 26, 2024
1 parent 2bc8ae0 commit 3cd6dda
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions lib/northbound.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,14 @@ void nb_nodes_delete(void)
struct nb_node *nb_node_find(const char *path)
{
const struct lysc_node *snode;
uint32_t llopts;
uint32_t llopts = 0;

/*
* Use libyang to find the schema node associated to the path and get
* the northbound node from there (snode private pointer). We need to
* disable logging temporarily to avoid libyang from logging an error
* message when the node is not found.
*/
llopts = ly_log_options(LY_LOSTORE);
llopts &= ~LY_LOLOG;
ly_temp_log_options(&llopts);

snode = yang_find_snode(ly_native_ctx, path, 0);
Expand Down

0 comments on commit 3cd6dda

Please sign in to comment.