Skip to content

Commit

Permalink
lib, ospfclient, tests, vtysh: Allow for a minimum fd poll size
Browse files Browse the repository at this point in the history
There exists cases where just honoring the FD_LIMIT size
as given to us by the operating system makes no sense.
Let's just make a switch to allow for this for things
like vtysh and ospfclient which will never have 1k files
open at any given time.

Fixes: #15315
Signed-off-by: Donald Sharp <[email protected]>
  • Loading branch information
donaldsharp committed Feb 7, 2024
1 parent 7fe05d6 commit 729dd6f
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions lib/event.c
Original file line number Diff line number Diff line change
Expand Up @@ -570,9 +570,12 @@ struct event_loop *event_master_create(const char *name)
rv->fd_limit = (int)limit.rlim_cur;
}

if (rv->fd_limit > STUPIDLY_LARGE_FD_SIZE)
zlog_warn("FD Limit set: %u is stupidly large. Is this what you intended? Consider using --limit-fds",
rv->fd_limit);
if (rv->fd_limit > STUPIDLY_LARGE_FD_SIZE) {
zlog_warn("FD Limit set: %u is stupidly large. Is this what you intended? Consider using --limit-fds also limiting size to %u",
rv->fd_limit, STUPIDLY_LARGE_FD_SIZE);

rv->fd_limit = STUPIDLY_LARGE_FD_SIZE;
}

rv->read = XCALLOC(MTYPE_EVENT_POLL,
sizeof(struct event *) * rv->fd_limit);
Expand Down

0 comments on commit 729dd6f

Please sign in to comment.