Merge pull request #15738 from idryzhov/bfd-cbit

bfdd: fix BFD_GETCBIT
FRRouting · Apr 21, 2024 · 7ba58e9 · 7ba58e9
2 parents 99a723e + 790c207
commit 7ba58e9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 93 deletions.
diff --git a/bfdd/bfd.h b/bfdd/bfd.h
@@ -135,7 +135,7 @@ struct bfd_echo_pkt {
 		if ((val))                                                     \
 			flags |= val;                                          \
 	}
-#define BFD_GETCBIT(flags) (flags & BFD_FBIT)
+#define BFD_GETCBIT(flags) (flags & BFD_CBIT)
 #define BFD_ECHO_VERSION 1
 #define BFD_ECHO_PKT_LEN sizeof(struct bfd_echo_pkt)
 

diff --git a/tests/topotests/bfd_bgp_cbit_topo3/r1/bgp_ipv6_routes_down.json b/tests/topotests/bfd_bgp_cbit_topo3/r1/bgp_ipv6_routes_down.json
@@ -4,51 +4,6 @@
     "localAS": 101,
     "routes":
     {
-        "2001:db8:6::/64": [
-            {
-                "stale": true,
-                "valid": true,
-                "bestpath": true,
-                "pathFrom": "external",
-                "prefix": "2001:db8:6::",
-                "prefixLen": 64,
-                "network": "2001:db8:6::\/64",
-                "metric": 0,
-                "weight": 0,
-                "peerId": "2001:db8:4::1",
-                "origin": "IGP",
-                "nexthops": [
-                    { "ip": "2001:db8:4::1",
-                      "afi": "ipv6",
-                      "scope": "global",
-                      "used": true
-                    }
-                ]
-            }
-        ],
-        "2001:db8:7::/64": [
-            {
-                "stale": true,
-                "valid": true,
-                "bestpath": true,
-                "pathFrom": "external",
-                "prefix": "2001:db8:7::",
-                "prefixLen": 64, "network":
-                "2001:db8:7::\/64",
-                "metric": 0,
-                "weight": 0,
-                "peerId": "2001:db8:4::1",
-                "origin": "IGP",
-                "nexthops": [
-                    {
-                        "ip": "2001:db8:4::1",
-                        "afi": "ipv6",
-                        "scope": "global",
-                        "used": true
-                    }
-                ]
-            }
-        ],
         "2001:db8:8::/64": [
             {
                 "valid": true,

diff --git a/tests/topotests/bfd_bgp_cbit_topo3/r1/ipv6_routes.json b/tests/topotests/bfd_bgp_cbit_topo3/r1/ipv6_routes.json
@@ -32,49 +32,5 @@
             }
         ]
     }
-  ],
-  "2001:db8:6::/64": [{
-        "distance": 20,
-        "protocol": "bgp",
-        "metric": 0,
-        "selected": true,
-        "destSelected": true,
-        "prefix": "2001:db8:6::/64",
-        "nexthops": [{
-                "ip":"2001:db8:4::1",
-                "active": true,
-                "afi": "ipv6",
-                "recursive":true
-            },
-            {
-                "fib":true,
-                "ip":"2001:db8:1::2",
-                "afi": "ipv6",
-                "interfaceName": "r1-eth0"
-            }
-        ]
-    }
-  ],
-  "2001:db8:7::/64": [{
-        "distance": 20,
-        "protocol": "bgp",
-        "metric": 0,
-        "selected": true,
-        "destSelected": true,
-        "prefix": "2001:db8:7::/64",
-        "nexthops": [{
-                "ip":"2001:db8:4::1",
-                "active": true,
-                "afi": "ipv6",
-                "recursive": true
-            },
-            {
-                "fib":true,
-                "ip":"2001:db8:1::2",
-                "afi": "ipv6",
-                "interfaceName":"r1-eth0"
-            }
-        ]
-    }
   ]
 }
diff --git a/tests/topotests/bfd_bgp_cbit_topo3/test_bfd_bgp_cbit_topo3.py b/tests/topotests/bfd_bgp_cbit_topo3/test_bfd_bgp_cbit_topo3.py
@@ -122,8 +122,8 @@ def test_bfd_connection():
 
 def test_bfd_loss_intermediate():
     """
-    Assert that BFD notices the bfd link down failure.
-    but BGP entries should still be present
+    Assert that BGP notices the BFD link down failure.
+    The BGP entries should be flushed as the C-bit is set in both directions.
     """
     tgen = get_topogen()
     if tgen.routers_have_failure():
@@ -160,7 +160,7 @@ def test_bfd_loss_intermediate():
         assertmsg = '"{}" JSON output mismatches'.format(router.name)
         assert result is None, assertmsg
 
-    logger.info("waiting for BGP entries to become stale")
+    logger.info("waiting for BGP entries to be removed")
     for router in tgen.routers().values():
         if router.name == "r2":
             continue