Merge pull request #16632 from donaldsharp/SA_warnings_from_upstream

Sa warnings from upstream
FRRouting · Aug 22, 2024 · 8f6c7c3 · 8f6c7c3
2 parents 3d8ccdb + 286e6f8
commit 8f6c7c3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/bgpd/bgp_fsm.c b/bgpd/bgp_fsm.c
@@ -2933,7 +2933,7 @@ static inline bool gr_mode_matches(enum peer_mode peer_gr_mode,
 unsigned int bgp_peer_gr_action(struct peer *peer, enum peer_mode old_state,
 				enum peer_mode new_state)
 {
-	enum global_mode global_gr_mode = bgp_global_gr_mode_get(peer->bgp);
+	enum global_mode global_gr_mode;
 	bool session_reset = true;
 
 	if (old_state == new_state)

diff --git a/lib/yang.c b/lib/yang.c
@@ -1398,8 +1398,10 @@ LY_ERR yang_lyd_trim_xpath(struct lyd_node **root, const char *xpath)
 		}
 	}
 	darr_foreach_i (remove, i) {
-		if (remove[i] == *root)
+		if (remove[i] == *root) {
+			assert(*root);
 			*root = (*root)->next;
+		}
 		lyd_free_tree(remove[i]);
 	}
 	darr_free(remove);