Skip to content

Commit

Permalink
isisd: fix wrong check for MT commands
Browse files Browse the repository at this point in the history
```
anlan# show run
!
interface eth0
 ip router isis A
exit
!
router isis A
 metric-style narrow <- NOT wide
exit
!
end
anlan (config)# int eth0
anlan (config-if)# no isis topology ipv6-unicast
% Configuration failed.

Error type: validation
Error description: Multi topology IS-IS can only be used with wide metrics
```

The MT commands are mainly controlled by the binded area, not by interface.
Currently if there is any MT configuration in the area, `metric-style` must
be with the `wide` mode, this requirement is sufficient.  So, the
unnecessary/wrong check for MT in the interface should be removed.

Signed-off-by: anlan_cs <[email protected]>
(cherry picked from commit 424cec6)
  • Loading branch information
anlancs authored and mergify[bot] committed Oct 8, 2024
1 parent ae6508e commit c3994f1
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions isisd/isis_nb_config.c
Original file line number Diff line number Diff line change
Expand Up @@ -4299,14 +4299,6 @@ static int lib_interface_isis_multi_topology_common(

switch (event) {
case NB_EV_VALIDATE:
circuit = nb_running_get_entry(dnode, NULL, false);
if (circuit && circuit->area && circuit->area->oldmetric) {
snprintf(
errmsg, errmsg_len,
"Multi topology IS-IS can only be used with wide metrics");
return NB_ERR_VALIDATION;
}
break;
case NB_EV_PREPARE:
case NB_EV_ABORT:
break;
Expand Down

0 comments on commit c3994f1

Please sign in to comment.