lib: fix possible freeing of libyang data

mgmtd frees all non-NULL change->value variables at the end of every commit. We shouldn't assign change->value with data returned by libyang to prevent freeing of library-allocated memory. Signed-off-by: Igor Ryzhov <[email protected]> (cherry picked from commit 814b9fb)
FRRouting · Nov 14, 2023 · c720f9c · c720f9c
1 parent 3fba3d5
commit c720f9c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/northbound.c b/lib/northbound.c
@@ -842,6 +842,7 @@ void nb_candidate_edit_config_changes(
 		struct nb_cfg_change *change = &cfg_changes[i];
 		struct nb_node *nb_node;
 		char xpath[XPATH_MAXLEN];
+		const char *value;
 		struct yang_data *data;
 		int ret;
 
@@ -879,9 +880,10 @@ void nb_candidate_edit_config_changes(
 		}
 
 		/* If the value is not set, get the default if it exists. */
-		if (change->value == NULL)
-			change->value = yang_snode_get_default(nb_node->snode);
-		data = yang_data_new(xpath, change->value);
+		value = change->value;
+		if (value == NULL)
+			value = yang_snode_get_default(nb_node->snode);
+		data = yang_data_new(xpath, value);
 
 		/*
 		 * Ignore "not found" errors when editing the candidate