Skip to content

Commit

Permalink
tools: fix frr-reload multiple no description cmds
Browse files Browse the repository at this point in the history
Ensure to change description for index 0 from the list.

Ticket: #3628756
Testing Done:

After fix:
start with three interfaces description delete in lines_to_del:
(Pdb) lines_to_del
[(('interface swp1',), "description swp1 -> sp1's swp1"),
(('interface swp2',), "description swp2 -> sp2's swp
1"), (('interface swp3',), "description swp3 -> sp3's swp1")]

After first iteration swp1:
(Pdb) index
0
(Pdb) lines_to_del
[(('interface swp1',), 'description'), (('interface swp2',),
"description swp2 -> sp2's swp1"), (('interface swp
1s2',), "description swp3 -> sp3's swp1")]

After second iteration swp2:
(Pdb) lines_to_del
[(('interface swp1',), 'description'), (('interface swp2',),
'description'), (('interface swp3',), "description
swp3 -> sp3's swp1")]

After third iteration swp3 fix
(Pdb) lines_to_del
[(('interface swp1',), 'description'), (('interface swp2',),
'description'), (('interface swp3',), 'description'
)]

Signed-off-by: Chirag Shah <[email protected]>
(cherry picked from commit 8a5c6e4)
  • Loading branch information
chiragshah6 authored and c-po committed Feb 7, 2024
1 parent 303fe4b commit dfc0a16
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/frr-reload.py
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,7 @@ def ignore_delete_re_add_lines(lines_to_add, lines_to_del):
lines_to_add_to_del = []
lines_to_del_to_del = []

index = 0
index = -1
for ctx_keys, line in lines_to_del:
deleted = False

Expand Down

0 comments on commit dfc0a16

Please sign in to comment.