Skip to content

Commit

Permalink
pimd: Fix missing pimreg interface
Browse files Browse the repository at this point in the history
`pimregX` of specific vrf can be deleted from kernel after this vrf is
deleted.  However, then `pimdregX` will never come back to kernel after
adding it ( the same vrf ) back.  That is to say, it exists only in
daemon, but not in kernel.

The root cause is this `pimregX` is not really deleted for its `configured`
flag.  `pim_if_create_pimreg()` will reuse it, so it will never be added
into kernel again.

Just remove the `configured` flag of `pimregX`, allow its deletion.

Fixes #13454

Signed-off-by: anlan_cs <[email protected]>
  • Loading branch information
anlancs committed May 27, 2023
1 parent 607c84f commit e0cdf71
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions pimd/pim_iface.c
Original file line number Diff line number Diff line change
Expand Up @@ -1498,14 +1498,6 @@ void pim_if_create_pimreg(struct pim_instance *pim)
if (!pim->regiface->info)
pim_if_new(pim->regiface, false, false, true,
false /*vxlan_term*/);

/*
* On vrf moves we delete the interface if there
* is nothing going on with it. We cannot have
* the pimregiface deleted.
*/
pim->regiface->configured = true;

}
}

Expand Down

0 comments on commit e0cdf71

Please sign in to comment.