bgpd: code review comments addressed

Signed-off-by: Madhuri Kuruganti <[email protected]>
FRRouting · Oct 11, 2022 · ebcc89f · ebcc89f
1 parent 87556ba
commit ebcc89f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 16 deletions.
diff --git a/bgpd/bgp_debug.c b/bgpd/bgp_debug.c
@@ -2444,7 +2444,7 @@ static int bgp_config_write_debug(struct vty *vty)
 
 	if (CONF_BGP_DEBUG(cond_adv, COND_ADV)) {
 		vty_out(vty, "debug bgp conditional-advertisement\n");
-		write++
+		write++;
 	}
 
 	if (CONF_BGP_DEBUG(optimal_route_reflection, ORR)) {

diff --git a/bgpd/bgp_orr.c b/bgpd/bgp_orr.c
@@ -555,7 +555,7 @@ int peer_orr_group_unset(struct peer *peer, afi_t afi, safi_t safi,
 int bgp_afi_safi_orr_group_set_vty(struct vty *vty, afi_t afi, safi_t safi,
 				   const char *name, const char *primary_str,
 				   const char *secondary_str,
-				   const char *tertiary_str, bool set)
+				   const char *tertiary_str, bool unset)
 {
 	int ret = CMD_WARNING_CONFIG_FAILED;
 	struct bgp *bgp;
@@ -567,7 +567,7 @@ int bgp_afi_safi_orr_group_set_vty(struct vty *vty, afi_t afi, safi_t safi,
 		return ret;
 	}
 
-	if (!set) {
+	if (unset) {
 		ret = bgp_afi_safi_orr_group_unset(bgp, afi, safi, name);
 		if (ret != CMD_SUCCESS)
 			vty_out(vty,
@@ -611,7 +611,7 @@ int bgp_afi_safi_orr_group_set_vty(struct vty *vty, afi_t afi, safi_t safi,
 
 /* Set optimal route reflection group name to the peer. */
 int peer_orr_group_set_vty(struct vty *vty, const char *ip_str, afi_t afi,
-			   safi_t safi, const char *orr_group_name, bool set)
+			   safi_t safi, const char *orr_group_name, bool unset)
 {
 	int ret = CMD_WARNING_CONFIG_FAILED;
 	struct peer *peer;
@@ -626,7 +626,7 @@ int peer_orr_group_set_vty(struct vty *vty, const char *ip_str, afi_t afi,
 		return ret;
 	}
 
-	if (set) {
+	if (!unset) {
 		ret = peer_orr_group_set(peer, afi, safi, orr_group_name);
 		if (ret != CMD_SUCCESS)
 			vty_out(vty, "%% ORR Group '%s' is not configured\n",
@@ -763,13 +763,9 @@ bool peer_orr_rrclient_check(struct peer *peer, afi_t afi, safi_t safi)
 		return false;
 
 	for (ALL_LIST_ELEMENTS_RO(orr_group_list, node, orr_group)) {
-		/*Check if peer configured as primary/secondary/tertiary root */
-		if ((orr_group->primary &&
-		     strmatch(peer->host, orr_group->primary->host)) ||
-		    (orr_group->secondary &&
-		     strmatch(peer->host, orr_group->secondary->host)) ||
-		    (orr_group->tertiary &&
-		     strmatch(peer->host, orr_group->tertiary->host)))
+		/* Check if peer configured as primary/secondary/tertiary root
+		 */
+		if (is_orr_root_node(orr_group, peer->host))
 			return true;
 		/*
 		 * Check if peer is mapped to any ORR Group in this

diff --git a/bgpd/bgp_orr.h b/bgpd/bgp_orr.h
@@ -67,12 +67,12 @@ extern int bgp_afi_safi_orr_group_set_vty(struct vty *vty, afi_t afi,
 					  safi_t safi, const char *name,
 					  const char *primary_str,
 					  const char *secondary_str,
-					  const char *tertiary_str, bool set);
+					  const char *tertiary_str, bool unset);
 extern int peer_orr_group_unset(struct peer *peer, afi_t afi, safi_t safi,
 				const char *orr_group_name);
 extern int peer_orr_group_set_vty(struct vty *vty, const char *ip_str,
 				  afi_t afi, safi_t safi,
-				  const char *orr_group_name, bool set);
+				  const char *orr_group_name, bool unset);
 extern bool peer_orr_rrclient_check(struct peer *peer, afi_t afi, safi_t safi);
 
 extern int bgp_show_orr(struct vty *vty, struct bgp *bgp, afi_t afi,

diff --git a/bgpd/bgp_vty.c b/bgpd/bgp_vty.c
@@ -6218,7 +6218,7 @@ DEFPY (optimal_route_reflection,
 	}
 	return bgp_afi_safi_orr_group_set_vty(
 		vty, bgp_node_afi(vty), bgp_node_safi(vty), orr_group,
-		primary_str, secondary_str, tertiary_str, !no);
+		primary_str, secondary_str, tertiary_str, !!no);
 }
 
 /* neighbor optimal-route-reflection group*/
@@ -6232,7 +6232,7 @@ DEFPY (neighbor_optimal_route_reflection,
        "ORR group name\n")
 {
 	return peer_orr_group_set_vty(vty, neighbor, bgp_node_afi(vty),
-				      bgp_node_safi(vty), orr_group, !no);
+				      bgp_node_safi(vty), orr_group, !!no);
 }
 
 /* neighbor route-server-client. */