Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: fix several issues in sourcing AIGP attribute (backport #17091) #17150

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 17, 2024

Fix several issues in sourcing AIGP attribute:

  1. AIGP should not be set as default for a redistributed route or a
    static network. It should be set by config instead.

  2. AIGP sourced by "set aigp-metric igp-metric" in a route-map does
    not set the correct value for a redistributed route.

  3. When redistribute a connected route like loopback, the AGIP (with
    value 0) is sourced by "set aigp-metric igp-metric", but the
    attribute is not propagated as the attribute flag is not set.


    This is an automatic backport of pull request bgpd: fix several issues in sourcing AIGP attribute #17091 done by Mergify.

Fix several issues in sourcing AIGP attribute:

1) AIGP should not be set as default for a redistributed route or a
   static network. It should be set by config instead.

2) AIGP sourced by "set aigp-metric igp-metric" in a route-map does
   not set the correct value for a redistributed route.

3) When redistribute a connected route like loopback, the AGIP (with
   value 0) is sourced by "set aigp-metric igp-metric", but the
   attribute is not propagated as the attribute flag is not set.

Signed-off-by: Enke Chen <[email protected]>
(cherry picked from commit f65356d)

# Conflicts:
#	bgpd/bgp_attr.h
Add a new topotest for getting the aigp from the "igp-metric"
for a redistributed route (ospf route in the test).

Signed-off-by: Enke Chen <[email protected]>
(cherry picked from commit 5161259)
@mergify mergify bot added the conflicts label Oct 17, 2024
Copy link
Author

mergify bot commented Oct 17, 2024

Cherry-pick of f65356d has failed:

On branch mergify/bp/stable/9.0/pr-17091
Your branch is up to date with 'origin/stable/9.0'.

You are currently cherry-picking commit f65356d8bb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   bgpd/bgp_route.c
	modified:   bgpd/bgp_routemap.c

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   bgpd/bgp_attr.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@frrbot frrbot bot added bgp bugfix tests Topotests, make check, etc labels Oct 17, 2024
@github-actions github-actions bot added size/M and removed conflicts labels Oct 17, 2024
@ton31337 ton31337 closed this Oct 17, 2024
@ton31337 ton31337 deleted the mergify/bp/stable/9.0/pr-17091 branch October 17, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants