bgpd: fix several issues in sourcing AIGP attribute #17091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enkechen-panw
force-pushed
the
aigp-fix1
branch
from
d3dc8c3 to
8140846
Compare
ton31337
requested changes
Oct 15, 2024
|
@Mergifyio backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 |
✅ Backports have been created
|
|
Please drop a merge commit. |
Fix several issues in sourcing AIGP attribute: 1) AIGP should not be set as default for a redistributed route or a static network. It should be set by config instead. 2) AIGP sourced by "set aigp-metric igp-metric" in a route-map does not set the correct value for a redistributed route. 3) When redistribute a connected route like loopback, the AGIP (with value 0) is sourced by "set aigp-metric igp-metric", but the attribute is not propagated as the attribute flag is not set. Signed-off-by: Enke Chen <[email protected]>
Add a new topotest for getting the aigp from the "igp-metric" for a redistributed route (ospf route in the test). Signed-off-by: Enke Chen <[email protected]>
enkechen-panw
force-pushed
the
aigp-fix1
branch
from
96558ea to
5161259
Compare
Done. |
ton31337
approved these changes
Oct 17, 2024
This was referenced Oct 17, 2024
ton31337
added a commit
that referenced
this pull request
Oct 17, 2024
bgpd: fix several issues in sourcing AIGP attribute (backport #17091)
Jafaral
added a commit
that referenced
this pull request
Oct 17, 2024
bgpd: fix several issues in sourcing AIGP attribute (backport #17091)
Jafaral
added a commit
that referenced
this pull request
Oct 17, 2024
bgpd: fix several issues in sourcing AIGP attribute (backport #17091)
Jafaral
added a commit
that referenced
this pull request
Oct 17, 2024
bgpd: fix several issues in sourcing AIGP attribute (backport #17091)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several issues in sourcing AIGP attribute:
AIGP should not be set as default for a redistributed route or a
static network. It should be set by config instead.
AIGP sourced by "set aigp-metric igp-metric" in a route-map does
not set the correct value for a redistributed route.
When redistribute a connected route like loopback, the AGIP (with
value 0) is sourced by "set aigp-metric igp-metric", but the
attribute is not propagated as the attribute flag is not set.