zebra: avoid having speed set to UINT32_MAX #10151

pguibert6WIND · 2021-11-30T08:59:06Z

there are some cases where the read of the interface speed returns an
invalid value, despite there is no error when read happens. that
invalid value is UINT32_MAX and can lead to wrong assumptions by routing
protocols. For instance, ospf can read that value like a very high
speed, whereas it is not the case, as this value is really too big. (
value is expressed in megabytes).

To avoid this problem, the speed value set to the interface structure
will be 0. Like that, routing daemons will not pay attention to the
value of the speed that is wrong, whatever the 0 or UINT32_MAX value
seen.

Signed-off-by: Philippe Guibert [email protected]

pguibert6WIND · 2021-11-30T08:59:30Z

continuation of #6233

pguibert6WIND · 2021-11-30T09:12:24Z

open issue: how to handle deprecation when a parameter changes unit ( aka bandwidth) ?

LabN-CI · 2021-11-30T10:12:17Z

Outdated results 🛑

Basic BGPD CI results: FAILURE

_	_
Result	FAILURE git merge/10151 `75d78c5` frr.github Build
Date	11/30/2021
Start	05:11:18
Finish	05:12:14
Run-Time	00:56
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-11-30-05:11:18.txt
Log	make-2021-11-30-05:11:18.out.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2021-11-30T10:26:59Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI101BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI005BUILD/config.status/config.status

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI005BUILD/ErrorLog/log_make.txt)

pimd/pim_msdp.c:723:9: warning: missing braces around initializer [-Wmissing-braces]
pimd/pim_msdp.c:723:9: warning: (near initialization for nexthop.last_lookup) [-Wmissing-braces]
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.  CC       bgpd/bgp_addpath.o
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed./home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:1411: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
make[1]: *** [Makefile:9894: zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
make[1]: Target 'all-am' not remade because of errors.
make: *** [Makefile:6129: all] Error 2

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/DEB11AMD64/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1871/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
Makefile:5505: recipe for target 'all' failed
make: *** [all] Error 2

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
make[1]: Target 'all-am' not remade because of errors.
Makefile:5505: recipe for target 'all' failed
make: *** [all] Error 2

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1871/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
Makefile:5505: recipe for target 'all' failed
make[1]: Target 'all-am' not remade because of errors.
make: *** [all] Error 2

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
make[1]: Target 'all-am' not remade because of errors.
Makefile:5505: recipe for target 'all' failed
make: *** [all] Error 2

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:1411: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/interface.c: In function 'if_zebra_speed_update':
zebra/interface.c:77:9: error: 'struct interface' has no member named 'vrf_id'
gmake[1]: *** [Makefile:9893: zebra/interface.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.1871/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6128: all] Error 2

OpenBSD 6 amd64 build: Failed (click for details)

OpenBSD 6 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
zebra/interface.c:77:11: error: no member named 'vrf_id' in 'struct interface'
1 error generated.
gmake[1]: *** [Makefile:9889: zebra/interface.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
gmake: *** [Makefile:6124: all] Error 2

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.1871/frr-source'
zebra/interface.c: In function 'if_zebra_speed_update':
zebra/interface.c:77:11: error: 'struct interface' has no member named 'vrf_id'; did you mean 'vrf'?
gmake[1]: *** [Makefile:9890: zebra/interface.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.1871/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6125: all] Error 2

NetBSD 8 amd64 build: Failed (click for details)

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI012BUILD/ErrorLog/log_make.txt)

ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
zebra/interface.c: In function 'if_zebra_speed_update':
zebra/interface.c:77:9: error: 'struct interface' has no member named 'vrf_id'
gmake[1]: *** [Makefile:9894: zebra/interface.o] Error 1
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:15855: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:15865: warning: @image file `frr-figures/fig_topologies_full.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:15875: warning: @image file `frr-figures/fig_topologies_rs.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:15986: warning: @image file `frr-figures/fig-rs-processing.txt' (for text) unreadable: No such file or directory.

NetBSD 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI012BUILD/config.log/config.log.gz

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1871/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
Makefile:5505: recipe for target 'all' failed
make[1]: Target 'all-am' not remade because of errors.
make: *** [all] Error 2

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U18I386BUILD/config.log/config.log.gz

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CENTOS8BUILD/config.log/config.log.gz

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1871/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
make[1]: *** [Makefile:9890: zebra/interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
make: *** [Makefile:6125: all] Error 2

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CENTOS8BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1871/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
make[1]: *** [Makefile:9890: zebra/interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
make: *** [Makefile:6125: all] Error 2

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1871/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
Makefile:5505: recipe for target 'all' failed
make: *** [all] Error 2

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U18ARM8BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.1871/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:9: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
make[1]: Target 'all-am' not remade because of errors.
Makefile:5505: recipe for target 'all' failed
make: *** [all] Error 2

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1871/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
make[1]: *** [Makefile:9891: zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
make[1]: Target 'all-am' not remade because of errors.
make: *** [Makefile:6126: all] Error 2

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1871/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
Makefile:5505: recipe for target 'all' failed
make: *** [all] Error 2

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1871/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
make[1]: *** [Makefile:9891: zebra/interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.1871/frr-source'
make: *** [Makefile:6126: all] Error 2

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1871/artifact/DEB10BUILD/config.log/config.log.gz

NetDEF-CI · 2021-11-30T11:04:27Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1867/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topotests debian 10 amd64 part 9: No useful log found

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 9: No useful log found

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 9: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 2
IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 7
Fedora 29 rpm pkg check
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Ubuntu 20.04 deb pkg check
IPv6 protocols on Ubuntu 18.04
Debian 9 deb pkg check
Debian 10 deb pkg check
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 8
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 7
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0

NetDEF-CI · 2021-11-30T11:06:34Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1868/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topotests debian 10 amd64 part 9: No useful log found

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 9: No useful log found

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 9: No useful log found

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 2
Ubuntu 16.04 deb pkg check
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 9
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 6
CentOS 7 rpm pkg check
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 i386 part 5
Ubuntu 20.04 deb pkg check
Ubuntu 18.04 deb pkg check
Debian 9 deb pkg check
Debian 10 deb pkg check
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0
Static analyzer (clang)

donaldsharp

The first commits breaks the case where an interface does not know it's speed for greater than 5 seconds. Please make sure that we do not break this.

Edit: I was wrong about the first commit, it will continue to attempt to read if the speed is still unknown. I'd like an answer about setting all unknowns to a default speed though.

donaldsharp · 2021-11-30T13:19:33Z

zebra/if_netlink.c

@@ -432,7 +432,7 @@ static uint32_t get_iflink_speed(struct interface *interface, int *error)
 			/* no vrf socket creation may probably mean vrf issue */
 			if (error)
 				*error = INTERFACE_SPEED_ERROR_READ;
-			return 0;
+			return DEFAULT_SPEED;


Why is setting the speed to DEFAULT_SPEED acceptable when we don't know the speed of the link? How is this better?

you re right. this commit is removed, but others are valid

donaldsharp · 2021-11-30T13:20:17Z

zebra/interface.c

-       "bandwidth (1-100000)",
-       "Set bandwidth informational parameter\n"
-       "Bandwidth in megabits\n")
+DEFUN(bandwidth_if, bandwidth_if_cmd, "bandwidth (1-1000000)",


Please no whitespace changes here.

frrbot will not be happy. but ok if you want

As I've explained countless times, defuns are not subject to the style guide.

did not everyone complain about how to avoid DEFUN from appear on frrbot ?

Yes, several people expressed that they wanted frrbot to handle DEFUNs, and if memory serves I said I haven't found a way of doing it; frrbot uses clang-format and DEFUNs would need to be wrapped in some markup that makes clang-format ignore it.

Does your comment have something to do with this code review?

donaldsharp · 2021-11-30T13:20:39Z

zebra/interface.c

-       NO_STR
-       "Set bandwidth informational parameter\n"
-       "Bandwidth in megabits\n")
+DEFUN(no_bandwidth_if, no_bandwidth_if_cmd, "no bandwidth [(1-1000000)]",


again please do not change the whitespace here. clang-format is just wrong here

you mean, lets go back to previous format of DEFUN ?

donaldsharp · 2021-11-30T13:21:15Z

lib/libospf.h

@@ -74,7 +74,7 @@ extern "C" {
 #define OSPF_TRANSMIT_DELAY_DEFAULT         1
 #define OSPF_DEFAULT_BANDWIDTH		 10000	/* Mbps */

-#define OSPF_DEFAULT_REF_BANDWIDTH	100000  /* Mbps */
+#define OSPF_DEFAULT_REF_BANDWIDTH 100000 /* Kbps */


why the change in alignment with the rest of the code. Please fix

donaldsharp · 2021-11-30T13:21:26Z

ospf6d/ospf6_interface.h

@@ -182,7 +182,7 @@ extern const char *const ospf6_interface_state_str[];
 #define OSPF6_INTERFACE_TRANSDELAY     1
 #define OSPF6_INTERFACE_INSTANCE_ID    0
 #define OSPF6_INTERFACE_BANDWIDTH      10000   /* Mbps */
-#define OSPF6_REFERENCE_BANDWIDTH      100000  /* Mbps */
+#define OSPF6_REFERENCE_BANDWIDTH 100000       /* Kbps */


why the change in alignment with the rest of the code?

NetDEF-CI · 2021-12-02T16:01:50Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1916/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function); did you mean _DEFAULT_SOURCE?
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U18ARM8BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'
make[1]: Target 'all-am' not remade because of errors.

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CENTOS8BUILD/config.log/config.log.gz

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1916/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
make[1]: *** [Makefile:9890: zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'
make[1]: Target 'all-am' not remade because of errors.
make: *** [Makefile:6125: all] Error 2

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CENTOS8BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1916/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
make[1]: *** [Makefile:9891: zebra/interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'
make: *** [Makefile:6126: all] Error 2

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1916/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function); did you mean _DEFAULT_SOURCE?
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1916/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
make[1]: *** [Makefile:9891: zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'
make[1]: Target 'all-am' not remade because of errors.
make: *** [Makefile:6126: all] Error 2

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/DEB10BUILD/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/F29BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1916/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
make[1]: *** [Makefile:9890: zebra/interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'
make: *** [Makefile:6125: all] Error 2

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1916/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function); did you mean _DEFAULT_SOURCE?
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:1411: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/interface.c: In function 'if_zebra_speed_update':
zebra/interface.c:71:23: error: 'DEFAULT_SPEED' undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: 'struct interface' has no member named 'vrf_id'
gmake[1]: *** [Makefile:9893: zebra/interface.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/usr/home/ci/cibuild.1916/frr-source'
gmake: *** [Makefile:6128: all] Error 2

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI101BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1916/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function); did you mean _DEFAULT_SOURCE?
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:1411: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
make[1]: *** [Makefile:9894: zebra/interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'
make: *** [Makefile:6129: all] Error 2

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/DEB11AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.1916/frr-source'
zebra/interface.c: In function 'if_zebra_speed_update':
zebra/interface.c:71:23: error: 'DEFAULT_SPEED' undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: 'struct interface' has no member named 'vrf_id'; did you mean 'vrf'?
gmake[1]: *** [Makefile:9890: zebra/interface.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.1916/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6125: all] Error 2

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI005BUILD/config.status/config.status

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI005BUILD/ErrorLog/log_make.txt)

pimd/pim_msdp.c:723:9: warning: missing braces around initializer [-Wmissing-braces]
pimd/pim_msdp.c:723:9: warning: (near initialization for nexthop.last_lookup) [-Wmissing-braces]
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.  CC       bgpd/bgp_addpath.o
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed./home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.1916/frr-source'
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function); did you mean _DEFAULT_SOURCE?
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/U18I386BUILD/config.log/config.log.gz

NetBSD 8 amd64 build: Failed (click for details)

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI012BUILD/ErrorLog/log_make.txt)

doc/user/_build/texinfo/frr.texi:29497: warning: @image file `frr-figures/fig-vnc-redundant-route-reflectors.txt' (for text) unreadable: No such file or directory.
zebra/interface.c: In function 'if_zebra_speed_update':
zebra/interface.c:71:23: error: 'DEFAULT_SPEED' undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: 'struct interface' has no member named 'vrf_id'
gmake[1]: *** [Makefile:9894: zebra/interface.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'
gmake: *** [Makefile:6129: all] Error 2

NetBSD 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI012BUILD/config.log/config.log.gz

OpenBSD 6 amd64 build: Failed (click for details)

OpenBSD 6 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-1916/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.1916/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
zebra/interface.c:71:23: error: use of undeclared identifier 'DEFAULT_SPEED'
zebra/interface.c:77:11: error: no member named 'vrf_id' in 'struct interface'
2 errors generated.
gmake[1]: *** [Makefile:9889: zebra/interface.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.1916/frr-source'
gmake: *** [Makefile:6124: all] Error 2

LabN-CI · 2021-12-02T16:13:40Z

Outdated results 🛑

Basic BGPD CI results: FAILURE

_	_
Result	FAILURE git merge/10151 `520e1d2` frr.github Build
Date	12/02/2021
Start	11:12:39
Finish	11:13:36
Run-Time	00:57
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-12-02-11:12:39.txt
Log	make-2021-12-02-11:12:39.out.bz2
Memory

For details, please contact louberger

qlyoung · 2021-12-03T17:43:54Z

ospf6d/ospf6_interface.h

@@ -182,7 +182,7 @@ extern const char *const ospf6_interface_state_str[];
 #define OSPF6_INTERFACE_TRANSDELAY     1
 #define OSPF6_INTERFACE_INSTANCE_ID    0
 #define OSPF6_INTERFACE_BANDWIDTH      10000   /* Mbps */
-#define OSPF6_REFERENCE_BANDWIDTH      100000  /* Mbps */
+#define OSPF6_REFERENCE_BANDWIDTH     100000   /* Kbps */


Please fix the whitespace change

qlyoung · 2021-12-03T17:45:22Z

zebra/if_netlink.c

+	if (ret == UINT32_MAX) {
+		if (error)
+			*error = INTERFACE_SPEED_ERROR_UNKNOWN;
+		return 0;


just set ret = 0 and let us fall out to return ret on the next line

qlyoung · 2021-12-06T05:01:11Z

@donaldsharp if you could re-review this please

NetDEF-CI · 2021-12-14T17:39:58Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.2133/frr-source/doc/user/pathd.rst:108: WARNING: undefined label: traffic-engineering (if the link has no caption the label must precede a section header)
zebra/interface.c: In function 'if_zebra_speed_update':
zebra/interface.c:71:23: error: 'DEFAULT_SPEED' undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: 'struct interface' has no member named 'vrf_id'; did you mean 'vrf'?
gmake[1]: *** [Makefile:9890: zebra/interface.o] Error 1
ospfd/ospf_vty.c:9732:1: note: #pragma message: Time to remove broken OSPF GR helper
 CPP_NOTICE("Time to remove broken OSPF GR helper")
 ^~~~~~~~~~

NetBSD 8 amd64 build: Failed (click for details)

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI012BUILD/ErrorLog/log_make.txt)

doc/user/_build/texinfo/frr.texi:29719: warning: @image file `frr-figures/fig-vnc-redundant-route-reflectors.txt' (for text) unreadable: No such file or directory.
zebra/interface.c: In function 'if_zebra_speed_update':
zebra/interface.c:71:23: error: 'DEFAULT_SPEED' undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: 'struct interface' has no member named 'vrf_id'
gmake[1]: *** [Makefile:9894: zebra/interface.o] Error 1
ospfd/ospf_vty.c:9732:1: note: #pragma message: Time to remove broken OSPF GR helper
 CPP_NOTICE("Time to remove broken OSPF GR helper")
 ^

NetBSD 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI012BUILD/config.log/config.log.gz

Ubuntu 16.04 arm8 build: Failed (click for details)

Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2133/frr-source/doc/user/pathd.rst:108: WARNING: undefined label: traffic-engineering (if the link has no caption the label must precede a section header)
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
/home/ci/cibuild.2133/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2133/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI014BUILD/ErrorLog/log_make.txt)

 ^
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.2133/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U18I386BUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function); did you mean _DEFAULT_SOURCE?
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.2133/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2133/frr-source/doc/user/pathd.rst:108: WARNING: undefined label: traffic-engineering (if the link has no caption the label must precede a section header)
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function); did you mean _DEFAULT_SOURCE?
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
ospfd/ospf_vty.c:9732:1: note: #pragma message: Time to remove broken OSPF GR helper
 CPP_NOTICE("Time to remove broken OSPF GR helper")

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2133/frr-source/doc/user/pathd.rst:108: WARNING: undefined label: traffic-engineering (if the link has no caption the label must precede a section header)
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function); did you mean _DEFAULT_SOURCE?
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
ospfd/ospf_vty.c:9732:1: note: #pragma message: Time to remove broken OSPF GR helper
 CPP_NOTICE("Time to remove broken OSPF GR helper")

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U18ARM8BUILD/config.status/config.status

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CENTOS8BUILD/config.log/config.log.gz

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2133/frr-source/doc/user/pathd.rst:90: WARNING: undefined label: traffic-engineering (if the link has no caption the label must precede a section header)
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
make[1]: *** [Makefile:9890: zebra/interface.o] Error 1
ospfd/ospf_vty.c:9732:1: note: #pragma message: Time to remove broken OSPF GR helper
 CPP_NOTICE("Time to remove broken OSPF GR helper")
 ^~~~~~~~~~

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CENTOS8BUILD/config.status/config.status

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.2133/frr-source/doc/user/pathd.rst:90: WARNING: undefined label: traffic-engineering
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
make[1]: *** [Makefile:9894: zebra/interface.o] Error 1
doc/user/_build/texinfo/frr.texi:23999: warning: could not find @image file `frr-figures/pathd_general.txt' nor alternate text
doc/user/_build/texinfo/frr.texi:24148: warning: could not find @image file `frr-figures/pathd_config.txt' nor alternate text
doc/user/_build/texinfo/frr.texi:24204: warning: could not find @image file `frr-figures/pathd_initiated_multi.txt' nor alternate text

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/DEB11AMD64/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U1604I386/ErrorLog/log_make.txt)

 ^
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.2133/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/F29BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2133/frr-source/doc/user/pathd.rst:90: WARNING: undefined label: traffic-engineering (if the link has no caption the label must precede a section header)
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
make[1]: *** [Makefile:9890: zebra/interface.o] Error 1
ospfd/ospf_vty.c:9732:1: note: #pragma message: Time to remove broken OSPF GR helper
 CPP_NOTICE("Time to remove broken OSPF GR helper")
 ^~~~~~~~~~

OpenBSD 6 amd64 build: Failed (click for details)

OpenBSD 6 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2133/frr-source/doc/user/pathd.rst:108: WARNING: undefined label: traffic-engineering (if the link has no caption the label must precede a section header)
/home/ci/cibuild.2133/frr-source/doc/user/pathd.rst:108: WARNING: undefined label: traffic-engineering (if the link has no caption the label must precede a section header)
zebra/interface.c:71:23: error: use of undeclared identifier 'DEFAULT_SPEED'
zebra/interface.c:77:11: error: no member named 'vrf_id' in 'struct interface'
2 errors generated.
gmake[1]: *** [Makefile:9889: zebra/interface.o] Error 1
ospfd/ospf_vty.c:9732:1: warning: Time to remove broken OSPF GR helper [-W#pragma-messages]
CPP_NOTICE("Time to remove broken OSPF GR helper")
^

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/DEB10BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2133/frr-source/doc/user/pathd.rst:90: WARNING: undefined label: traffic-engineering (if the link has no caption the label must precede a section header)
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
make[1]: *** [Makefile:9891: zebra/interface.o] Error 1
ospfd/ospf_vty.c:9732:1: note: #pragma message: Time to remove broken OSPF GR helper
 CPP_NOTICE("Time to remove broken OSPF GR helper")
 ^~~~~~~~~~

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/DEB10BUILD/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2133/frr-source/doc/user/pathd.rst:90: WARNING: undefined label: traffic-engineering (if the link has no caption the label must precede a section header)
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
make[1]: *** [Makefile:9891: zebra/interface.o] Error 1
ospfd/ospf_vty.c:9732:1: note: #pragma message: Time to remove broken OSPF GR helper
 9732 | CPP_NOTICE("Time to remove broken OSPF GR helper")
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U2004AMD64BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI021BUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.2133/frr-source'
make[1]: Target 'all-am' not remade because of errors.

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI005BUILD/config.status/config.status

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI005BUILD/ErrorLog/log_make.txt)

pimd/pim_msdp.c:723:9: warning: missing braces around initializer [-Wmissing-braces]
pimd/pim_msdp.c:723:9: warning: (near initialization for nexthop.last_lookup) [-Wmissing-braces]
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.  CC       bgpd/bgp_addpath.o
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed./home/ci/cibuild.2133/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2133/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2133/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2133/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2133/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2133/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.2133/frr-source/doc/user/pathd.rst:108: WARNING: undefined label: traffic-engineering (if the link has no caption the label must precede a section header)
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: struct interface has no member named vrf_id
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
/home/ci/cibuild.2133/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.2133/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI101BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

 ^~~~~~~~~~
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function); did you mean _DEFAULT_SOURCE?
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.2133/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/U1804AMD64/ErrorLog/log_make.txt)

 ^~~~~~~~~~
zebra/interface.c: In function if_zebra_speed_update:
zebra/interface.c:71:23: error: DEFAULT_SPEED undeclared (first use in this function); did you mean _DEFAULT_SOURCE?
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:11: error: struct interface has no member named vrf_id; did you mean vrf?
Makefile:9264: recipe for target 'zebra/interface.o' failed
make[1]: *** [zebra/interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.2133/frr-source'
make[1]: Target 'all-am' not remade because of errors.

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-2133/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.2133/frr-source/doc/user/pathd.rst:90: WARNING: undefined label: traffic-engineering
zebra/interface.c: In function 'if_zebra_speed_update':
zebra/interface.c:71:23: error: 'DEFAULT_SPEED' undeclared (first use in this function)
zebra/interface.c:71:23: note: each undeclared identifier is reported only once for each function it appears in
zebra/interface.c:77:9: error: 'struct interface' has no member named 'vrf_id'
gmake[1]: *** [Makefile:9893: zebra/interface.o] Error 1
ospfd/ospf_vty.c:9732:1: note: '#pragma message: Time to remove broken OSPF GR helper'
 9732 | CPP_NOTICE("Time to remove broken OSPF GR helper")
gmake[1]: Target 'all-am' not remade because of errors.

LabN-CI · 2021-12-14T17:50:29Z

Outdated results 🛑

Basic BGPD CI results: FAILURE

_	_
Result	FAILURE git merge/10151 `79d98ee` frr.github Build
Date	12/14/2021
Start	12:49:20
Finish	12:50:25
Run-Time	01:05
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-12-14-12:49:20.txt
Log	make-2021-12-14-12:49:20.out.bz2
Memory

For details, please contact louberger

louis-6wind · 2024-01-23T13:02:31Z

ci:rerun

louis-6wind · 2024-01-24T16:23:56Z

@donaldsharp could you review this please ?

donaldsharp · 2024-01-24T17:22:14Z

zebra/interface.c

@@ -59,6 +59,9 @@ static void if_zebra_speed_update(struct event *thread)
 	bool changed = false;
 	int error = 0;

+	if (!ifp->vrf || ifp->vrf->vrf_id == VRF_UNKNOWN)
+		return;


What's the code path that the speed is set in this case?

actually, with recent version, there is no need to do this check.
I removed the commit from the pull request and rebased.

donaldsharp · 2024-01-25T15:14:23Z

I'll push this in once CI finishes successfully

github-actions · 2024-01-29T12:48:41Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

get_iflink_speed() returns UINT32_MAX when the speeds is unknown. Routing daemons (at least ospfd) interprets it as the high value. Return errors in get_iflink_speed() to avoid the confusion. Signed-off-by: Philippe Guibert <[email protected]> Signed-off-by: Louis Scalbert <[email protected]>

Allow bandwidth up to 1000000 Mb/s (ie. 1 Tb/s) and document it. Signed-off-by: Philippe Guibert <[email protected]> Signed-off-by: Louis Scalbert <[email protected]>

Fix reference bandwidth description. It is Kbps, not Mbps. Signed-off-by: Philippe Guibert <[email protected]> Signed-off-by: Louis Scalbert <[email protected]>

louis-6wind · 2024-02-01T09:13:28Z

ci:rerun

louis-6wind · 2024-02-02T17:15:28Z

I'll push this in once CI finishes successfully

@donaldsharp could you merge this please ?

pguibert6WIND · 2024-02-06T10:29:00Z

https://github.com/Mergifyio backport stable/9.1

mergify · 2024-02-06T10:29:07Z

backport stable/9.1

✅ Backports have been created

#15312 zebra: avoid having speed set to UINT32_MAX (backport #10151) has been created for branch stable/9.1 but encountered conflicts

pguibert6WIND requested a review from ton31337 November 30, 2021 08:59

frrbot bot added documentation libfrr zebra labels Nov 30, 2021

pguibert6WIND force-pushed the ensure_routing_protocols_good_bw branch from 416bc04 to c9dbc92 Compare November 30, 2021 09:05

pguibert6WIND added ospf ospfv3 labels Nov 30, 2021

donaldsharp requested changes Nov 30, 2021

View reviewed changes

donaldsharp reviewed Nov 30, 2021

View reviewed changes

pguibert6WIND force-pushed the ensure_routing_protocols_good_bw branch from 75d78c5 to 520e1d2 Compare December 2, 2021 15:43

qlyoung reviewed Dec 3, 2021

View reviewed changes

qlyoung requested a review from donaldsharp December 6, 2021 05:01

pguibert6WIND force-pushed the ensure_routing_protocols_good_bw branch from 520e1d2 to 79d98ee Compare December 14, 2021 17:12

pguibert6WIND force-pushed the ensure_routing_protocols_good_bw branch 2 times, most recently from c29f0ae to eecda3e Compare December 15, 2021 11:22

louis-6wind mentioned this pull request Jan 17, 2024

lib,ospf6d,zebra: fix wrong bandwidth issues #15167

Closed

pguibert6WIND force-pushed the ensure_routing_protocols_good_bw branch from fba380d to d7fdb24 Compare January 22, 2024 17:20

frrbot bot added the bugfix label Jan 22, 2024

github-actions bot added size/M and removed conflicts labels Jan 22, 2024

donaldsharp reviewed Jan 24, 2024

View reviewed changes

pguibert6WIND force-pushed the ensure_routing_protocols_good_bw branch from d7fdb24 to 8678746 Compare January 25, 2024 14:49

github-actions bot added size/S and removed size/M labels Jan 25, 2024

pguibert6WIND force-pushed the ensure_routing_protocols_good_bw branch from 8678746 to 683841e Compare January 25, 2024 14:52

github-actions bot added size/M and removed size/S labels Jan 25, 2024

github-actions bot added the conflicts label Jan 29, 2024

pguibert6WIND added 3 commits January 29, 2024 14:52

doc, yang, zebra: allow bandwidth up to 1 terabit/sec

e3c62b2

Allow bandwidth up to 1000000 Mb/s (ie. 1 Tb/s) and document it. Signed-off-by: Philippe Guibert <[email protected]> Signed-off-by: Louis Scalbert <[email protected]>

lib,ospf6d: fix reference bandwidth description

42c1652

Fix reference bandwidth description. It is Kbps, not Mbps. Signed-off-by: Philippe Guibert <[email protected]> Signed-off-by: Louis Scalbert <[email protected]>

pguibert6WIND force-pushed the ensure_routing_protocols_good_bw branch from 683841e to 42c1652 Compare January 29, 2024 13:53

frrbot bot added the yang label Jan 29, 2024

github-actions bot removed the conflicts label Jan 29, 2024

donaldsharp merged commit 3d57f04 into FRRouting:master Feb 2, 2024
11 checks passed

github-actions bot added the backport label Feb 6, 2024

mergify bot mentioned this pull request Feb 6, 2024

zebra: avoid having speed set to UINT32_MAX (backport #10151) #15312

Closed

zebra: avoid having speed set to UINT32_MAX #10151

zebra: avoid having speed set to UINT32_MAX #10151

Conversation

pguibert6WIND commented Nov 30, 2021

pguibert6WIND commented Nov 30, 2021

pguibert6WIND commented Nov 30, 2021

LabN-CI commented Nov 30, 2021 • edited Loading

Basic BGPD CI results: FAILURE

NetDEF-CI commented Nov 30, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

NetDEF-CI commented Nov 30, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Nov 30, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

donaldsharp left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pguibert6WIND Dec 2, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NetDEF-CI commented Dec 2, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

LabN-CI commented Dec 2, 2021 • edited Loading

Basic BGPD CI results: FAILURE

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qlyoung commented Dec 6, 2021

NetDEF-CI commented Dec 14, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

LabN-CI commented Dec 14, 2021 • edited Loading

Basic BGPD CI results: FAILURE

louis-6wind commented Jan 23, 2024

louis-6wind commented Jan 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

donaldsharp commented Jan 25, 2024

github-actions bot commented Jan 29, 2024

louis-6wind commented Feb 1, 2024

louis-6wind commented Feb 2, 2024

pguibert6WIND commented Feb 6, 2024

mergify bot commented Feb 6, 2024 • edited Loading

✅ Backports have been created

LabN-CI commented Nov 30, 2021 •

edited

Loading

NetDEF-CI commented Nov 30, 2021 •

edited

Loading

NetDEF-CI commented Nov 30, 2021 •

edited

Loading

NetDEF-CI commented Nov 30, 2021 •

edited

Loading

donaldsharp left a comment •

edited

Loading

pguibert6WIND Dec 2, 2021 •

edited

Loading

NetDEF-CI commented Dec 2, 2021 •

edited

Loading

LabN-CI commented Dec 2, 2021 •

edited

Loading

NetDEF-CI commented Dec 14, 2021 •

edited

Loading

LabN-CI commented Dec 14, 2021 •

edited

Loading

mergify bot commented Feb 6, 2024 •

edited

Loading