zebra: delete label chunk upon release #12409

FRIDM636 · 2022-11-28T09:56:10Z

In zebra/label_manager.c the releasing of the label chunk is done by disowning the chunk to the system. The presence of this system label chunk will cause label assignment to fail for this use case example:

label chunk ospf: 300-320
label chunk system: 510-520
label chunk isis: 1200-1300

Then we try to allocate the chunk 500-530, we get this error:
"Allocation of mpls label chunk [500/530] failed"

The error is raised when the below condition is true:
/* if chunk is used, cannot honor request */
if (lmc->proto != NO_PROTO)
return NULL;

Delete the label chunk instead of disowning it when the label releasing is done.

Signed-off-by: Farid MIHOUB [email protected]

NetDEF-CI · 2022-11-28T12:11:41Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8604/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for label_manager.c | 2 issues
===============================================
< ERROR: space required before the open parenthesis '('
< #418: FILE: /tmp/f1-1080123/label_manager.c:418:

donaldsharp · 2022-11-28T12:58:25Z

Let's fix the commit header line to our standard
Let's fix the spacing on the code change
From the comments in the commit I do not understand how a label allocation of 500-530 should work when 510-520 is already allocated? Can you give me the actual steps to reproduce so I can understand better?

FRIDM636 · 2022-12-02T10:40:06Z

Hello Donald, here is a reproduction report
(Note that I have added the "show debugging labeltable" to dump the allocated label chunks.

Reproduction

Step 1: Initial configuration:

!
router ospf
ospf router-id 1.1.1.1
segment-routing global-block 300 350 local-block 20000 21000
segment-routing on
router-info area
exit
!
router isis 1
segment-routing global-block 1200 1300 local-block 22000 23000
segment-routing on
exit
!
segment-routing
traffic-eng
mpls-te on
policy color 1 endpoint 1.1.1.1
binding-sid 500
exit
exit
exit

---> label table:

ubuntu2004# show debugging labeltable
Proto ospf: [300/350]
Proto srte: [500/500]
Proto isis: [1200/1300]
Proto ospf: [20000/21000]
Proto isis: [22000/23000]

Step 2: Remove binding-sid from pathd daemon

ubuntu2004(config)# segment-routing
ubuntu2004(config-sr)# traffic-eng
ubuntu2004(config-sr-te)# no policy color 1 endpoint 1.1.1.1
ubuntu2004(config-sr-te)# end

---> The chunk [500/500] is disowned from srte and owned by system.

ubuntu2004# show debugging labeltable
Proto ospf: [300/350]
Proto system: [500/500]
Proto isis: [1200/1300]
Proto ospf: [20000/21000]
Proto isis: [22000/23000]

Step 3: remove ospf configuration

ubuntu2004# configure terminal
ubuntu2004(config)# no router ospf
ubuntu2004(config)#

---> all released ospf chunks will be owend by system

ubuntu2004# show debugging labeltable
Proto system: [300/350]
Proto system: [500/500]
Proto isis: [1200/1300]
Proto system: [20000/21000]
Proto isis: [22000/23000]

step 4: create a new OSPF instance and allocate new label

router ospf
segment-routing global-block 490 530 local-block 25000 26000
segment-routing on
exit

ubuntu2004# show debugging labeltable
Proto system: [300/350]
Proto system: [500/500]
Proto isis: [1200/1300]
Proto system: [20000/21000]
Proto isis: [22000/23000]
Proto ospf: [25000/26000]

---> the chunk [490/530/] is not allocated:
Errors:
Dec 02 10:38:48 ubuntu2004 ospfd[53847]: [RZ7AW-QAEZC] SR: Segment Routing: OFF -> ON
Dec 02 10:38:48 ubuntu2004 ospfd[53847]: [RWCZZ-S75Y2] SR (ospf_sr_start): Start Segment Routing
Dec 02 10:38:48 ubuntu2004 ospfd[53847]: [NEMDY-QEYBN] SR: Got new SRLB [25000/26000], 1001 labels
Dec 02 10:38:48 ubuntu2004 ospfd[53847]: [R5XPW-YQR5G] Unable to assign Label Chunk to ospf instance 0
Dec 02 10:38:48 ubuntu2004 ospfd[53847]: [TC6J7-70ZMZ] ospf_zebra_request_label_range: error getting label range!
Dec 02 10:38:48 ubuntu2004 ospfd[53847]: [PTW3M-NKQHB] SR: Error reserving SRGB [490/530], 41 labels

----> with the proposed patch, we got:
ubuntu2004(config)# do sh de la
Proto ospf: [490/530]
Proto isis: [1200/1300]
Proto isis: [22000/23000]
Proto ospf: [25000/26000]

NetDEF-CI · 2022-12-02T12:47:05Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8666/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for label_manager.c | 30 issues
===============================================
< ERROR: code indent should use tabs where possible
< #165: FILE: /tmp/f1-3415970/label_manager.c:165:
< WARNING: please, no spaces at the start of a line
< #165: FILE: /tmp/f1-3415970/label_manager.c:165:
< ERROR: code indent should use tabs where possible
< #166: FILE: /tmp/f1-3415970/label_manager.c:166:
< WARNING: please, no spaces at the start of a line
< #166: FILE: /tmp/f1-3415970/label_manager.c:166:
< ERROR: code indent should use tabs where possible
< #168: FILE: /tmp/f1-3415970/label_manager.c:168:
< WARNING: please, no spaces at the start of a line
< #168: FILE: /tmp/f1-3415970/label_manager.c:168:
< ERROR: code indent should use tabs where possible
< #169: FILE: /tmp/f1-3415970/label_manager.c:169:
< WARNING: please, no spaces at the start of a line
< #169: FILE: /tmp/f1-3415970/label_manager.c:169:
< ERROR: code indent should use tabs where possible
< #170: FILE: /tmp/f1-3415970/label_manager.c:170:
< WARNING: please, no spaces at the start of a line
< #170: FILE: /tmp/f1-3415970/label_manager.c:170:
< ERROR: code indent should use tabs where possible
< #171: FILE: /tmp/f1-3415970/label_manager.c:171:
< WARNING: please, no spaces at the start of a line
< #171: FILE: /tmp/f1-3415970/label_manager.c:171:
< ERROR: code indent should use tabs where possible
< #173: FILE: /tmp/f1-3415970/label_manager.c:173:
< WARNING: please, no spaces at the start of a line
< #173: FILE: /tmp/f1-3415970/label_manager.c:173:
< ERROR: space required before the open parenthesis '('
< #436: FILE: /tmp/f1-3415970/label_manager.c:436:

NetDEF-CI · 2022-12-02T12:50:12Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8667/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 2: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 2: No useful log found

Successful on other platforms/tests

Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 5
Topotests debian 10 amd64 part 8
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 arm8 part 9
Fedora 29 rpm pkg check
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Addresssanitizer topotests part 8
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 9
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 6
Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 4
Debian 9 deb pkg check
Addresssanitizer topotests part 4
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 2: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 2: No useful log found

Report for label_manager.c | 28 issues
===============================================
< ERROR: code indent should use tabs where possible
< #165: FILE: /tmp/f1-3436436/label_manager.c:165:
< WARNING: please, no spaces at the start of a line
< #165: FILE: /tmp/f1-3436436/label_manager.c:165:
< ERROR: code indent should use tabs where possible
< #166: FILE: /tmp/f1-3436436/label_manager.c:166:
< WARNING: please, no spaces at the start of a line
< #166: FILE: /tmp/f1-3436436/label_manager.c:166:
< ERROR: code indent should use tabs where possible
< #168: FILE: /tmp/f1-3436436/label_manager.c:168:
< WARNING: please, no spaces at the start of a line
< #168: FILE: /tmp/f1-3436436/label_manager.c:168:
< ERROR: code indent should use tabs where possible
< #169: FILE: /tmp/f1-3436436/label_manager.c:169:
< WARNING: please, no spaces at the start of a line
< #169: FILE: /tmp/f1-3436436/label_manager.c:169:
< ERROR: code indent should use tabs where possible
< #170: FILE: /tmp/f1-3436436/label_manager.c:170:
< WARNING: please, no spaces at the start of a line
< #170: FILE: /tmp/f1-3436436/label_manager.c:170:
< ERROR: code indent should use tabs where possible
< #171: FILE: /tmp/f1-3436436/label_manager.c:171:
< WARNING: please, no spaces at the start of a line
< #171: FILE: /tmp/f1-3436436/label_manager.c:171:
< ERROR: code indent should use tabs where possible
< #173: FILE: /tmp/f1-3436436/label_manager.c:173:
< WARNING: please, no spaces at the start of a line
< #173: FILE: /tmp/f1-3436436/label_manager.c:173:

NetDEF-CI · 2022-12-02T15:41:57Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8667/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for label_manager.c | 28 issues
===============================================
< ERROR: code indent should use tabs where possible
< #165: FILE: /tmp/f1-3436436/label_manager.c:165:
< WARNING: please, no spaces at the start of a line
< #165: FILE: /tmp/f1-3436436/label_manager.c:165:
< ERROR: code indent should use tabs where possible
< #166: FILE: /tmp/f1-3436436/label_manager.c:166:
< WARNING: please, no spaces at the start of a line
< #166: FILE: /tmp/f1-3436436/label_manager.c:166:
< ERROR: code indent should use tabs where possible
< #168: FILE: /tmp/f1-3436436/label_manager.c:168:
< WARNING: please, no spaces at the start of a line
< #168: FILE: /tmp/f1-3436436/label_manager.c:168:
< ERROR: code indent should use tabs where possible
< #169: FILE: /tmp/f1-3436436/label_manager.c:169:
< WARNING: please, no spaces at the start of a line
< #169: FILE: /tmp/f1-3436436/label_manager.c:169:
< ERROR: code indent should use tabs where possible
< #170: FILE: /tmp/f1-3436436/label_manager.c:170:
< WARNING: please, no spaces at the start of a line
< #170: FILE: /tmp/f1-3436436/label_manager.c:170:
< ERROR: code indent should use tabs where possible
< #171: FILE: /tmp/f1-3436436/label_manager.c:171:
< WARNING: please, no spaces at the start of a line
< #171: FILE: /tmp/f1-3436436/label_manager.c:171:
< ERROR: code indent should use tabs where possible
< #173: FILE: /tmp/f1-3436436/label_manager.c:173:
< WARNING: please, no spaces at the start of a line
< #173: FILE: /tmp/f1-3436436/label_manager.c:173:

NetDEF-CI · 2022-12-02T17:24:06Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8673/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

pguibert6WIND · 2022-12-12T15:26:45Z

Hi @donaldsharp , any updates on this please?

ton31337

Documentation update is needed + commit's naming.

NetDEF-CI · 2023-01-31T16:34:34Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9479/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: No useful log found

Successful on other platforms/tests

OpenBSD 7 amd64 build
Redhat 8 amd64 build
Debian 10 amd64 build
Ubuntu 16.04 arm7 build
CentOS 7 amd64 build
FreeBSD 11 amd64 build
Ubuntu 22.04 amd64 build
Debian 9 amd64 build
Ubuntu 16.04 arm8 build
Ubuntu 18.04 amd64 build
Ubuntu 16.04 amd64 build
Redhat 9 amd64 build
Ubuntu 18.04 ppc64le build
Ubuntu 20.04 amd64 build
FreeBSD 12 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 18.04 arm7 build
Debian 11 amd64 build
Ubuntu 16.04 i386 build
Fedora 29 amd64 build

LabN-CI · 2023-01-31T17:05:13Z

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, 1 tests failed

_	_
Result	SUCCESS git merge/12409 `510efe9`
Date	01/31/2023
Start	11:37:54
Finish	12:05:03
Run-Time	27:09
Total	1813
Pass	1812
Fail	1
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2023-01-31-11:37:54.txt
Log	autoscript-2023-01-31-11:39:13.log.bz2
Memory	573 546 467

For details, please contact louberger

NetDEF-CI · 2023-02-01T11:38:22Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9496/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2023-03-06T12:56:49Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10057/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2023-03-08T18:20:03Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10096/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2023-03-16T13:26:33Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10189/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI · 2023-09-22T11:01:39Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14294/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14294/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Successful on other platforms/tests

Addresssanitizer topotests part 9
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 4
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 0
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 4
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 9
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 6
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 6
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 4
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 1

FRIDM636 · 2023-09-22T14:00:19Z

ci:rerun

NetDEF-CI · 2023-09-22T16:53:09Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14297/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-14297/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14297/artifact/TOPO8U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14297/artifact/TOPO8U18I386/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14297/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-14297/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14297/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14297/artifact/TOPO9U18I386/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4U18I386-14297/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14297/artifact/TOPO4U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 4: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14297/artifact/TOPO4U18I386/TopotestDetails/

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 9
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 6
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 arm8 part 3

louis-6wind · 2023-09-26T09:44:24Z

ci:rerun

NetDEF-CI · 2023-09-26T12:45:08Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14336/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-14336/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14336/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14336/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-14336/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14336/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14336/artifact/TOPO9U18I386/TopotestDetails/

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 0
Debian 10 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 9
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 4
Addresssanitizer topotests part 1
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 7
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 5
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 2
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 9
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 7

FRIDM636 · 2023-09-27T08:22:07Z

ci:rerun

NetDEF-CI · 2023-09-27T11:20:16Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14354/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

zebra/label_manager.c

NetDEF-CI · 2023-09-27T16:07:53Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14358/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Debian 9 deb pkg check: Incomplete

(check logs for details)

Debian 10 deb pkg check: Incomplete

(check logs for details)

Ubuntu 20.04 deb pkg check: Incomplete

(check logs for details)

CentOS 7 rpm pkg check: Incomplete

(check logs for details)

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 4
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 9
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 6
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 6
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 4
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 1
Addresssanitizer topotests part 9
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 2
Topotests debian 10 amd64 part 9

FRIDM636 · 2023-09-28T07:19:10Z

ci:rerun

NetDEF-CI · 2023-09-28T07:41:21Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14375/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Incomplete

Debian 9 amd64 build: Incomplete

(check logs for details)

Successful on other platforms/tests

OpenBSD 7 amd64 build
Redhat 8 amd64 build
Debian 10 amd64 build
CentOS 7 amd64 build
FreeBSD 11 amd64 build
Ubuntu 22.04 amd64 build
Ubuntu 18.04 amd64 build
Redhat 9 amd64 build
Ubuntu 20.04 amd64 build
Ubuntu 18.04 ppc64le build
FreeBSD 12 amd64 build
Ubuntu 18.04 i386 build
Ubuntu 18.04 arm8 build
Ubuntu 18.04 arm7 build
Debian 11 amd64 build

### Basic Tests: Incomplete

Add the new command "show debugging labeltable" to show allocated label chunks in the label table managed with label_manager.c Signed-off-by: Farid Mihoub <[email protected]> Signed-off-by: Philippe Guibert <[email protected]>

In zebra/label_manager.c the releasing of the label chunk is done by disowning the chunk to the system. The presence of this system label chunk will cause label assignment to fail for this use case example: label chunk ospf: 300-320 label chunk system: 510-520 label chunk isis: 1200-1300 Then we try to allocate the chunk 500-530, we get this error: "Allocation of mpls label chunk [500/530] failed" The error is raised when the below condition is true: /* if chunk is used, cannot honor request */ if (lmc->proto != NO_PROTO) return NULL; Delete the label chunk instead of disowning it when the label releasing is done. Signed-off-by: Farid MIHOUB <[email protected]>

NetDEF-CI · 2023-09-29T09:19:40Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14401/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

github-actions bot added the master label Nov 28, 2022

FRIDM636 force-pushed the master branch from 2ad4dd3 to 8b41745 Compare December 2, 2022 10:32

frrbot bot added the zebra label Dec 2, 2022

github-actions bot added the size/S label Dec 2, 2022

FRIDM636 force-pushed the master branch from 8b41745 to 7afdf9d Compare December 2, 2022 10:36

FRIDM636 force-pushed the master branch from 7afdf9d to d99e8ed Compare December 2, 2022 15:10

ton31337 requested changes Jan 31, 2023

View reviewed changes

FRIDM636 force-pushed the master branch from d99e8ed to 510efe9 Compare January 31, 2023 16:00

github-actions bot added size/M and removed size/S labels Jan 31, 2023

FRIDM636 changed the title ~~zebra/label_manager.c: delete label chunk upon release~~ zebra: delete label chunk upon release Jan 31, 2023

FRIDM636 force-pushed the master branch from cb54402 to 510efe9 Compare February 1, 2023 09:29

FRIDM636 closed this Feb 1, 2023

FRIDM636 force-pushed the master branch from 510efe9 to 3056025 Compare February 1, 2023 09:39

github-actions bot added size/XS and removed size/M labels Feb 1, 2023

FRIDM636 reopened this Feb 1, 2023

github-actions bot added size/M and removed size/XS labels Feb 1, 2023

FRIDM636 force-pushed the master branch from 72796a2 to ad63cdc Compare February 24, 2023 10:11

FRIDM636 requested a review from ton31337 February 27, 2023 11:45

FRIDM636 force-pushed the master branch from ad63cdc to f7b37c1 Compare March 6, 2023 10:26

FRIDM636 force-pushed the master branch from f7b37c1 to c454e07 Compare March 8, 2023 15:49

FRIDM636 force-pushed the master branch from c454e07 to 3e0b7f1 Compare March 16, 2023 10:49

FRIDM636 force-pushed the master branch from 3e0b7f1 to 5283112 Compare June 20, 2023 08:33

FRIDM636 force-pushed the master branch from 5283112 to 8076c3a Compare July 24, 2023 15:55

FRIDM636 force-pushed the master branch from 8076c3a to c5ef6eb Compare September 22, 2023 08:04

pguibert6WIND mentioned this pull request Sep 24, 2023

Label allocation handling in multiple control planes #14485

Closed

ton31337 reviewed Sep 27, 2023

View reviewed changes

zebra/label_manager.c Show resolved Hide resolved

FRIDM636 force-pushed the master branch from c5ef6eb to 0e8fa2d Compare September 27, 2023 12:35

FRIDM636 added 2 commits September 29, 2023 08:24

zebra: dump label table information

2b8e22f

Add the new command "show debugging labeltable" to show allocated label chunks in the label table managed with label_manager.c Signed-off-by: Farid Mihoub <[email protected]> Signed-off-by: Philippe Guibert <[email protected]>

FRIDM636 force-pushed the master branch from 0e8fa2d to a4b3f03 Compare September 29, 2023 06:24

ton31337 approved these changes Sep 29, 2023

View reviewed changes

ton31337 merged commit 969e3a6 into FRRouting:master Sep 29, 2023
5 checks passed

zebra: delete label chunk upon release #12409

zebra: delete label chunk upon release #12409

Conversation

FRIDM636 commented Nov 28, 2022 • edited Loading

NetDEF-CI commented Nov 28, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

donaldsharp commented Nov 28, 2022

FRIDM636 commented Dec 2, 2022 • edited Loading

Reproduction

Step 1: Initial configuration:

Step 2: Remove binding-sid from pathd daemon

Step 3: remove ospf configuration

step 4: create a new OSPF instance and allocate new label

NetDEF-CI commented Dec 2, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Dec 2, 2022 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Dec 2, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Dec 2, 2022 • edited Loading

Continuous Integration Result: SUCCESSFUL

pguibert6WIND commented Dec 12, 2022

ton31337 left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Jan 31, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

LabN-CI commented Jan 31, 2023 • edited Loading

Basic BGPD CI results: Partial FAILURE, 1 tests failed

NetDEF-CI commented Feb 1, 2023 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Mar 6, 2023 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Mar 8, 2023 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Mar 16, 2023 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Sep 22, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

FRIDM636 commented Sep 22, 2023

NetDEF-CI commented Sep 22, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

louis-6wind commented Sep 26, 2023

NetDEF-CI commented Sep 26, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

FRIDM636 commented Sep 27, 2023

NetDEF-CI commented Sep 27, 2023 • edited Loading

Continuous Integration Result: SUCCESSFUL

NetDEF-CI commented Sep 27, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

FRIDM636 commented Sep 28, 2023

NetDEF-CI commented Sep 28, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Incomplete

NetDEF-CI commented Sep 29, 2023

Continuous Integration Result: SUCCESSFUL

FRIDM636 commented Nov 28, 2022 •

edited

Loading

NetDEF-CI commented Nov 28, 2022 •

edited

Loading

FRIDM636 commented Dec 2, 2022 •

edited

Loading

NetDEF-CI commented Dec 2, 2022 •

edited

Loading

NetDEF-CI commented Dec 2, 2022 •

edited

Loading

NetDEF-CI commented Dec 2, 2022 •

edited

Loading

NetDEF-CI commented Dec 2, 2022 •

edited

Loading

NetDEF-CI commented Jan 31, 2023 •

edited

Loading

LabN-CI commented Jan 31, 2023 •

edited

Loading

NetDEF-CI commented Feb 1, 2023 •

edited

Loading

NetDEF-CI commented Mar 6, 2023 •

edited

Loading

NetDEF-CI commented Mar 8, 2023 •

edited

Loading

NetDEF-CI commented Mar 16, 2023 •

edited

Loading

NetDEF-CI commented Sep 22, 2023 •

edited

Loading

NetDEF-CI commented Sep 22, 2023 •

edited

Loading

NetDEF-CI commented Sep 26, 2023 •

edited

Loading

NetDEF-CI commented Sep 27, 2023 •

edited

Loading

NetDEF-CI commented Sep 27, 2023 •

edited

Loading

NetDEF-CI commented Sep 28, 2023 •

edited

Loading