isisd: Delay lsp generation to after non-integrated config processing is complete #13178
Conversation
Register the frr_config hooks so the isis callback functions can be called from frr_config_read_in. Signed-off-by: Isabella de Leon <[email protected]>
| start_router(tgen, "r3") | ||
|
|
||
| # Check that the overload bit is set in r3's LSP (without retry) | ||
| isis_database_output = r3.vtysh_cmd("show isis database r3.00-00 json") |
There was a problem hiding this comment.
This sounds like "gonna fail sometimes", doesn't it? I mean checking without any retries or is this always a deterministic output after stopping/starting the router?
There was a problem hiding this comment.
Changed it to check the overload bit with a shorter timeout instead of eliminating retries
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-10532/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9 Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-10532/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 Topotests Ubuntu 18.04 i386 part 0: Failed (click for details)Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10532/artifact/TOPO0U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10532/artifact/TOPO0U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 0: No useful log foundTopotests Ubuntu 18.04 arm8 part 0: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10532/artifact/TOPO0U18ARM8/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-10532/test Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0 Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10532/artifact/TOPOU1804/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10532/artifact/TOPOU1804/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 0: No useful log foundTopotests debian 10 amd64 part 0: Failed (click for details)Topotests debian 10 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10532/artifact/TOPO0DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10532/artifact/TOPO0DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 0: No useful log foundSuccessful on other platforms/tests
|
isabelladeleon12
force-pushed
the
isis_load_non_integrated_conf_lsp_gen
branch
from
8166ba0 to
e1f6aa6
Compare
Add test to check that the non-integrated config is applied before lsp generate. Signed-off-by: Isabella de Leon <[email protected]>
isabelladeleon12
force-pushed
the
isis_load_non_integrated_conf_lsp_gen
branch
from
e1f6aa6 to
93e72a3
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 0: Failed (click for details)Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10549/artifact/TOPO0U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10549/artifact/TOPO0U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 0: No useful log foundTopotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10549/artifact/TOPOU1804/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10549/artifact/TOPOU1804/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 0: No useful log foundTopotests debian 10 amd64 part 0: Failed (click for details)Topotests debian 10 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10549/artifact/TOPO0DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10549/artifact/TOPO0DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 0: No useful log foundTopotests Ubuntu 18.04 arm8 part 0: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10549/artifact/TOPO0U18ARM8/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-10549/test Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0 Successful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10550/artifact/TOPOU1804/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10550/artifact/TOPOU1804/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 0: No useful log foundTopotests debian 10 amd64 part 0: Failed (click for details)Topotests debian 10 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10550/artifact/TOPO0DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10550/artifact/TOPO0DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 0: No useful log foundTopotests Ubuntu 18.04 arm8 part 0: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10550/artifact/TOPO0U18ARM8/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-10550/test Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0 Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10550/artifact/TOPO6U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10550/artifact/TOPO6U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 6: No useful log foundSuccessful on other platforms/tests
|
|
failure doesn't look related (?) ... retrying |
|
Working with Olivier to debug failing tests |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 0: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10630/artifact/TOPO0U18ARM8/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-10630/test Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0 Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10630/artifact/TOPOU1804/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10630/artifact/TOPOU1804/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 0: No useful log foundTopotests debian 10 amd64 part 0: Failed (click for details)Topotests debian 10 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10630/artifact/TOPO0DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10630/artifact/TOPO0DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 0: No useful log foundTopotests Ubuntu 18.04 i386 part 0: Failed (click for details)Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10630/artifact/TOPO0U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10630/artifact/TOPO0U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 0: No useful log foundSuccessful on other platforms/tests
|
|
Hello Isabella, Following the new version of your patch, I discover another memory leak problem in Link State. Please have a look to this PR #13235 and wait until is merged before rebasing your PR. Olivier |
|
I don't really see the connection between the failure and the changes ... and it looks like it's not failing on all platforms ... trying again ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-11242/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7 Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11242/artifact/TP4U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-11242/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4 Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-11242/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7 Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-11242/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8 Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11242/artifact/TOPO9U18AMD64/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11242/artifact/TOPO9U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 9: No useful log foundTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11242/artifact/TOPO9U18I386/TopotestLogs/ Topotests Ubuntu 18.04 i386 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11242/artifact/TOPO9U18I386/TopotestDetails/ Topotests Ubuntu 18.04 i386 part 9: No useful log foundTopotests debian 10 amd64 part 2: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2DEB10AMD64-11242/test Topology Tests failed for Topotests debian 10 amd64 part 2 Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11242/artifact/TP1U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-11242/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1 Successful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-11267/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-11267/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8 Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-11267/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-11267/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0 Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11267/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests debian 10 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-11267/test Topology Tests failed for Topotests debian 10 amd64 part 6 Topotests debian 10 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-11267/test Topology Tests failed for Topotests debian 10 amd64 part 0 Topotests Ubuntu 18.04 i386 part 0: Failed (click for details)Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11267/artifact/TOPO0U18I386/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-11267/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0 Successful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11282/artifact/TOPO9U18AMD64/TopotestLogs/ Topotests Ubuntu 18.04 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11282/artifact/TOPO9U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 9: No useful log foundTopotests debian 10 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-11282/test Topology Tests failed for Topotests debian 10 amd64 part 0 Topotests Ubuntu 18.04 i386 part 0: Failed (click for details)Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11282/artifact/TOPO0U18I386/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-11282/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0 Topotests debian 10 amd64 part 9: Failed (click for details)Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11282/artifact/TOPO9DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11282/artifact/TOPO9DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 9: No useful log foundTopotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-11282/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0 Successful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-11285/test Topology Tests failed for Topotests debian 10 amd64 part 0 Topotests Ubuntu 18.04 i386 part 0: Failed (click for details)Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11285/artifact/TOPO0U18I386/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-11285/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0 Topotests debian 10 amd64 part 9: Failed (click for details)Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11285/artifact/TOPO9DEB10AMD64/TopotestLogs/ Topotests debian 10 amd64 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11285/artifact/TOPO9DEB10AMD64/TopotestDetails/ Topotests debian 10 amd64 part 9: No useful log foundTopotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-11285/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0 Successful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-11371/test Topology Tests failed for Topotests debian 10 amd64 part 0 Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-11371/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0 Topotests Ubuntu 18.04 i386 part 0: Failed (click for details)Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11371/artifact/TOPO0U18I386/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-11371/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0 Successful on other platforms/tests
|
|
I wonder if the topo test is checking for the v6 route too early now ... if this is delaying when the config goes in? |
|
@isabelladeleon12 still working on this? :-) |
|
@frrbot autoclose in 1 month |
(Reopen of #12924)
Before:
isisd generates its initial lsp before fully processing the written non-integrated config.
Ex: lsp_generate() is called in isis_instance_area_address_create(), before other configs that may affect the lsp are loaded in, like set-overload-bit.
After:
isisd generates its initial lsp as soon as the config is fully processed. This was done by passing isisd's existing config callbacks into the existing frr_config_pre/frr_config_post hooks so they can be called before and after the non-integrated config is processed.