bgpd: fix using bgp lu remote label when sending to ibgp peer #13606
Conversation
pguibert6WIND
force-pushed
the
bgp_lu_ebgp_to_ibgp_use_remote_label
branch
from
e55b754 to
1fe560a
Compare
I think this should not be in, while the label value is not correctly updated in adj-rib-out. |
pguibert6WIND
added
the
blocked
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-11768/test Topology Tests failed for Topotests debian 10 amd64 part 4 Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11768/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log foundTopotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-11768/test Topology Tests failed for Topotests debian 10 amd64 part 9 Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4U18I386-11768/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4 Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-11768/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9 Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-11768/artifact/TP4U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-11768/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4 Successful on other platforms/tests
|
|
Seems valid failures yet. |
pguibert6WIND
force-pushed
the
bgp_lu_ebgp_to_ibgp_use_remote_label
branch
from
1fe560a to
af94454
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-12312/test Topology Tests failed for Topotests debian 10 amd64 part 4 Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4U18I386-12312/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4 Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12312/artifact/TP4U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-12312/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4 Successful on other platforms/tests
|
pguibert6WIND
force-pushed
the
bgp_lu_ebgp_to_ibgp_use_remote_label
branch
2 times, most recently
from
6ea3e6e to
5aa0454
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 3: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-12420/test Topology Tests failed for Topotests debian 10 amd64 part 3 Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4U18I386-12420/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4 Topotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-12420/test Topology Tests failed for Topotests debian 10 amd64 part 4 Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12420/artifact/TP4U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-12420/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4 Topotests debian 10 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-12420/test Topology Tests failed for Topotests debian 10 amd64 part 7 Successful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 3: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-12421/test Topology Tests failed for Topotests debian 10 amd64 part 3 Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12421/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log foundSuccessful on other platforms/tests
|
pguibert6WIND
force-pushed
the
bgp_lu_ebgp_to_ibgp_use_remote_label
branch
from
5aa0454 to
322b87a
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12434/artifact/TP1U1804AMD64/TopotestDetails/Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-12434/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1 Topotests debian 10 amd64 part 3: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-12434/test Topology Tests failed for Topotests debian 10 amd64 part 3 Successful on other platforms/tests
|
| @@ -99,6 +99,10 @@ mpls_label_t bgp_adv_label(struct bgp_dest *dest, struct bgp_path_info *pi, | |||
| PEER_FLAG_FORCE_NEXTHOP_SELF)) | |||
| return remote_label; | |||
|
|
|||
| if (from->sort == BGP_PEER_IBGP && to->sort == BGP_PEER_IBGP && | |||
| !CHECK_FLAG(to->af_flags[afi][safi], PEER_FLAG_NEXTHOP_SELF)) | |||
There was a problem hiding this comment.
What if this is a reflected route and PEER_FLAG_FORCE_NEXTHOP_SELF is enabled?
There was a problem hiding this comment.
lets try to address it in one single if.
pguibert6WIND
force-pushed
the
bgp_lu_ebgp_to_ibgp_use_remote_label
branch
from
322b87a to
42f9682
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotests part 4: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13864/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log foundSuccessful on other platforms/tests
|
pguibert6WIND
force-pushed
the
bgp_lu_ebgp_to_ibgp_use_remote_label
branch
from
42f9682 to
538f95f
Compare
Continuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotests part 4: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13940/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
|
pguibert6WIND
force-pushed
the
bgp_lu_ebgp_to_ibgp_use_remote_label
branch
from
538f95f to
3eeae11
Compare
When redistributing an advertisement from an EBGP peer to an IBGP peer, and the next-hop is kept unchanged, then the remote label should be used. Fix this by checking the 'NEXTHOP_SELF' flag in the ibgp peer. Fixes: cd1964f ("bgpd: labeled unicast processing") Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
bgp_lu_ebgp_to_ibgp_use_remote_label
branch
from
3eeae11 to
54380e8
Compare
When redistributing an advertisement from an EBGP peer to an IBGP peer, and the next-hop is kept unchanged, then the remote label should be used.
Fix this by not extending the route reflector case to the ebgp to ibgp redistribution.
Fixes: cd1964f ("bgpd: labeled unicast processing")