Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mpls auto mode to update mpls control upon routing events #13965

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

zebra: change default mpls interface settings to auto mode

8ace966
Select commit
Loading
Failed to load commit list.
Open

add mpls auto mode to update mpls control upon routing events #13965

zebra: change default mpls interface settings to auto mode
8ace966
Select commit
Loading
Failed to load commit list.
frrbot / frrbot completed May 17, 2024 in 44s

Style and/or linter errors found

Style and/or linter errors found

Details

Thanks for your contribution to FRR!

Click for style suggestions 

diff --git a/tests/topotests/static_routing_mpls/test_static_routing_mpls.py b/tests/topotests/static_routing_mpls/test_static_routing_mpls.py
index da416b888..5b518f229 100644
--- a/tests/topotests/static_routing_mpls/test_static_routing_mpls.py
+++ b/tests/topotests/static_routing_mpls/test_static_routing_mpls.py
@@ -167,9 +167,7 @@ def test_mpls_zebra_route_nexthop():
         "r1, configuring a route with labeled nexthop address, checking that MPLS state is on on r1-eth1"
     )
     router = tgen.gears["r1"]
-    router.vtysh_cmd(
-        "config terminal\nip route 192.0.2.3/32 192.168.2.2 label 33"
-    )
+    router.vtysh_cmd("config terminal\nip route 192.0.2.3/32 192.168.2.2 label 33")
     assertmsg = "r1, interface r1-eth1, mpls operational state is off, not expected"
     assert _check_mpls_state(tgen.gears["r1"], "r1-eth1"), assertmsg
     # interface r1-eth1 should have mpls turned on
@@ -198,9 +196,7 @@ def test_mpls_interface_configured_delete():
         "r1, configuring a route with labeled nexthop address, checking that MPLS is configured on r1-eth1.100"
     )
     router = tgen.gears["r1"]
-    router.vtysh_cmd(
-        "config terminal\nip route 192.0.2.160/32 172.31.100.2 label 100"
-    )
+    router.vtysh_cmd("config terminal\nip route 192.0.2.160/32 172.31.100.2 label 100")
     # interface r1-eth1.100 should have mpls turned on
     assertmsg = "r1, interface r1-eth1.100, mpls operational state is off, not expected"
     assert _check_mpls_state(tgen.gears["r1"], "r1-eth1.100"), assertmsg

To apply the style suggestions:

curl https://gist.githubusercontent.com/polychaeta/62c31440d06eff96787a5e0b47f8b1b6/raw/349022a9bffccad749aa1eff72d24cc20c62a376/style.diff | git apply -

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

View more details on frrbot