Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib, vtysh: calculate the number of lines for better vtysh pagering. #14278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lib, vtysh: calculate the number of lines for better vtysh pagering. #14278

wants to merge 1 commit into from
+221 −17

Conversation

yasuhironet
Copy link
Contributor

It checks the lines of the output of the vty_out()s by buffering, and compare it with the terminal length before invoking the pager. Previously, the pager is always invoked regardless of the number of output lines when "terminal pager" is enabled. This is problematic if 1) "less" is invoked without "-F", or 2) "more" is used, in that the unnecessary paging lock occured even when there's no output. I imagine this is the reason why we can't enable terminal pager by default.

This patch replaces vty_out() (older is saved by the name: vty_out_old_pager()) and flushing the buffer is postponed to the vty_output_flush_vtysh_pager(), and when it is being flushed, the number of lines is calculated and used to decide whether the pager should be called. Also by this architecture change, we can remove FIXME about "exit" cmd, it enables better behaviors for "more" and "less" without "-F", and we might even make the "terminal pager" by default. Additionally, the pager is applied when help messages by "?" is longer than the screen.

@ton31337
Copy link
Member

Please check, there are a bunch of failures in topotests.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Aug 29, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO8U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO8U18I386/TopotestDetails/

Topotests debian 10 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-13825/test

Topology Tests failed for Topotests debian 10 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO8DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO8DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO4U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 4: No useful log found
Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests debian 10 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-13825/test

Topology Tests failed for Topotests debian 10 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO3DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 3: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO3DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO6U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO6U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 3: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO3U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 3: No useful log found
Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4U18I386-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO4U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 4: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO4U18I386/TopotestDetails/

Topotests debian 10 amd64 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO4DEB10AMD64-13825/test

Topology Tests failed for Topotests debian 10 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO4DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 4: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO4DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details) Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO3U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO3U18I386/TopotestLogs/log_topotests.txt

Topotests debian 10 amd64 part 2: Incomplete (check logs for details)
Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO9U18I386/TopotestDetails/

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1DEB10AMD64-13825/test

Topology Tests failed for Topotests debian 10 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO1DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO1DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO8U18ARM64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO8U18ARM64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO1U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO1U18I386/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO0U18ARM8/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO0U18ARM8/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO6U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO6U18I386/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 5: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO5U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 5: No useful log found
Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPOU1804/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPOU1804/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-13825/test

Topology Tests failed for Topotests debian 10 amd64 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO6DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO6DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO1U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO7U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO7U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18AMD64-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO5U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO5U18AMD64/TopotestDetails/

Topotests debian 10 amd64 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5DEB10AMD64-13825/test

Topology Tests failed for Topotests debian 10 amd64 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO5DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO5DEB10AMD64/TopotestDetails/

Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-13825/test

Topology Tests failed for Topotests debian 10 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO0DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO0DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 2: Incomplete (check logs for details)
Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO7U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 7: No useful log found
Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TP4U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TP4U1804AMD64/TopotestLogs/log_topotests.txt

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-13825/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found
Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TP3U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP3U1804AMD64-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TP3U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO7U18I386/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 2: Incomplete (check logs for details)
Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TP1U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TP1U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 5: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO5U18I386-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 5
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO5U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 5: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO5U18I386/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO0U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO0U18I386/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 2: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TP2U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP2U1804AMD64-13825/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 2
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TP2U1804AMD64/TopotestLogs/log_topotests.txt

Topotests debian 10 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-13825/test

Topology Tests failed for Topotests debian 10 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO7DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13825/artifact/TOPO7DEB10AMD64/TopotestDetails/

Successful on other platforms/tests
  • Addresssanitizer topotests part 0
  • Debian 10 deb pkg check
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 1
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 7
  • Static analyzer (clang)
  • Ubuntu 20.04 deb pkg check
  • Addresssanitizer topotests part 5
  • Addresssanitizer topotests part 2
  • Addresssanitizer topotests part 3
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 9
  • Addresssanitizer topotests part 8
  • Addresssanitizer topotests part 6
  • Ubuntu 18.04 deb pkg check

@frrbot frrbot bot added the bugfix label Sep 28, 2023
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 28, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14395/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14395/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 amd64 part 7
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 4
  • CentOS 7 rpm pkg check
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 3
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 8
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 8
  • Topotests debian 10 amd64 part 4
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests debian 10 amd64 part 2
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 arm8 part 0
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 6
  • Addresssanitizer topotests part 7
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 5

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14395/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found 
Report for buffer.h | 6 issues
===============================================
< WARNING: function definition argument 'const void *' should also have an identifier name
< #29: FILE: /tmp/f1-3924183/buffer.h:29:
< WARNING: function definition argument 'size_t' should also have an identifier name
< #29: FILE: /tmp/f1-3924183/buffer.h:29:
< WARNING: function definition argument 'struct buffer *' should also have an identifier name
< #31: FILE: /tmp/f1-3924183/buffer.h:31:
Report for vty.c | 2 issues
===============================================
< WARNING: please, no spaces at the start of a line
< #498: FILE: /tmp/f1-3924183/vty.c:498:

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14396/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14396/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Successful on other platforms/tests
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 4
  • CentOS 7 rpm pkg check
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 3
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 i386 part 0
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests debian 10 amd64 part 3
  • Topotests debian 10 amd64 part 8
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 9
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 4
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 2
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 7
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 6
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 5
  • Addresssanitizer topotests part 5
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 1

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14396/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log found 
Report for buffer.h | 6 issues
===============================================
< WARNING: function definition argument 'const void *' should also have an identifier name
< #29: FILE: /tmp/f1-3981416/buffer.h:29:
< WARNING: function definition argument 'size_t' should also have an identifier name
< #29: FILE: /tmp/f1-3981416/buffer.h:29:
< WARNING: function definition argument 'struct buffer *' should also have an identifier name
< #31: FILE: /tmp/f1-3981416/buffer.h:31:
Report for vty.c | 2 issues
===============================================
< WARNING: please, no spaces at the start of a line
< #498: FILE: /tmp/f1-3981416/vty.c:498:

@yasuhironet
Copy link
Contributor Author

I fixed one important bug that corrupts the output of show commands in json.

After the fix, it comes down to just five BGP SRv6 L3VPN tests on Ubuntu 18 ARM have failed.
Those tests seem to be skipped in x86.

And now I am not sure about what should be done next...

@donaldsharp
Copy link
Member

@yasuhironet -> The Checkout code: Successful with additional warnings warnings need to be fixed from our perspective. Review will happen after that.

@github-actions github-actions bot added the rebase PR needs rebase label Oct 13, 2023
@yasuhironet
lib, vtysh: calculate the number of lines for better vtysh pagering.
cb69264 
It checks the lines of the output of the vty_out()s by buffering,
and compare it with the terminal length before invoking the pager.
Previously, the pager is always invoked regardless of the number of
output lines when "terminal pager" is enabled. This is problematic if
1) "less" is invoked without "-F", or 2) "more" is used, in that
the unnecessary paging lock occured even when there's no output.
I imagine this is the reason why we can't enable terminal pager
by default.

This patch replaces vty_out() (older is saved by the name:
vty_out_old_pager()) and flushing the buffer is postponed
to the vty_output_flush_vtysh_pager(), and when it is being
flushed, the number of lines is calculated and used to decide whether
the pager should be called. Also by this architecture change,
we can remove FIXME about "exit" cmd, it enables better behaviors for
"more" and "less" without "-F", and we might even make
the "terminal pager" by default. Additionally, the pager is applied
when help messages by "?" is longer than the screen.

Signed-off-by: Yasuhiro Ohara <[email protected]>
@yasuhironet
Copy link
Contributor Author

@donaldsharp Thank you. I didn't know the warnings were the blocking issues.

@yasuhironet
Copy link
Contributor Author

yasuhironet commented Oct 13, 2023 via email

@yasuhironet
Copy link
Contributor Author

hmmmm

failed:

  • Ubuntu 18.04 arm8 Part 4: bgp_lu_explicitnull.test_bgp_lu_explicitnull test_converge_bgplu
    E AssertionError: r1, prefix 192.168.2.2/32 from r2 not present
  • Ubuntu 18.04 i386 Part 4: bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf test_check_scale_down
    E Failed: New core[s] found: /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/ce1/zebra_core-sig_6-pid_27856.dmp

(in search for a hint for debug)
Are these tests also tested (and succeeded) on other platforms in this CI run?

I changed my affiliation recently and can't access to any server for development anymore...

@donaldsharp
Copy link
Member

ci:rerun

@donaldsharp
Copy link
Member 

BEFORE:

Displayed  944113 routes and 1888224 total paths

________________________________________________________
Executed in   54.06 secs   fish           external 
   usr time    3.69 secs    0.00 micros    3.69 secs 
   sys time   10.61 secs  1204.00 micros   10.61 secs 


—————————

AFTER:

Displayed  944102 routes and 1888202 total paths

________________________________________________________
Executed in   95.96 secs   fish           external 
   usr time    2.71 secs  1255.00 micros    2.71 secs 
   sys time    9.31 secs  419.00 micros    9.31 secs

I decided to run this against 2 full bgp feeds that I have running locally. Before these changes the timed run took 54 seconds after it takes 95 seconds.

This is a NACK from me until performance is in the same ballpark

donaldsharp
donaldsharp requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@donaldsharp donaldsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK this introduces far too much additional time dumping state.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldsharp donaldsharp donaldsharp requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
autoclose bugfix conflicts libfrr master rebase PR needs rebase size/L vtysh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yasuhironet @ton31337 @NetDEF-CI @donaldsharp