Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgmtd: Support for operational data retrieval via MGMT frontend interface. #14428

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

mgmtd: Support for operational data retrieval via MGMT frontend interface. #14428

wants to merge 5 commits into from

Conversation

manojvn
Copy link
Contributor

@manojvn manojvn commented Sep 16, 2023 •
edited by pushpasis
Loading

This is a full fledge implementation for retrieving operational state/data from one (or more) backend component (provided the component already supports providing operational state through northbound layer). This is based on the architectural/design discussions on MGMTd we had way back in 2021 (request you to refer to the slides on MGMTd architecture and design on the 'yang' slack channel). Previously when we implemented the Config workflow some of the ground work (especially on the front-end interface, as well as some on the main MGMTd daemonn) was done already. This PR completes the work needed on the MGMTd daemon and the MGMT backend client library needed for MGMTd to get operational data from or one or more backend clients corresponding to the single GET-DATA request received on front-end interface.

We have added Zebra as a new MGMT backend client as Zebra was already supporting providing operational state via Northbound layer. Adding zebra helped us portray the functionalities implemented in this PR as well.

We have also introduced support for wildcard characters in the Yang GET-DATA query URL. Some of the code is written to specifically take care of matching and resolving YANG URLs containing wildcard characters to absolute YANG data URLS and return them all as part of the response. Part of the resolution happens on the MGMTd based on the individual component Yang Path mapping/ subscription registry. This is done to figure out all the backend clients involved in the specific GET-DATA request from front-end client (along with the exact data subtrees they need reply to). Rest of the resolution actual data items happens on the backend client. Some examples of wildcard supports are..

  1. Retrieve a specific route across all tables in Zebra
frr# do sh mgmt get-data operational /frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='*'][table-id='*']/route[prefix='1.1.1.1/32']/
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/distance": "0"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/metric": "0"
  ...
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-multicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/distance": "0"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-multicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/metric": "0"
  ...
frr#
  1. Find the distances of all the routes across IPV4-unicast AFI-SAFI
frr# do sh mgmt get-data operational /frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='*']/route[prefix='*']/route-entry[protocol='*']/distance
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='0.0.0.0/0']/route-entry[protocol='kernel']/distance": "0"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/distance": "0"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='10.0.1.0/24']/route-entry[protocol='connected']/distance": "0"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='10.0.2.0/24']/route-entry[protocol='connected']/distance": "0"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='10.108.184.0/23']/route-entry[protocol='connected']/distance": "0"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='11.11.11.11/32']/route-entry[protocol='static']/distance": "1"
frr#
  1. Find all the static routes across all the AFI-SAFIs
frr# do sh mgmt get-data operational /frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='*'][table-id='*']/route[prefix='*']/route-entry[protocol='static']/
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='11.11.11.11/32']/route-entry[protocol='static']/distance": "1"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='11.11.11.11/32']/route-entry[protocol='static']/metric": "0"
  ...
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='11.11.11.11/32']/route-entry[protocol='static']/nexthop-group/id": "20"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='11.11.11.11/32']/route-entry[protocol='static']/nexthop-group/nexthop[nh-type='blackhole'][vrf='0'][gateway=''][interface=' ']/active": "(null)"
  ...
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='11.11.11.11/32']/route-entry[protocol='static']/nexthop-group/nexthop[nh-type='blackhole'][vrf='0'][gateway=''][interface=' ']/bh-type": "null"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='abcd::11:11:11:11/128']/route-entry[protocol='static']/distance": "1"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='abcd::11:11:11:11/128']/route-entry[protocol='static']/metric": "0"
  ...
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='abcd::11:11:11:11/128']/route-entry[protocol='static']/nexthop-group/id": "22"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='abcd::11:11:11:11/128']/route-entry[protocol='static']/nexthop-group/nexthop[nh-type='blackhole'][vrf='0'][gateway=''][interface=' ']/active": "(null)"
  ...
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='abcd::11:11:11:11/128']/route-entry[protocol='static']/nexthop-group/nexthop[nh-type='blackhole'][vrf='0'][gateway=''][interface=' ']/bh-type": "null"
frr#
  1. Get the entire operational state maintained on the device across all the MGMT backend clients.
frr# do sh mgmt get-data operational /
  ...
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/distance": "0"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/metric": "0"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/selected": "(null)"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/installed": "(null)"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/internal-flags": "8"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/internal-status": "16"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/uptime": "2023-09-14T07:23:12.488160Z"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/nexthop-group/id": "10"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/nexthop-group/nexthop[nh-type='ifindex'][vrf='0'][gateway=''][interface='lo']/active": "(null)"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-unicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/nexthop-group/nexthop[nh-type='ifindex'][vrf='0'][gateway=''][interface='lo']/fib": "(null)"
  ...
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-multicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/distance": "0"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-multicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/metric": "0"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-multicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/selected": "(null)"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-multicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/internal-flags": "8"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-multicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/uptime": "2023-09-14T07:23:12.488159Z"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-multicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/nexthop-group/id": "10"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-multicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/nexthop-group/nexthop[nh-type='ifindex'][vrf='0'][gateway=''][interface='lo']/active": "(null)"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv4-multicast'][table-id='254']/route[prefix='1.1.1.1/32']/route-entry[protocol='connected']/nexthop-group/nexthop[nh-type='ifindex'][vrf='0'][gateway=''][interface='lo']/fib": "(null)"
  ...
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='2402:740:2:207::/64']/route-entry[protocol='connected']/distance": "0"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='2402:740:2:207::/64']/route-entry[protocol='connected']/metric": "0"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='2402:740:2:207::/64']/route-entry[protocol='connected']/selected": "(null)"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='2402:740:2:207::/64']/route-entry[protocol='connected']/installed": "(null)"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='2402:740:2:207::/64']/route-entry[protocol='connected']/internal-flags": "8"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='2402:740:2:207::/64']/route-entry[protocol='connected']/internal-status": "16"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='2402:740:2:207::/64']/route-entry[protocol='connected']/uptime": "2023-09-14T07:23:12.488159Z"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='2402:740:2:207::/64']/route-entry[protocol='connected']/nexthop-group/id": "14"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='2402:740:2:207::/64']/route-entry[protocol='connected']/nexthop-group/nexthop[nh-type='ifindex'][vrf='0'][gateway=''][interface='ens160']/active": "(null)"
  "/frr-vrf:lib/vrf[name='default']/frr-zebra:zebra/ribs/rib[afi-safi-name='frr-routing:ipv6-unicast'][table-id='254']/route[prefix='2402:740:2:207::/64']/route-entry[protocol='connected']/nexthop-group/nexthop[nh-type='ifindex'][vrf='0'][gateway=''][interface='ens160']/fib": "(null)"
  ...
  "/frr-vrf:lib/vrf[name='default']/state/id": "0"
  "/frr-interface:lib/interface[name='ens160']/vrf": "default"
  "/frr-interface:lib/interface[name='ens160']/state/if-index": "2"
  "/frr-interface:lib/interface[name='ens160']/state/mtu": "1500"
  "/frr-interface:lib/interface[name='ens160']/state/mtu6": "1500"
  "/frr-interface:lib/interface[name='ens160']/state/speed": "10000"
  "/frr-interface:lib/interface[name='ens160']/state/metric": "0"
  "/frr-interface:lib/interface[name='ens160']/state/phy-address": "00:50:56:b7:b7:a0"
  ...
frr#

The PR contains changes related to mgmt daemon, mgmt client and utility libraries, documentation and tests.

@frrbot frrbot bot added documentation libfrr tests Topotests, make check, etc zebra labels Sep 16, 2023
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 16, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
mgmtd/mgmt_txn.c: In function mgmt_txn_notify_be_getdata_req_reply:
./lib/zlog.h:109:20: error: format %lu expects argument of type long unsigned int, but argument 5 has type size_t {aka unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
./lib/debug.h:210:4: note: in expansion of macro zlog_debug
./lib/debug.h:218:32: note: in expansion of macro DEBUG
 #define DEBUGD(name, fmt, ...) DEBUG(debug, name, fmt, ##__VA_ARGS__)
mgmtd/mgmt_txn.c:18:2: note: in expansion of macro DEBUGD

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
mgmtd/mgmt_txn.c: In function mgmt_txn_notify_be_getdata_req_reply:
./lib/zlog.h:109:20: error: format %lu expects argument of type long unsigned int, but argument 5 has type size_t {aka unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
./lib/debug.h:210:4: note: in expansion of macro zlog_debug
./lib/debug.h:218:32: note: in expansion of macro DEBUG
 #define DEBUGD(name, fmt, ...) DEBUG(debug, name, fmt, ##__VA_ARGS__)
mgmtd/mgmt_txn.c:18:2: note: in expansion of macro DEBUGD
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14198/frr-source'
lib/mgmt_util.c: In function mgmt_xpath_resolve_wildcard:
lib/mgmt_util.c:314:2: error: strncpy specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10589: lib/mgmt_util.lo] Error 1
In file included from ./lib/log.h:17,
mgmtd/mgmt_txn.c: In function mgmt_txn_process_get_data:
./lib/zlog.h:109:20: error: format %Lx expects argument of type uint64_t, but argument 6 has type long long unsigned int [-Werror=format=]
./lib/zlog.h:112:26: note: in expansion of macro _zlog_ecref

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/DEB11AMD64/config.status/config.status

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.14198/frr-source'
mgmtd/mgmt_ds.c:598:5: error: variable 'ds_ctx' is uninitialized when used here [-Werror,-Wuninitialized]
mgmtd/mgmt_ds.c:577:28: note: initialize the variable 'ds_ctx' to silence this warning
1 error generated.
gmake[1]: *** [Makefile:10572: mgmtd/mgmt_ds.o] Error 1
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14198/frr-source'
lib/mgmt_util.c: In function mgmt_xpath_resolve_wildcard:
lib/mgmt_util.c:314:2: error: strncpy specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10585: lib/mgmt_util.lo] Error 1
/home/ci/cibuild.14198/frr-source/doc/user/pbr.rst:32: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14198/frr-source/doc/user/nexthop_groups.rst
make[1]: Leaving directory '/home/ci/cibuild.14198/frr-source'
make[1]: Target 'all-am' not remade because of errors.
make: *** [Makefile:6444: all] Error 2

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/REDHAT8/config.log/config.log.gz

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14198/frr-source'
lib/mgmt_util.c: In function mgmt_xpath_resolve_wildcard:
lib/mgmt_util.c:314:2: error: strncpy specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10586: lib/mgmt_util.lo] Error 1
/home/ci/cibuild.14198/frr-source/doc/user/pbr.rst:32: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14198/frr-source/doc/user/nexthop_groups.rst
make[1]: Leaving directory '/home/ci/cibuild.14198/frr-source'
make[1]: Target 'all-am' not remade because of errors.
make: *** [Makefile:6445: all] Error 2

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/DEB10BUILD/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from /usr/include/string.h:495,
In function strncpy,
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: __builtin_strncpy specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10586: lib/mgmt_util.lo] Error 1
/home/ci/cibuild.14198/frr-source/doc/user/pbr.rst:32: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14198/frr-source/doc/user/nexthop_groups.rst
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.14198/frr-source'
make: *** [Makefile:6445: all] Error 2

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

In file included from /usr/include/string.h:535,
In function strncpy,
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:95:10: error: __builtin_strncpy specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10589: lib/mgmt_util.lo] Error 1
frr.texi:18: warning: @definfoenclose is obsolete.
frr.texi:19: warning: @definfoenclose is obsolete.
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.14198/frr-source'

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U22AMD64BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.14198/frr-source'
lib/mgmt_util.c: In function 'mgmt_xpath_resolve_wildcard':
lib/mgmt_util.c:314:2: error: 'strncpy' specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10588: lib/mgmt_util.lo] Error 1
/usr/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/usr/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/usr/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd
/usr/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:67: WARNING: duplicate clicmd description of log-adjacency-changes, other instance in fabricd
Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/RH9BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14198/frr-source'
lib/mgmt_util.c: In function mgmt_xpath_resolve_wildcard:
lib/mgmt_util.c:314:9: error: strncpy specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10586: lib/mgmt_util.lo] Error 1
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:67: WARNING: duplicate clicmd description of log-adjacency-changes, other instance in fabricd

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/RH9BUILD/config.log/config.log.gz

Successful on other platforms/tests
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 arm8 build
  • CentOS 7 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 18.04 ppc64le build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
mgmtd/mgmt_txn.c: In function mgmt_txn_notify_be_getdata_req_reply:
./lib/zlog.h:109:20: error: format %lu expects argument of type long unsigned int, but argument 5 has type size_t {aka unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
./lib/debug.h:210:4: note: in expansion of macro zlog_debug
./lib/debug.h:218:32: note: in expansion of macro DEBUG
 #define DEBUGD(name, fmt, ...) DEBUG(debug, name, fmt, ##__VA_ARGS__)
mgmtd/mgmt_txn.c:18:2: note: in expansion of macro DEBUGD

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
mgmtd/mgmt_txn.c: In function mgmt_txn_notify_be_getdata_req_reply:
./lib/zlog.h:109:20: error: format %lu expects argument of type long unsigned int, but argument 5 has type size_t {aka unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
./lib/debug.h:210:4: note: in expansion of macro zlog_debug
./lib/debug.h:218:32: note: in expansion of macro DEBUG
 #define DEBUGD(name, fmt, ...) DEBUG(debug, name, fmt, ##__VA_ARGS__)
mgmtd/mgmt_txn.c:18:2: note: in expansion of macro DEBUGD
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14198/frr-source'
lib/mgmt_util.c: In function mgmt_xpath_resolve_wildcard:
lib/mgmt_util.c:314:2: error: strncpy specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10589: lib/mgmt_util.lo] Error 1
In file included from ./lib/log.h:17,
mgmtd/mgmt_txn.c: In function mgmt_txn_process_get_data:
./lib/zlog.h:109:20: error: format %Lx expects argument of type uint64_t, but argument 6 has type long long unsigned int [-Werror=format=]
./lib/zlog.h:112:26: note: in expansion of macro _zlog_ecref

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/DEB11AMD64/config.status/config.status

OpenBSD 7 amd64 build: Failed (click for details) OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.14198/frr-source'
mgmtd/mgmt_ds.c:598:5: error: variable 'ds_ctx' is uninitialized when used here [-Werror,-Wuninitialized]
mgmtd/mgmt_ds.c:577:28: note: initialize the variable 'ds_ctx' to silence this warning
1 error generated.
gmake[1]: *** [Makefile:10572: mgmtd/mgmt_ds.o] Error 1
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14198/frr-source'
lib/mgmt_util.c: In function mgmt_xpath_resolve_wildcard:
lib/mgmt_util.c:314:2: error: strncpy specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10585: lib/mgmt_util.lo] Error 1
/home/ci/cibuild.14198/frr-source/doc/user/pbr.rst:32: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14198/frr-source/doc/user/nexthop_groups.rst
make[1]: Leaving directory '/home/ci/cibuild.14198/frr-source'
make[1]: Target 'all-am' not remade because of errors.
make: *** [Makefile:6444: all] Error 2

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/REDHAT8/config.log/config.log.gz

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14198/frr-source'
lib/mgmt_util.c: In function mgmt_xpath_resolve_wildcard:
lib/mgmt_util.c:314:2: error: strncpy specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10586: lib/mgmt_util.lo] Error 1
/home/ci/cibuild.14198/frr-source/doc/user/pbr.rst:32: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14198/frr-source/doc/user/nexthop_groups.rst
make[1]: Leaving directory '/home/ci/cibuild.14198/frr-source'
make[1]: Target 'all-am' not remade because of errors.
make: *** [Makefile:6445: all] Error 2

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/DEB10BUILD/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from /usr/include/string.h:495,
In function strncpy,
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: __builtin_strncpy specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10586: lib/mgmt_util.lo] Error 1
/home/ci/cibuild.14198/frr-source/doc/user/pbr.rst:32: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14198/frr-source/doc/user/nexthop_groups.rst
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.14198/frr-source'
make: *** [Makefile:6445: all] Error 2

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

In file included from /usr/include/string.h:535,
In function strncpy,
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:95:10: error: __builtin_strncpy specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10589: lib/mgmt_util.lo] Error 1
frr.texi:18: warning: @definfoenclose is obsolete.
frr.texi:19: warning: @definfoenclose is obsolete.
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.14198/frr-source'

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/U22AMD64BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.14198/frr-source'
lib/mgmt_util.c: In function 'mgmt_xpath_resolve_wildcard':
lib/mgmt_util.c:314:2: error: 'strncpy' specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10588: lib/mgmt_util.lo] Error 1
/usr/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/usr/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/usr/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd
/usr/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:67: WARNING: duplicate clicmd description of log-adjacency-changes, other instance in fabricd
Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/RH9BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14198/frr-source'
lib/mgmt_util.c: In function mgmt_xpath_resolve_wildcard:
lib/mgmt_util.c:314:9: error: strncpy specified bound 1024 equals destination size [-Werror=stringop-truncation]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10586: lib/mgmt_util.lo] Error 1
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd
/home/ci/cibuild.14198/frr-source/doc/user/isisd.rst:67: WARNING: duplicate clicmd description of log-adjacency-changes, other instance in fabricd

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14198/artifact/RH9BUILD/config.log/config.log.gz

<stdin>:17: trailing whitespace.
of validating any data under these data portions, by specifying only 
<stdin>:46: trailing whitespace.
'MGMT_SUBSCR_VALIDATE_CFG' and 'MGMT_SUBSCR_OPER_OWN' values for the 
<stdin>:168: trailing whitespace.
 
<stdin>:234: trailing whitespace.
	
<stdin>:335: trailing whitespace.
	reply.next_indx = 
warning: squelched 59 whitespace errors
warning: 64 lines add whitespace errors.
Report for mgmt_be_adapter.c | 30 issues
===============================================
< ERROR: code indent should use tabs where possible
< #773: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:773:
< WARNING: please, no space before tabs
< #773: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:773:
< WARNING: please, no spaces at the start of a line
< #773: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:773:
< ERROR: trailing whitespace
< #786: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:786:
< WARNING: please, no spaces at the start of a line
< #786: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:786:
< ERROR: trailing whitespace
< #792: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:792:
< ERROR: code indent should use tabs where possible
< #823: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:823:
< WARNING: please, no space before tabs
< #823: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:823:
< WARNING: please, no spaces at the start of a line
< #823: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:823:
< ERROR: trailing whitespace
< #826: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:826:
< WARNING: please, no spaces at the start of a line
< #826: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:826:
< ERROR: trailing whitespace
< #878: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:878:
< WARNING: please, no spaces at the start of a line
< #878: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:878:
< WARNING: space prohibited between function name and open parenthesis '('
< #932: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:932:
< WARNING: unnecessary whitespace before a quoted newline
< #977: FILE: /tmp/f1-2704116/mgmt_be_adapter.c:977:
Report for mgmt_be_adapter.h | 18 issues
===============================================
< ERROR: trailing whitespace
< #91: FILE: /tmp/f1-2704116/mgmt_be_adapter.h:91:
< WARNING: please, no spaces at the start of a line
< #91: FILE: /tmp/f1-2704116/mgmt_be_adapter.h:91:
< ERROR: code indent should use tabs where possible
< #104: FILE: /tmp/f1-2704116/mgmt_be_adapter.h:104:
< WARNING: please, no space before tabs
< #104: FILE: /tmp/f1-2704116/mgmt_be_adapter.h:104:
< WARNING: please, no spaces at the start of a line
< #104: FILE: /tmp/f1-2704116/mgmt_be_adapter.h:104:
< WARNING: please, no space before tabs
< #232: FILE: /tmp/f1-2704116/mgmt_be_adapter.h:232:
< WARNING: please, no space before tabs
< #233: FILE: /tmp/f1-2704116/mgmt_be_adapter.h:233:
< WARNING: please, no space before tabs
< #234: FILE: /tmp/f1-2704116/mgmt_be_adapter.h:234:
< WARNING: please, no space before tabs
< #235: FILE: /tmp/f1-2704116/mgmt_be_adapter.h:235:
Report for mgmt_be_client.c | 28 issues
===============================================
< ERROR: trailing whitespace
< #87: FILE: /tmp/f1-2704116/mgmt_be_client.c:87:
< WARNING: please, no spaces at the start of a line
< #87: FILE: /tmp/f1-2704116/mgmt_be_client.c:87:
< ERROR: trailing whitespace
< #222: FILE: /tmp/f1-2704116/mgmt_be_client.c:222:
< ERROR: trailing whitespace
< #848: FILE: /tmp/f1-2704116/mgmt_be_client.c:848:
< ERROR: trailing whitespace
< #909: FILE: /tmp/f1-2704116/mgmt_be_client.c:909:
< ERROR: trailing whitespace
< #977: FILE: /tmp/f1-2704116/mgmt_be_client.c:977:
< WARNING: suspect code indent for conditional statements (8, 24)
< #1024: FILE: /tmp/f1-2704116/mgmt_be_client.c:1024:
< WARNING: braces {} are not necessary for single statement blocks
< #1035: FILE: /tmp/f1-2704116/mgmt_be_client.c:1035:
< ERROR: code indent should use tabs where possible
< #1098: FILE: /tmp/f1-2704116/mgmt_be_client.c:1098:
< WARNING: please, no spaces at the start of a line
< #1098: FILE: /tmp/f1-2704116/mgmt_be_client.c:1098:
< ERROR: code indent should use tabs where possible
< #1099: FILE: /tmp/f1-2704116/mgmt_be_client.c:1099:
< WARNING: please, no spaces at the start of a line
< #1099: FILE: /tmp/f1-2704116/mgmt_be_client.c:1099:
< ERROR: code indent should use tabs where possible
< #1100: FILE: /tmp/f1-2704116/mgmt_be_client.c:1100:
< WARNING: please, no spaces at the start of a line
< #1100: FILE: /tmp/f1-2704116/mgmt_be_client.c:1100:
Report for mgmt_ds.c | 8 issues
===============================================
< ERROR: code indent should use tabs where possible
< #168: FILE: /tmp/f1-2704116/mgmt_ds.c:168:
< WARNING: please, no space before tabs
< #168: FILE: /tmp/f1-2704116/mgmt_ds.c:168:
< ERROR: trailing whitespace
< #237: FILE: /tmp/f1-2704116/mgmt_ds.c:237:
< WARNING: Consider removing the code enclosed by this #if 0 and its #endif
< #554: FILE: /tmp/f1-2704116/mgmt_ds.c:554:
Report for mgmt_fe_adapter.c | 2 issues
===============================================
< ERROR: spaces required around that '?' (ctx:WxV)
< #463: FILE: /tmp/f1-2704116/mgmt_fe_adapter.c:463:
Report for mgmt_txn.c | 132 issues
===============================================
< ERROR: trailing whitespace
< #211: FILE: /tmp/f1-2704116/mgmt_txn.c:211:
< ERROR: trailing whitespace
< #454: FILE: /tmp/f1-2704116/mgmt_txn.c:454:
< WARNING: please, no spaces at the start of a line
< #454: FILE: /tmp/f1-2704116/mgmt_txn.c:454:
< ERROR: trailing whitespace
< #459: FILE: /tmp/f1-2704116/mgmt_txn.c:459:
< ERROR: trailing whitespace
< #487: FILE: /tmp/f1-2704116/mgmt_txn.c:487:
< ERROR: trailing whitespace
< #491: FILE: /tmp/f1-2704116/mgmt_txn.c:491:
< ERROR: trailing whitespace
< #498: FILE: /tmp/f1-2704116/mgmt_txn.c:498:
< ERROR: trailing whitespace
< #500: FILE: /tmp/f1-2704116/mgmt_txn.c:500:
< ERROR: trailing whitespace
< #522: FILE: /tmp/f1-2704116/mgmt_txn.c:522:
< ERROR: trailing whitespace
< #525: FILE: /tmp/f1-2704116/mgmt_txn.c:525:
< ERROR: trailing whitespace
< #530: FILE: /tmp/f1-2704116/mgmt_txn.c:530:
< ERROR: trailing whitespace
< #533: FILE: /tmp/f1-2704116/mgmt_txn.c:533:
< ERROR: trailing whitespace
< #538: FILE: /tmp/f1-2704116/mgmt_txn.c:538:
< ERROR: trailing whitespace
< #541: FILE: /tmp/f1-2704116/mgmt_txn.c:541:
< ERROR: trailing whitespace
< #545: FILE: /tmp/f1-2704116/mgmt_txn.c:545:
< ERROR: trailing whitespace
< #550: FILE: /tmp/f1-2704116/mgmt_txn.c:550:
< ERROR: trailing whitespace
< #555: FILE: /tmp/f1-2704116/mgmt_txn.c:555:
< ERROR: trailing whitespace
< #567: FILE: /tmp/f1-2704116/mgmt_txn.c:567:
< ERROR: trailing whitespace
< #571: FILE: /tmp/f1-2704116/mgmt_txn.c:571:
< ERROR: trailing whitespace
< #582: FILE: /tmp/f1-2704116/mgmt_txn.c:582:
< ERROR: trailing whitespace
< #970: FILE: /tmp/f1-2704116/mgmt_txn.c:970:
< WARNING: please, no spaces at the start of a line
< #970: FILE: /tmp/f1-2704116/mgmt_txn.c:970:
< ERROR: trailing whitespace
< #1312: FILE: /tmp/f1-2704116/mgmt_txn.c:1312:
< ERROR: code indent should use tabs where possible
< #1381: FILE: /tmp/f1-2704116/mgmt_txn.c:1381:
< WARNING: please, no space before tabs
< #1381: FILE: /tmp/f1-2704116/mgmt_txn.c:1381:
< WARNING: please, no spaces at the start of a line
< #1381: FILE: /tmp/f1-2704116/mgmt_txn.c:1381:
< ERROR: code indent should use tabs where possible
< #1382: FILE: /tmp/f1-2704116/mgmt_txn.c:1382:
< WARNING: please, no space before tabs
< #1382: FILE: /tmp/f1-2704116/mgmt_txn.c:1382:
< WARNING: please, no spaces at the start of a line
< #1382: FILE: /tmp/f1-2704116/mgmt_txn.c:1382:
< ERROR: code indent should use tabs where possible
< #1384: FILE: /tmp/f1-2704116/mgmt_txn.c:1384:
< WARNING: please, no space before tabs
< #1384: FILE: /tmp/f1-2704116/mgmt_txn.c:1384:
< ERROR: code indent should use tabs where possible
< #1386: FILE: /tmp/f1-2704116/mgmt_txn.c:1386:
< WARNING: please, no space before tabs
< #1386: FILE: /tmp/f1-2704116/mgmt_txn.c:1386:
< ERROR: code indent should use tabs where possible
< #1387: FILE: /tmp/f1-2704116/mgmt_txn.c:1387:
< WARNING: please, no space before tabs
< #1387: FILE: /tmp/f1-2704116/mgmt_txn.c:1387:
< WARNING: please, no spaces at the start of a line
< #1387: FILE: /tmp/f1-2704116/mgmt_txn.c:1387:
< ERROR: trailing whitespace
< #1710: FILE: /tmp/f1-2704116/mgmt_txn.c:1710:
< WARNING: please, no space before tabs
< #1934: FILE: /tmp/f1-2704116/mgmt_txn.c:1934:
< ERROR: trailing whitespace
< #2217: FILE: /tmp/f1-2704116/mgmt_txn.c:2217:
< ERROR: trailing whitespace
< #2230: FILE: /tmp/f1-2704116/mgmt_txn.c:2230:
< ERROR: code indent should use tabs where possible
< #2280: FILE: /tmp/f1-2704116/mgmt_txn.c:2280:
< WARNING: please, no space before tabs
< #2280: FILE: /tmp/f1-2704116/mgmt_txn.c:2280:
< WARNING: please, no spaces at the start of a line
< #2280: FILE: /tmp/f1-2704116/mgmt_txn.c:2280:
< ERROR: trailing whitespace
< #2293: FILE: /tmp/f1-2704116/mgmt_txn.c:2293:
< WARNING: please, no spaces at the start of a line
< #2293: FILE: /tmp/f1-2704116/mgmt_txn.c:2293:
< WARNING: braces {} are not necessary for single statement blocks
< #2354: FILE: /tmp/f1-2704116/mgmt_txn.c:2354:
< ERROR: trailing whitespace
< #2368: FILE: /tmp/f1-2704116/mgmt_txn.c:2368:
< ERROR: trailing whitespace
< #2382: FILE: /tmp/f1-2704116/mgmt_txn.c:2382:
< ERROR: trailing whitespace
< #2383: FILE: /tmp/f1-2704116/mgmt_txn.c:2383:
< WARNING: Missing a blank line after declarations
< #2388: FILE: /tmp/f1-2704116/mgmt_txn.c:2388:
< ERROR: trailing whitespace
< #2393: FILE: /tmp/f1-2704116/mgmt_txn.c:2393:
< WARNING: braces {} are not necessary for single statement blocks
< #2403: FILE: /tmp/f1-2704116/mgmt_txn.c:2403:
< ERROR: trailing whitespace
< #2511: FILE: /tmp/f1-2704116/mgmt_txn.c:2511:
< ERROR: code indent should use tabs where possible
< #3017: FILE: /tmp/f1-2704116/mgmt_txn.c:3017:
< WARNING: please, no space before tabs
< #3017: FILE: /tmp/f1-2704116/mgmt_txn.c:3017:
< WARNING: please, no spaces at the start of a line
< #3017: FILE: /tmp/f1-2704116/mgmt_txn.c:3017:
< ERROR: code indent should use tabs where possible
< #3065: FILE: /tmp/f1-2704116/mgmt_txn.c:3065:
< WARNING: please, no space before tabs
< #3065: FILE: /tmp/f1-2704116/mgmt_txn.c:3065:
< ERROR: code indent should use tabs where possible
< #3066: FILE: /tmp/f1-2704116/mgmt_txn.c:3066:
< ERROR: trailing whitespace
< #3096: FILE: /tmp/f1-2704116/mgmt_txn.c:3096:
< ERROR: code indent should use tabs where possible
< #3099: FILE: /tmp/f1-2704116/mgmt_txn.c:3099:
< WARNING: please, no space before tabs
< #3099: FILE: /tmp/f1-2704116/mgmt_txn.c:3099:
< ERROR: trailing whitespace
< #3301: FILE: /tmp/f1-2704116/mgmt_txn.c:3301:
< ERROR: trailing whitespace
< #3324: FILE: /tmp/f1-2704116/mgmt_txn.c:3324:
< ERROR: trailing whitespace
< #3326: FILE: /tmp/f1-2704116/mgmt_txn.c:3326:
< WARNING: braces {} are not necessary for single statement blocks
< #3334: FILE: /tmp/f1-2704116/mgmt_txn.c:3334:
Report for mgmt_util.c | 103 issues
===============================================
WARNING: please, no space before tabs
#31: FILE: /tmp/f1-2704116/mgmt_util.c:31:
+^I// ^I   xpath, xpath_len);$

WARNING: please, no space before tabs
#168: FILE: /tmp/f1-2704116/mgmt_util.c:168:
+^I^I// ^Ixpath_regexp[re_indx], re_indx, rexp_len, re_wild, xpath[xp_indx],$

WARNING: please, no space before tabs
#169: FILE: /tmp/f1-2704116/mgmt_util.c:169:
+^I^I// ^Ixp_indx, xpath_len, xp_wild, *(xp_next-1), enter_wild_match, match, match_len);$

WARNING: Block comments should align the * on each line
#193: FILE: /tmp/f1-2704116/mgmt_util.c:193:
+		/*
+		* Copy rest of the XPath length from the bigger XPath.

ERROR: trailing whitespace
#221: FILE: /tmp/f1-2704116/mgmt_util.c:221:
+^I$

ERROR: space required before the open parenthesis '('
#226: FILE: /tmp/f1-2704116/mgmt_util.c:226:
+		switch(xpath[indx]) {

ERROR: return is not a function, parentheses are not required
#234: FILE: /tmp/f1-2704116/mgmt_util.c:234:
+			return (wc_found ? key_start : -1);

WARNING: please, no space before tabs
#272: FILE: /tmp/f1-2704116/mgmt_util.c:272:
+^I^I// ^Iindx, xpath[indx], key_val, wc_found, last_sep, key_start, key_end ? *key_end : -1);$

ERROR: "foo* bar" should be "foo *bar"
#283: FILE: /tmp/f1-2704116/mgmt_util.c:283:
+						    void *ctxt, char* xpath_key),

WARNING: please, no space before tabs
#302: FILE: /tmp/f1-2704116/mgmt_util.c:302:
+^I// ^I   __func__, level, start_indx, wc_key_start, wc_key_end, xpath);$

WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#314: FILE: /tmp/f1-2704116/mgmt_util.c:314:
+	strncpy(xpath_key, xpath, sizeof(xpath_key));

WARNING: please, no space before tabs
#318: FILE: /tmp/f1-2704116/mgmt_util.c:318:
+^I^I// ^I   __func__, level, xpath_key);$

WARNING: please, no space before tabs
#346: FILE: /tmp/f1-2704116/mgmt_util.c:346:
+^I^I// ^I   __func__, level, chld_xpath[indx], match, max_match,$

WARNING: please, no space before tabs
#347: FILE: /tmp/f1-2704116/mgmt_util.c:347:
+^I^I// ^I   xp_match_len, xp_matched[num_dn_match]);$

WARNING: please, no space before tabs
#375: FILE: /tmp/f1-2704116/mgmt_util.c:375:
+^I^I// ^I   xp_matched[num_dn_match]);$

WARNING: please, no space before tabs
#384: FILE: /tmp/f1-2704116/mgmt_util.c:384:
+^I^I^I// ^I   __func__, level, xp_matched[indx],$

WARNING: please, no space before tabs
#385: FILE: /tmp/f1-2704116/mgmt_util.c:385:
+^I^I^I// ^I   &xpath[start_indx+wc_key_end+1]);$

WARNING: strncat() is error-prone; please use strlcat() if possible#386: FILE: /tmp/f1-2704116/mgmt_util.c:386:
+			strncat(xp_matched[indx], &xpath[start_indx+wc_key_end], MGMTD_MAX_XPATH_LEN - xp_match_len);

WARNING: please, no space before tabs
#388: FILE: /tmp/f1-2704116/mgmt_util.c:388:
+^I^I^I// ^I   __func__, level, xp_matched[indx]);$

WARNING: please, no space before tabs
#393: FILE: /tmp/f1-2704116/mgmt_util.c:393:
+^I^I^I// ^I   dnode_matched[indx]);$

ERROR: code indent should use tabs where possible
#397: FILE: /tmp/f1-2704116/mgmt_util.c:397:
+ ^I^I^I^Iret = (*iter_fn)(dnode_matched[indx],$

WARNING: please, no space before tabs
#397: FILE: /tmp/f1-2704116/mgmt_util.c:397:
+ ^I^I^I^Iret = (*iter_fn)(dnode_matched[indx],$

WARNING: please, no spaces at the start of a line
#397: FILE: /tmp/f1-2704116/mgmt_util.c:397:
+ ^I^I^I^Iret = (*iter_fn)(dnode_matched[indx],$

ERROR: code indent should use tabs where possible
#398: FILE: /tmp/f1-2704116/mgmt_util.c:398:
+ ^I^I^I^I^I^I dnode_ctxt[indx], ctxt);$

WARNING: please, no space before tabs
#398: FILE: /tmp/f1-2704116/mgmt_util.c:398:
+ ^I^I^I^I^I^I dnode_ctxt[indx], ctxt);$

WARNING: please, no spaces at the start of a line
#398: FILE: /tmp/f1-2704116/mgmt_util.c:398:
+ ^I^I^I^I^I^I dnode_ctxt[indx], ctxt);$
Report for mgmt_util.h | 20 issues
===============================================
ERROR: space required before the open parenthesis '('
#18: FILE: /tmp/f1-2704116/mgmt_util.h:18:
+		switch(base_xpath[start_index]) {

WARNING: please, no space before tabs
#41: FILE: /tmp/f1-2704116/mgmt_util.h:41:
+^I^I// ^Istart_index, base_xpath[start_index], key_val, last_sep);$

ERROR: space required before the open parenthesis '('
#54: FILE: /tmp/f1-2704116/mgmt_util.h:54:
+		switch(base_xpath[start_index]) {

WARNING: please, no space before tabs
#79: FILE: /tmp/f1-2704116/mgmt_util.h:79:
+^I^I// ^Istart_index, base_xpath[start_index], key_val, last_sep);$

ERROR: "foo* bar" should be "foo *bar"
#169: FILE: /tmp/f1-2704116/mgmt_util.h:169:
+							   void *ctxt, char* xpath_key),
Report for northbound.c | 2 issues
===============================================
< ERROR: trailing whitespace
< #2292: FILE: /tmp/f1-2704116/northbound.c:2292:

@manojvn manojvn changed the title mgmtd: Mgmt operdata merge mgmtd: Support for operational data retrieval via MGMT frontend interface. Sep 18, 2023
@mjstapp
Copy link
Contributor

mjstapp commented Sep 18, 2023

I'm a bit uncertain what this PR represents.
If this were a proposal for how to approach operational data, I'd expect to see a detailed description of the approach, the proposal - but there's a one-sentence 'description.'
If this was really meant to be a full, complete implementation, I'd expect the code to be in better shape - but it's littered with commented-out blocks, commented-out debugs, there are no comments for the proposed APIs, etc.
So ... what is this?

@pushpasis
Copy link
Contributor

pushpasis commented Sep 19, 2023 •
edited
Loading

I'm a bit uncertain what this PR represents.
If this were a proposal for how to approach operational data, I'd expect to see a detailed description of the approach, the proposal - but there's a one-sentence 'description.'
If this was really meant to be a full, complete implementation, I'd expect the code to be in better shape - but it's littered with commented-out blocks, commented-out debugs, there are no comments for the proposed APIs, etc.
So ... what is this?

Hi @mjstapp this is a full fledge implementation for retrieving operational state/data from one (or more) backend component (provided the component already supports providing operational state through northbound layer). We are sorry that the description may not be clear. But this was based on the architectural/design discussions on MGMTd we had way back in 2021 (request you to refer to the slides on MGMTd architecture and design on the 'yang' slack channel). Previously when we implemented the Config workflow some of the ground work (especially on the front-end interface, as well as some on the main MGMTd daemonn) was done already. This PR completes the work needed on the MGMTd daemon and the MGMT backend client library needed for MGMTd to get operational data from or one or more backend clients corresponding to the single GET-DATA request received on front-end interface. We have added Zebra as a new MGMT backend client as Zebra was already supporting providing operational state via Northbound layer. Adding zebra helped us portray the functionalities implemented in this PR as well.

We have also introduced support for wildcard characters in the Yang GET-DATA query URL. Some of the code is written to specifically take care of matching and resolving YANG URLs containing wildcard characters to absolute YANG data URLS and return them all as part of the response. Part of the resolution happens on the MGMTd based on the individual component Yang Path mapping/ subscription registry. This is done to figure out all the backend clients involved in the specific GET-DATA request from front-end client (along with the exact data subtrees they need reply to). Rest of the resolution actual data items happens on the backend client.

[UPDATE] We have added all these details in the PR description. We also removed all the commented debugs, and we are also done with resolving all the CI failures as well as valgrind memleaks.

Thanks and regards
-Pushpasis

@ton31337
Copy link
Member

ton31337 commented Sep 19, 2023 •
edited
Loading

Agree with @mjstapp. Overall mgmtd documentation seems a bit unfinished. Documentation is, but me as an operator would like to understand how to use it with CLI examples like you did in the comment, etc.

DISCLAIMER: my comment might not be super relevant to this PR, but just sayin'.

@pushpasis
Copy link
Contributor

Agree with @mjstapp. Overall mgmtd documentation seems a bit unfinished. Documentation is, but me as an operator would like to understand how to use it with CLI examples like you did in the comment, etc.

DISCLAIMER: my comment might not be super relevant to this PR, but just sayin'.

Thank you @ton31337. We will see if we can add some more details in the developer documentation. Essentially all the architecture and design details are already captured in the slide deck pinned on the 'yang' slack channel. Maybe we need some of those details to the developer documentation.

Thanks
-Pushpasis

@manojvn manojvn force-pushed the mgmt_operdata_merge branch from fd00311 to e1e62c2 Compare September 22, 2023 14:32
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 22, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14298/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Failed

Checkout code: Failed (click for details)

PullReq merge failed. Please rebase your branch:
see merge log in attachment https://ci1.netdef.org/browse/FRR-PULLREQ2-14298/artifact/CHECKOUT/ErrorLog/log_merge.txt

@manojvn manojvn force-pushed the mgmt_operdata_merge branch from e1e62c2 to 2efe182 Compare September 22, 2023 14:51
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 22, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14299/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14299/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14299/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
mgmtd/mgmt_txn.c: In function mgmt_txn_process_get_data:
./lib/zlog.h:109:20: error: format %Lx expects argument of type uint64_t, but argument 6 has type long long unsigned int [-Werror=format=]
./lib/zlog.h:112:26: note: in expansion of macro _zlog_ecref
mgmtd/mgmt_txn.c:20:2: note: in expansion of macro zlog_err
mgmtd/mgmt_txn.c:2533:5: note: in expansion of macro MGMTD_TXN_ERR
 2533 |     MGMTD_TXN_ERR(
./lib/zlog.h:109:20: error: format %Lu expects argument of type uint64_t, but argument 7 has type long long unsigned int [-Werror=format=]
./lib/zlog.h:112:26: note: in expansion of macro _zlog_ecref

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14299/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • Debian 9 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 22.04 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 arm8 build
  • Ubuntu 18.04 arm7 build
  • Debian 10 amd64 build
  • Redhat 9 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 18.04 i386 build
  • OpenBSD 7 amd64 build
  • CentOS 7 amd64 build
  • Redhat 8 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14299/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14299/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
mgmtd/mgmt_txn.c: In function mgmt_txn_process_get_data:
./lib/zlog.h:109:20: error: format %Lx expects argument of type uint64_t, but argument 6 has type long long unsigned int [-Werror=format=]
./lib/zlog.h:112:26: note: in expansion of macro _zlog_ecref
mgmtd/mgmt_txn.c:20:2: note: in expansion of macro zlog_err
mgmtd/mgmt_txn.c:2533:5: note: in expansion of macro MGMTD_TXN_ERR
 2533 |     MGMTD_TXN_ERR(
./lib/zlog.h:109:20: error: format %Lu expects argument of type uint64_t, but argument 7 has type long long unsigned int [-Werror=format=]
./lib/zlog.h:112:26: note: in expansion of macro _zlog_ecref

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14299/artifact/DEB11AMD64/config.status/config.status

<stdin>:73: trailing whitespace.
of validating any data under these data portions, by specifying only 
<stdin>:102: trailing whitespace.
'MGMT_SUBSCR_VALIDATE_CFG' and 'MGMT_SUBSCR_OPER_OWN' values for the 
<stdin>:1289: trailing whitespace.
 * Returns: The position of the previous separator if foumd, else -1. 
<stdin>:1335: trailing whitespace.
 * Returns: The position of the previous separator if foumd, else -1. 
warning: 4 lines add whitespace errors.
Report for mgmt_be_adapter.c | 4 issues
===============================================
< WARNING: space prohibited between function name and open parenthesis '('
< #940: FILE: /tmp/f1-1473321/mgmt_be_adapter.c:940:
< WARNING: unnecessary whitespace before a quoted newline
< #985: FILE: /tmp/f1-1473321/mgmt_be_adapter.c:985:
Report for mgmt_be_client.c | 4 issues
===============================================
< WARNING: suspect code indent for conditional statements (8, 24)
< #1053: FILE: /tmp/f1-1473321/mgmt_be_client.c:1053:
< WARNING: braces {} are not necessary for single statement blocks
< #1064: FILE: /tmp/f1-1473321/mgmt_be_client.c:1064:
Report for mgmt_txn.c | 6 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2392: FILE: /tmp/f1-1473321/mgmt_txn.c:2392:
< WARNING: Block comments should align the * on each line
< #2420: FILE: /tmp/f1-1473321/mgmt_txn.c:2420:
< WARNING: Missing a blank line after declarations
< #2426: FILE: /tmp/f1-1473321/mgmt_txn.c:2426:
Report for mgmt_util.c | 21 issues
===============================================
WARNING: Block comments should align the * on each line
#199: FILE: /tmp/f1-1473321/mgmt_util.c:199:
+		/*
+		* Copy rest of the XPath length from the bigger XPath.

ERROR: space required before the open parenthesis '('
#235: FILE: /tmp/f1-1473321/mgmt_util.c:235:
+		switch(xpath[indx]) {

ERROR: return is not a function, parentheses are not required
#243: FILE: /tmp/f1-1473321/mgmt_util.c:243:
+			return (wc_found ? key_start : -1);

WARNING: Missing a blank line after declarations
#395: FILE: /tmp/f1-1473321/mgmt_util.c:395:
+			int len = strlen(xp_matched[indx]);
+			MGMTD_UTIL_DBG(" [%d] --- Merge XPATH: [%s] + [%s]",

WARNING: strncat() is error-prone; please use strlcat() if possible#398: FILE: /tmp/f1-1473321/mgmt_util.c:398:
+			strncat(xp_matched[indx], &xpath[start_indx+wc_key_end], MGMTD_MAX_XPATH_LEN - xp_match_len);
Report for mgmt_util.h | 29 issues
===============================================
ERROR: trailing whitespace
#32: FILE: /tmp/f1-1473321/mgmt_util.h:32:
+ * Returns: The position of the previous separator if foumd, else -1. $

ERROR: space required before the open parenthesis '('
#40: FILE: /tmp/f1-1473321/mgmt_util.h:40:
+		switch(base_xpath[start_index]) {

ERROR: trailing whitespace
#78: FILE: /tmp/f1-1473321/mgmt_util.h:78:
+ * Returns: The position of the previous separator if foumd, else -1. $

ERROR: space required before the open parenthesis '('
#86: FILE: /tmp/f1-1473321/mgmt_util.h:86:
+		switch(base_xpath[start_index]) {

WARNING: please, no space before tabs
#213: FILE: /tmp/f1-1473321/mgmt_util.h:213:
+ * ^IThe number of tokens that matched between the regex and the$

WARNING: please, no space before tabs
#214: FILE: /tmp/f1-1473321/mgmt_util.h:214:
+ * ^Iactual xpath.$

WARNING: Possible repeated word: 'vty'
#270: FILE: /tmp/f1-1473321/mgmt_util.h:270:
+ * vty
+ *     vty context.

@manojvn manojvn force-pushed the mgmt_operdata_merge branch from 2efe182 to c7ce367 Compare September 23, 2023 04:01
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 23, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14311/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14311/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14311/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from lib/log.h:17,
lib/mgmt_be_client.c: In function mgmt_be_send_get_data_reply:
./lib/zlog.h:109:20: error: format %lld expects argument of type long long int, but argument 9 has type int64_t {aka long int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
lib/debug.h:210:4: note: in expansion of macro zlog_debug
lib/debug.h:218:32: note: in expansion of macro DEBUG
./lib/mgmt_be_client.h:142:2: note: in expansion of macro DEBUGD
lib/mgmt_be_client.c:872:2: note: in expansion of macro MGMTD_BE_CLIENT_DBG
lib/mgmt_be_client.c: At top level:

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14311/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests
  • OpenBSD 7 amd64 build
  • Redhat 8 amd64 build
  • Debian 10 amd64 build
  • CentOS 7 amd64 build
  • Ubuntu 22.04 amd64 build
  • FreeBSD 11 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Redhat 9 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 18.04 arm8 build
  • Ubuntu 18.04 arm7 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14311/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14311/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from lib/log.h:17,
lib/mgmt_be_client.c: In function mgmt_be_send_get_data_reply:
./lib/zlog.h:109:20: error: format %lld expects argument of type long long int, but argument 9 has type int64_t {aka long int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
lib/debug.h:210:4: note: in expansion of macro zlog_debug
lib/debug.h:218:32: note: in expansion of macro DEBUG
./lib/mgmt_be_client.h:142:2: note: in expansion of macro DEBUGD
lib/mgmt_be_client.c:872:2: note: in expansion of macro MGMTD_BE_CLIENT_DBG
lib/mgmt_be_client.c: At top level:

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14311/artifact/DEB11AMD64/config.status/config.status

<stdin>:73: trailing whitespace.
of validating any data under these data portions, by specifying only 
<stdin>:102: trailing whitespace.
'MGMT_SUBSCR_VALIDATE_CFG' and 'MGMT_SUBSCR_OPER_OWN' values for the 
warning: 2 lines add whitespace errors.
Report for mgmt_be_adapter.c | 4 issues
===============================================
< WARNING: space prohibited between function name and open parenthesis '('
< #940: FILE: /tmp/f1-940161/mgmt_be_adapter.c:940:
< WARNING: unnecessary whitespace before a quoted newline
< #985: FILE: /tmp/f1-940161/mgmt_be_adapter.c:985:
Report for mgmt_util.h | 5 issues
===============================================
WARNING: Possible repeated word: 'vty'
#270: FILE: /tmp/f1-940161/mgmt_util.h:270:
+ * vty
+ *    vty context.

@manojvn manojvn force-pushed the mgmt_operdata_merge branch 2 times, most recently from 3fc47ef to 0cf562b Compare September 23, 2023 05:23
@idryzhov
Copy link
Contributor

Is it possible to output JSON instead of what is displayed at the moment? It is not really readable. Or at least add an optional [json] argument to convert the output into JSON.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 26, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-14341/test

Topology Tests failed for Topotests debian 10 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO6U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO6U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8U18I386/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9U18I386/TopotestDetails/

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1DEB10AMD64-14341/test

Topology Tests failed for Topotests debian 10 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO1DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO1DEB10AMD64/TopotestDetails/

Topotests debian 10 amd64 part 2: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2DEB10AMD64-14341/test

Topology Tests failed for Topotests debian 10 amd64 part 2
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO2DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 2: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO2DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO0U18ARM8/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO0U18ARM8/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO6U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO6U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8U18ARM64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8U18ARM64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO1U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPOU1804/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPOU1804/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7U18AMD64/TopotestDetails/

Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-14341/test

Topology Tests failed for Topotests debian 10 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO0DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO0DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 7: No useful log found
Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7U18I386/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-14341/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TP1U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TP1U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO0U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO0U18I386/TopotestLogs/log_topotests.txt

Topotests debian 10 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-14341/test

Topology Tests failed for Topotests debian 10 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 2: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TP2U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP2U1804AMD64-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 2
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TP2U1804AMD64/TopotestLogs/log_topotests.txt

Successful on other platforms/tests
  • Topotests debian 10 amd64 part 3
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 arm8 part 4
  • Ubuntu 20.04 deb pkg check
  • Ubuntu 18.04 deb pkg check
  • Debian 10 deb pkg check
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Addresssanitizer topotests part 4
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 4
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 3
  • Static analyzer (clang)
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 6
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 arm8 part 2
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 5
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 3
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 5

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests debian 10 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-14341/test

Topology Tests failed for Topotests debian 10 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO6U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO6U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8U18I386/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9U18I386/TopotestDetails/

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1DEB10AMD64-14341/test

Topology Tests failed for Topotests debian 10 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO1DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO1DEB10AMD64/TopotestDetails/

Topotests debian 10 amd64 part 2: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2DEB10AMD64-14341/test

Topology Tests failed for Topotests debian 10 amd64 part 2
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO2DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 2: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO2DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO0U18ARM8/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO0U18ARM8/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO6U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO6U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8U18ARM64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8U18ARM64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO1U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPOU1804/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPOU1804/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7U18AMD64/TopotestDetails/

Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-14341/test

Topology Tests failed for Topotests debian 10 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO0DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO0DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 7: No useful log found
Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7U18I386/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-14341/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TP1U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TP1U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO0U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO0U18I386/TopotestLogs/log_topotests.txt

Topotests debian 10 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-14341/test

Topology Tests failed for Topotests debian 10 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TOPO7DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 2: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TP2U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP2U1804AMD64-14341/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 2
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/TP2U1804AMD64/TopotestLogs/log_topotests.txt

<stdin>:73: trailing whitespace.
of validating any data under these data portions, by specifying only 
<stdin>:102: trailing whitespace.
'MGMT_SUBSCR_VALIDATE_CFG' and 'MGMT_SUBSCR_OPER_OWN' values for the 
warning: 2 lines add whitespace errors.
Report for mgmt_be_adapter.c | 4 issues
===============================================
< WARNING: space prohibited between function name and open parenthesis '('
< #941: FILE: /tmp/f1-3685800/mgmt_be_adapter.c:941:
< WARNING: unnecessary whitespace before a quoted newline
< #986: FILE: /tmp/f1-3685800/mgmt_be_adapter.c:986:
Report for mgmt_util.c | 4 issues
===============================================
ERROR: do not initialise statics to false
#491: FILE: /tmp/f1-3685800/mgmt_util.c:491:
+	static bool mgmt_util_vty_initialized = false;
Report for mgmt_util.h | 5 issues
===============================================
WARNING: Possible repeated word: 'vty'
#270: FILE: /tmp/f1-3685800/mgmt_util.h:270:
+ * vty
+ *    vty context.

CLANG Static Analyzer Summary

  • Github Pull Request 14428, comparing to Git base SHA dbd08a3
  • Base image data for Git dbd08a3 does not exist - compare skipped

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-PULLREQ2-14341/artifact/shared/static_analysis/index.html

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 27, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14364/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Failed

Checkout code: Failed (click for details)

PullReq merge failed. Please rebase your branch:
see merge log in attachment https://ci1.netdef.org/browse/FRR-PULLREQ2-14364/artifact/CHECKOUT/ErrorLog/log_merge.txt

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 27, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-14365/test

Topology Tests failed for Topotests debian 10 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO0U18ARM8/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO0U18ARM8/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO8U18ARM64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO8U18ARM64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO0U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO0U18I386/TopotestLogs/log_topotests.txt

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1DEB10AMD64-14365/test

Topology Tests failed for Topotests debian 10 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO1DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO1DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TP1U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TP1U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO1U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-14365/test

Topology Tests failed for Topotests debian 10 amd64 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO6DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO6DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Addresssanitizer topotests part 1: Failed (click for details) 
***********************************************************************************
Address Sanitizer Error detected in all_protocol_startup.test_all_protocol_startup/r1.asan.mgmtd.21201

=================================================================
==21201==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 296 byte(s) in 1 object(s) allocated from:
    #0 0x7fad134c6d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
    #1 0x7fad12eb1e9b in qcalloc lib/memory.c:105
    #2 0x55a8bc4e9742 in mgmt_txn_req_alloc mgmtd/mgmt_txn.c:616
    #3 0x55a8bc4f9c74 in mgmt_txn_notify_be_adapter_conn mgmtd/mgmt_txn.c:3021
    #4 0x55a8bc4d6840 in mgmt_be_adapter_conn_init mgmtd/mgmt_be_adapter.c:581
    #5 0x7fad12f57aaf in event_call lib/event.c:1969
    #6 0x7fad12e9513a in frr_run lib/libfrr.c:1213
    #7 0x55a8bc4d3185 in main mgmtd/mgmt_main.c:285
    #8 0x7fad1213fc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)

SUMMARY: AddressSanitizer: 296 byte(s) leaked in 1 allocation(s).
***********************************************************************************

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN1-14365/test

Topology Tests failed for Addresssanitizer topotests part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/ASAN1/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/ASAN1/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 7: No useful log found
Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7U18I386/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 2: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2U18I386-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 2
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO2U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 2: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO2U18I386/TopotestDetails/

Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-14365/test

Topology Tests failed for Topotests debian 10 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO0DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO0DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO1U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO1U18I386/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO8U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO8U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPOU1804/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPOU1804/TopotestDetails/

Topotests debian 10 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-14365/test

Topology Tests failed for Topotests debian 10 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO8DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO8DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-14365/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9DEB10AMD64/TopotestDetails/

Successful on other platforms/tests
  • Topotests debian 10 amd64 part 2
  • Addresssanitizer topotests part 8
  • Static analyzer (clang)
  • Ubuntu 20.04 deb pkg check
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 6
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 6
  • Addresssanitizer topotests part 0
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 arm8 part 3
  • Debian 9 deb pkg check
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests debian 10 amd64 part 4
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 2
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 6
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 arm8 part 4
  • Addresssanitizer topotests part 2
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests debian 10 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-14365/test

Topology Tests failed for Topotests debian 10 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO0U18ARM8/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO0U18ARM8/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO8U18ARM64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO8U18ARM64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO0U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO0U18I386/TopotestLogs/log_topotests.txt

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1DEB10AMD64-14365/test

Topology Tests failed for Topotests debian 10 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO1DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO1DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TP1U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP1U1804AMD64-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TP1U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO1U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-14365/test

Topology Tests failed for Topotests debian 10 amd64 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO6DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO6DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Addresssanitizer topotests part 1: Failed (click for details) 
***********************************************************************************
Address Sanitizer Error detected in all_protocol_startup.test_all_protocol_startup/r1.asan.mgmtd.21201

=================================================================
==21201==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 296 byte(s) in 1 object(s) allocated from:
    #0 0x7fad134c6d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
    #1 0x7fad12eb1e9b in qcalloc lib/memory.c:105
    #2 0x55a8bc4e9742 in mgmt_txn_req_alloc mgmtd/mgmt_txn.c:616
    #3 0x55a8bc4f9c74 in mgmt_txn_notify_be_adapter_conn mgmtd/mgmt_txn.c:3021
    #4 0x55a8bc4d6840 in mgmt_be_adapter_conn_init mgmtd/mgmt_be_adapter.c:581
    #5 0x7fad12f57aaf in event_call lib/event.c:1969
    #6 0x7fad12e9513a in frr_run lib/libfrr.c:1213
    #7 0x55a8bc4d3185 in main mgmtd/mgmt_main.c:285
    #8 0x7fad1213fc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)

SUMMARY: AddressSanitizer: 296 byte(s) leaked in 1 allocation(s).
***********************************************************************************

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN1-14365/test

Topology Tests failed for Addresssanitizer topotests part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/ASAN1/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/ASAN1/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 7: No useful log found
Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7U18I386/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 2: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO2U18I386-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 2
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO2U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 2: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO2U18I386/TopotestDetails/

Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-14365/test

Topology Tests failed for Topotests debian 10 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO0DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO0DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO1U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO1U18I386/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18I386-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO8U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO8U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPOU1804/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPOU1804/TopotestDetails/

Topotests debian 10 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-14365/test

Topology Tests failed for Topotests debian 10 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO8DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO8DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-14365/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO7U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-14365/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/TOPO9DEB10AMD64/TopotestDetails/

Report for mgmt_be_adapter.c | 4 issues
===============================================
< WARNING: space prohibited between function name and open parenthesis '('
< #940: FILE: /tmp/f1-5761/mgmt_be_adapter.c:940:
< WARNING: unnecessary whitespace before a quoted newline
< #985: FILE: /tmp/f1-5761/mgmt_be_adapter.c:985:
Report for mgmt_util.c | 4 issues
===============================================
ERROR: do not initialise statics to false
#491: FILE: /tmp/f1-5761/mgmt_util.c:491:
+	static bool mgmt_util_vty_initialized = false;
Report for mgmt_util.h | 5 issues
===============================================
WARNING: Possible repeated word: 'vty'
#270: FILE: /tmp/f1-5761/mgmt_util.h:270:
+ * vty
+ *    vty context.

CLANG Static Analyzer Summary

  • Github Pull Request 14428, comparing to Git base SHA bb308b1
  • Base image data for Git bb308b1 does not exist - compare skipped

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-PULLREQ2-14365/artifact/shared/static_analysis/index.html

@frrbot frrbot bot added the mgmt FRR Management Infra label Sep 28, 2023
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 28, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO0U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-14386/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO0U18I386/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-14386/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPOU1804/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPOU1804/TopotestDetails/

Addresssanitizer topotests part 1: Failed (click for details) 
***********************************************************************************
Address Sanitizer Error detected in bgp_auth.test_bgp_auth4/R1.asan.ospfd.15523

=================================================================
==15523==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 256 byte(s) in 2 object(s) allocated from:
    #0 0x7fcf01c0bd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
    #1 0x7fcf015f6e9b in qcalloc lib/memory.c:105
    #2 0x5591cc19cea9 in ospf_lsa_new ospfd/ospf_lsa.c:186
    #3 0x5591cc19d1b3 in ospf_lsa_new_and_data ospfd/ospf_lsa.c:205
    #4 0x5591cc1d1c0c in ospf_ls_upd_list_lsa ospfd/ospf_packet.c:1631
    #5 0x5591cc1d1c0c in ospf_ls_upd ospfd/ospf_packet.c:1716
    #6 0x5591cc1d1c0c in ospf_read_helper ospfd/ospf_packet.c:2896
    #7 0x5591cc1d1c0c in ospf_read ospfd/ospf_packet.c:2927
    #8 0x7fcf0169caaf in event_call lib/event.c:1969
    #9 0x7fcf015da13a in frr_run lib/libfrr.c:1213
    #10 0x5591cc17ac49 in main ospfd/ospf_main.c:251
    #11 0x7fcf00bebc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)

Indirect leak of 92 byte(s) in 2 object(s) allocated from:
    #0 0x7fcf01c0bd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
    #1 0x7fcf015f6e9b in qcalloc lib/memory.c:105
    #2 0x5591cc19d1a2 in ospf_lsa_data_new ospfd/ospf_lsa.c:296
    #3 0x5591cc19d1be in ospf_lsa_new_and_data ospfd/ospf_lsa.c:206
    #4 0x5591cc1d1c0c in ospf_ls_upd_list_lsa ospfd/ospf_packet.c:1631
    #5 0x5591cc1d1c0c in ospf_ls_upd ospfd/ospf_packet.c:1716
    #6 0x5591cc1d1c0c in ospf_read_helper ospfd/ospf_packet.c:2896
    #7 0x5591cc1d1c0c in ospf_read ospfd/ospf_packet.c:2927
    #8 0x7fcf0169caaf in event_call lib/event.c:1969
    #9 0x7fcf015da13a in frr_run lib/libfrr.c:1213
    #10 0x5591cc17ac49 in main ospfd/ospf_main.c:251
    #11 0x7fcf00bebc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)

SUMMARY: AddressSanitizer: 348 byte(s) leaked in 4 allocation(s).
***********************************************************************************

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN1-14386/test

Topology Tests failed for Addresssanitizer topotests part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/ASAN1/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/ASAN1/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found
Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-14386/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO7U18I386/TopotestDetails/

Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-14386/test

Topology Tests failed for Topotests debian 10 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO0DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO0DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO0U18ARM8/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-14386/test

Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO0U18ARM8/TopotestLogs/log_topotests.txt

Successful on other platforms/tests
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests debian 10 amd64 part 1
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 arm8 part 5
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 9
  • Addresssanitizer topotests part 2
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Ubuntu 18.04 deb pkg check
  • Topotests debian 10 amd64 part 7
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 6
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests debian 10 amd64 part 3
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 i386 part 6
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 7
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 7
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO0U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-14386/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO0U18I386/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-14386/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPOU1804/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPOU1804/TopotestDetails/

Addresssanitizer topotests part 1: Failed (click for details) 
***********************************************************************************
Address Sanitizer Error detected in bgp_auth.test_bgp_auth4/R1.asan.ospfd.15523

=================================================================
==15523==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 256 byte(s) in 2 object(s) allocated from:
    #0 0x7fcf01c0bd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
    #1 0x7fcf015f6e9b in qcalloc lib/memory.c:105
    #2 0x5591cc19cea9 in ospf_lsa_new ospfd/ospf_lsa.c:186
    #3 0x5591cc19d1b3 in ospf_lsa_new_and_data ospfd/ospf_lsa.c:205
    #4 0x5591cc1d1c0c in ospf_ls_upd_list_lsa ospfd/ospf_packet.c:1631
    #5 0x5591cc1d1c0c in ospf_ls_upd ospfd/ospf_packet.c:1716
    #6 0x5591cc1d1c0c in ospf_read_helper ospfd/ospf_packet.c:2896
    #7 0x5591cc1d1c0c in ospf_read ospfd/ospf_packet.c:2927
    #8 0x7fcf0169caaf in event_call lib/event.c:1969
    #9 0x7fcf015da13a in frr_run lib/libfrr.c:1213
    #10 0x5591cc17ac49 in main ospfd/ospf_main.c:251
    #11 0x7fcf00bebc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)

Indirect leak of 92 byte(s) in 2 object(s) allocated from:
    #0 0x7fcf01c0bd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
    #1 0x7fcf015f6e9b in qcalloc lib/memory.c:105
    #2 0x5591cc19d1a2 in ospf_lsa_data_new ospfd/ospf_lsa.c:296
    #3 0x5591cc19d1be in ospf_lsa_new_and_data ospfd/ospf_lsa.c:206
    #4 0x5591cc1d1c0c in ospf_ls_upd_list_lsa ospfd/ospf_packet.c:1631
    #5 0x5591cc1d1c0c in ospf_ls_upd ospfd/ospf_packet.c:1716
    #6 0x5591cc1d1c0c in ospf_read_helper ospfd/ospf_packet.c:2896
    #7 0x5591cc1d1c0c in ospf_read ospfd/ospf_packet.c:2927
    #8 0x7fcf0169caaf in event_call lib/event.c:1969
    #9 0x7fcf015da13a in frr_run lib/libfrr.c:1213
    #10 0x5591cc17ac49 in main ospfd/ospf_main.c:251
    #11 0x7fcf00bebc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)

SUMMARY: AddressSanitizer: 348 byte(s) leaked in 4 allocation(s).
***********************************************************************************

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN1-14386/test

Topology Tests failed for Addresssanitizer topotests part 1
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/ASAN1/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 1: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/ASAN1/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found
Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-14386/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO7U18I386/TopotestDetails/

Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-14386/test

Topology Tests failed for Topotests debian 10 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO0DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO0DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO0U18ARM8/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-14386/test

Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/TOPO0U18ARM8/TopotestLogs/log_topotests.txt

Report for mgmt_be_adapter.c | 8 issues
===============================================
< ERROR: "foo* bar" should be "foo *bar"
< #602: FILE: /tmp/f1-1703872/mgmt_be_adapter.c:602:
< ERROR: "foo* bar" should be "foo *bar"
< #610: FILE: /tmp/f1-1703872/mgmt_be_adapter.c:610:
< WARNING: space prohibited between function name and open parenthesis '('
< #951: FILE: /tmp/f1-1703872/mgmt_be_adapter.c:951:
< WARNING: unnecessary whitespace before a quoted newline
< #996: FILE: /tmp/f1-1703872/mgmt_be_adapter.c:996:
Report for mgmt_txn.c | 10 issues
===============================================
< WARNING: suspect code indent for conditional statements (24, 31)
< #1302: FILE: /tmp/f1-1703872/mgmt_txn.c:1302:
< ERROR: code indent should use tabs where possible
< #1307: FILE: /tmp/f1-1703872/mgmt_txn.c:1307:
< WARNING: please, no spaces at the start of a line
< #1307: FILE: /tmp/f1-1703872/mgmt_txn.c:1307:
< ERROR: code indent should use tabs where possible
< #1308: FILE: /tmp/f1-1703872/mgmt_txn.c:1308:
< WARNING: please, no spaces at the start of a line
< #1308: FILE: /tmp/f1-1703872/mgmt_txn.c:1308:
Report for mgmt_util.c | 4 issues
===============================================
ERROR: do not initialise statics to false
#491: FILE: /tmp/f1-1703872/mgmt_util.c:491:
+	static bool mgmt_util_vty_initialized = false;
Report for mgmt_util.h | 5 issues
===============================================
WARNING: Possible repeated word: 'vty'
#270: FILE: /tmp/f1-1703872/mgmt_util.h:270:
+ * vty
+ *    vty context.

CLANG Static Analyzer Summary

  • Github Pull Request 14428, comparing to Git base SHA 8640fc9
  • Base image data for Git 8640fc9 does not exist - compare skipped

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-PULLREQ2-14386/artifact/shared/static_analysis/index.html

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 29, 2023 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14414/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14414/artifact/TOPO0U18ARM8/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-14414/test

Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14414/artifact/TOPO0U18ARM8/TopotestLogs/log_topotests.txt

Successful on other platforms/tests
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 i386 part 6
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 8
  • Addresssanitizer topotests part 7
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 0
  • Addresssanitizer topotests part 6
  • Topotests debian 10 amd64 part 9
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 arm8 part 4
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 9
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 1
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 8
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 6
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 arm8 part 3
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 1
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 8
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 3
  • Static analyzer (clang)

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14414/artifact/TOPO0U18ARM8/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-14414/test

Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14414/artifact/TOPO0U18ARM8/TopotestLogs/log_topotests.txt

Report for mgmt_be_adapter.c | 8 issues
===============================================
< ERROR: "foo* bar" should be "foo *bar"
< #608: FILE: /tmp/f1-326189/mgmt_be_adapter.c:608:
< ERROR: "foo* bar" should be "foo *bar"
< #616: FILE: /tmp/f1-326189/mgmt_be_adapter.c:616:
< WARNING: space prohibited between function name and open parenthesis '('
< #957: FILE: /tmp/f1-326189/mgmt_be_adapter.c:957:
< WARNING: unnecessary whitespace before a quoted newline
< #1002: FILE: /tmp/f1-326189/mgmt_be_adapter.c:1002:
Report for mgmt_txn.c | 10 issues
===============================================
< WARNING: suspect code indent for conditional statements (24, 31)
< #1302: FILE: /tmp/f1-326189/mgmt_txn.c:1302:
< ERROR: code indent should use tabs where possible
< #1307: FILE: /tmp/f1-326189/mgmt_txn.c:1307:
< WARNING: please, no spaces at the start of a line
< #1307: FILE: /tmp/f1-326189/mgmt_txn.c:1307:
< ERROR: code indent should use tabs where possible
< #1308: FILE: /tmp/f1-326189/mgmt_txn.c:1308:
< WARNING: please, no spaces at the start of a line
< #1308: FILE: /tmp/f1-326189/mgmt_txn.c:1308:
Report for mgmt_util.c | 4 issues
===============================================
ERROR: do not initialise statics to false
#491: FILE: /tmp/f1-326189/mgmt_util.c:491:
+	static bool mgmt_util_vty_initialized = false;
Report for mgmt_util.h | 5 issues
===============================================
WARNING: Possible repeated word: 'vty'
#270: FILE: /tmp/f1-326189/mgmt_util.h:270:
+ * vty
+ *    vty context.
Report for vty.c | 4 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #3648: FILE: /tmp/f1-326189/vty.c:3648:
< WARNING: braces {} are not necessary for single statement blocks
< #3656: FILE: /tmp/f1-326189/vty.c:3656:

CLANG Static Analyzer Summary

  • Github Pull Request 14428, comparing to Git base SHA 3651803
  • Base image data for Git 3651803 does not exist - compare skipped

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-PULLREQ2-14414/artifact/shared/static_analysis/index.html

@pushpasis
Copy link
Contributor

ci:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14416/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for mgmt_be_adapter.c | 8 issues
===============================================
< ERROR: "foo* bar" should be "foo *bar"
< #608: FILE: /tmp/f1-2042931/mgmt_be_adapter.c:608:
< ERROR: "foo* bar" should be "foo *bar"
< #616: FILE: /tmp/f1-2042931/mgmt_be_adapter.c:616:
< WARNING: space prohibited between function name and open parenthesis '('
< #957: FILE: /tmp/f1-2042931/mgmt_be_adapter.c:957:
< WARNING: unnecessary whitespace before a quoted newline
< #1002: FILE: /tmp/f1-2042931/mgmt_be_adapter.c:1002:
Report for mgmt_txn.c | 10 issues
===============================================
< WARNING: suspect code indent for conditional statements (24, 31)
< #1302: FILE: /tmp/f1-2042931/mgmt_txn.c:1302:
< ERROR: code indent should use tabs where possible
< #1307: FILE: /tmp/f1-2042931/mgmt_txn.c:1307:
< WARNING: please, no spaces at the start of a line
< #1307: FILE: /tmp/f1-2042931/mgmt_txn.c:1307:
< ERROR: code indent should use tabs where possible
< #1308: FILE: /tmp/f1-2042931/mgmt_txn.c:1308:
< WARNING: please, no spaces at the start of a line
< #1308: FILE: /tmp/f1-2042931/mgmt_txn.c:1308:
Report for mgmt_util.c | 4 issues
===============================================
ERROR: do not initialise statics to false
#491: FILE: /tmp/f1-2042931/mgmt_util.c:491:
+	static bool mgmt_util_vty_initialized = false;
Report for mgmt_util.h | 5 issues
===============================================
WARNING: Possible repeated word: 'vty'
#270: FILE: /tmp/f1-2042931/mgmt_util.h:270:
+ * vty
+ *    vty context.
Report for vty.c | 4 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #3648: FILE: /tmp/f1-2042931/vty.c:3648:
< WARNING: braces {} are not necessary for single statement blocks
< #3656: FILE: /tmp/f1-2042931/vty.c:3656:

CLANG Static Analyzer Summary

  • Github Pull Request 14428, comparing to Git base SHA 3651803
  • Base image data for Git 3651803 does not exist - compare skipped

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-PULLREQ2-14416/artifact/shared/static_analysis/index.html

@rgirada rgirada force-pushed the mgmt_operdata_merge branch from 62a1f08 to 89b6493 Compare October 3, 2023 09:37
@pushpasis pushpasis force-pushed the mgmt_operdata_merge branch 4 times, most recently from b9ea919 to 016fec0 Compare October 9, 2023 07:22
@pushpasis pushpasis force-pushed the mgmt_operdata_merge branch from 016fec0 to d8432c6 Compare October 16, 2023 15:13
pushpasis and others added 5 commits October 16, 2023 22:59
@pushpasis @YashRanjanVMWare
lib,mgmtd,vtysh: Add utility for wildcard resolution of Xpath using a…
a41dcb7 
… specific Mgmt Database

This commit adds utilities for resolving a Xpath with wildcards in it using the contents
of a live specific MGMT database.

Co-authored-by: Yash Ranjan <[email protected]>
Signed-off-by: Pushpasis Sarkar <[email protected]>
@pushpasis @YashRanjanVMWare
lib,mgmtd: Add support for GETDATA_REQ on Operational DB
8b88c05 
Handle GETDATA_REQ from Front-end clients and retrieve data fron
backend clients

Co-authored-by: Yash Ranjan <[email protected]>
Signed-off-by: Pushpasis Sarkar <[email protected]>
@pushpasis @YashRanjanVMWare
lib,mgmtd,zebra: Add Zebra as a MGMT Bckend client
2bfdc76 
Add Zebra as a MGMT Backend client. This commit does not divert show
commands to MGMTd yet.

Co-authored-by: Yash Ranjan <[email protected]>
Signed-off-by: Pushpasis Sarkar <[email protected]>
@pushpasis
doc: Update MGMTd documentation
db44519 
This commit updates the existing MGMTd user and developer documentations
with details regarding the new support for retrieving operational
data via the MGMT Front-end interface.

Signed-off-by: Pushpasis Sarkar <[email protected]>
@pushpasis
tests: Add topotest for MGMT OPER-DATA command.
dcfd9c5 
This commit ads a topotest test-case to check the GET-OPER-DATA
functionality.

Signed-off-by: Pushpasis Sarkar <[email protected]>
@pushpasis pushpasis force-pushed the mgmt_operdata_merge branch from d8432c6 to dcfd9c5 Compare October 17, 2023 06:21
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@pushpasis pushpasis marked this pull request as draft November 23, 2023 05:45
@choppsv1
Copy link
Contributor

choppsv1 commented Feb 7, 2024

@pushpasis I think we can close this now, yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jafaral Jafaral Awaiting requested review from Jafaral

@choppsv1 choppsv1 Awaiting requested review from choppsv1

Assignees
No one assigned
Labels
bgp conflicts documentation libfrr master mgmt FRR Management Infra rebase PR needs rebase size/XXL tests Topotests, make check, etc vtysh zebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@manojvn @NetDEF-CI @mjstapp @pushpasis @ton31337 @idryzhov @choppsv1