bgpd: Fix some bugs of set tcp-mss on listen socket. #14449

forsunwell · 2023-09-20T03:46:21Z

1.Tcp-mss not just for bgp neighbor, but also for bgp neighbor group.
2.Set tcp-mss for listhen socket even no neighbor config passive mode.
3.Config tcp-mss on neighbor group sync to all the neighbor in that group.

1.Tcp-mss not just for bgp neighbor, but also for bgp neighbor group. 2.Set tcp-mss for listhen socket even no neighbor config passive mode. 3.Config tcp-mss on neighbor group sync to all the neighbor in that group. Signed-off-by: forsunwell <[email protected]>

NetDEF-CI · 2023-09-20T06:48:48Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14242/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-14242/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14242/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14242/artifact/TOPO9U18I386/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14242/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 4: No useful log found

Successful on other platforms/tests

CentOS 7 rpm pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 1
Static analyzer (clang)
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 3
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Debian 9 deb pkg check
Topotests Ubuntu 18.04 i386 part 2
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 8
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 9

ton31337

Please adjust an existing topotest to include peer-groups.

NetDEF-CI · 2023-09-20T07:35:07Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14243/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 4: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14243/artifact/TP4U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP4U1804AMD64-14243/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14243/artifact/TP4U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14243/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 5
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 9
Addresssanitizer topotests part 6
Static analyzer (clang)
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4
Debian 9 deb pkg check
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 1
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 4
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 0
Debian 10 deb pkg check
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9

ton31337

peer_group2peer_config_copy() must adopt the changes for tcp_mss also.

.gitignore

bgpd/bgp_network.c

bgpd/bgpd.c

Change ALL_LIST_ELEMENTS_RO to ALL_LIST_ELEMENTS. Signed-off-by: forsunwell <[email protected]>

NetDEF-CI · 2023-09-21T01:58:57Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14274/frr-source'
bgpd/bgpd.c: In function peer_tcp_mss_set:
bgpd/bgpd.c:5787:52: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
 5787 |   for (ALL_LIST_ELEMENTS(peer->group->peer, node, p)) {
In file included from ./lib/if.h:10,
./lib/linklist.h:319: note: macro "ALL_LIST_ELEMENTS" defined here
bgpd/bgpd.c:5787:8: error: ALL_LIST_ELEMENTS undeclared (first use in this function)
 5787 |   for (ALL_LIST_ELEMENTS(peer->group->peer, node, p)) {
bgpd/bgpd.c:5787:8: note: each undeclared identifier is reported only once for each function it appears in

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U2004AMD64BUILD/config.status/config.status

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.14274/frr-source'
bgpd/bgpd.c:5787:52: error: too few arguments provided to function-like macro invocation
./lib/linklist.h:319:9: note: macro 'ALL_LIST_ELEMENTS' defined here
#define ALL_LIST_ELEMENTS(list, node, nextnode, data)                          \
bgpd/bgpd.c:5787:8: error: use of undeclared identifier 'ALL_LIST_ELEMENTS'
bgpd/bgpd.c:5787:53: error: expected ';' in 'for' statement specifier
bgpd/bgpd.c:5809:52: error: too few arguments provided to function-like macro invocation
./lib/linklist.h:319:9: note: macro 'ALL_LIST_ELEMENTS' defined here

Redhat 8 amd64 build: Failed (click for details)

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/REDHAT8/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14274/frr-source'
bgpd/bgpd.c: In function peer_tcp_mss_set:
bgpd/bgpd.c:5787:52: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
bgpd/bgpd.c:5787:8: error: ALL_LIST_ELEMENTS undeclared (first use in this function)
bgpd/bgpd.c:5787:8: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgpd.c:5787:25: error: expected ; before ) token
bgpd/bgpd.c:5787:53: error: expected expression before ) token
bgpd/bgpd.c:5780:19: error: unused variable node [-Werror=unused-variable]
bgpd/bgpd.c: In function peer_tcp_mss_unset:

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/REDHAT8/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.14274/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
bgpd/bgpd.c: In function peer_tcp_mss_set:
bgpd/bgpd.c:5787:52: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
bgpd/bgpd.c:5787:8: error: ALL_LIST_ELEMENTS undeclared (first use in this function)
bgpd/bgpd.c:5787:8: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgpd.c:5787:53: error: expected ; before ) token
bgpd/bgpd.c:5787:53: error: expected expression before ) token
bgpd/bgpd.c:5780:19: error: unused variable node [-Werror=unused-variable]
bgpd/bgpd.c: In function peer_tcp_mss_unset:

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14274/frr-source'
bgpd/bgpd.c: In function peer_tcp_mss_set:
bgpd/bgpd.c:5787:52: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
bgpd/bgpd.c:5787:8: error: ALL_LIST_ELEMENTS undeclared (first use in this function)
bgpd/bgpd.c:5787:8: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgpd.c:5787:53: error: expected ; before ) token
bgpd/bgpd.c:5787:53: error: expected expression before ) token
bgpd/bgpd.c:5780:19: error: unused variable node [-Werror=unused-variable]
bgpd/bgpd.c: In function peer_tcp_mss_unset:

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U18ARM8BUILD/config.status/config.status

Redhat 9 amd64 build: Failed (click for details)

Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/RH9BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14274/frr-source'
bgpd/bgpd.c: In function peer_tcp_mss_set:
bgpd/bgpd.c:5787:66: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
 5787 |                 for (ALL_LIST_ELEMENTS(peer->group->peer, node, p)) {
In file included from ./lib/if.h:10,
./lib/linklist.h:319: note: macro "ALL_LIST_ELEMENTS" defined here
bgpd/bgpd.c:5787:22: error: ALL_LIST_ELEMENTS undeclared (first use in this function)
 5787 |                 for (ALL_LIST_ELEMENTS(peer->group->peer, node, p)) {
bgpd/bgpd.c:5787:22: note: each undeclared identifier is reported only once for each function it appears in

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/RH9BUILD/config.log/config.log.gz

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/DEB10BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14274/frr-source'
bgpd/bgpd.c: In function peer_tcp_mss_set:
bgpd/bgpd.c:5787:52: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
bgpd/bgpd.c:5787:8: error: ALL_LIST_ELEMENTS undeclared (first use in this function)
bgpd/bgpd.c:5787:8: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgpd.c:5787:25: error: expected ; before ) token
bgpd/bgpd.c:5787:53: error: expected expression before ) token
bgpd/bgpd.c:5780:19: error: unused variable node [-Werror=unused-variable]
bgpd/bgpd.c: In function peer_tcp_mss_unset:

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/DEB10BUILD/config.log/config.log.gz

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.14274/frr-source/doc/user/pbr.rst:50: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14274/frr-source/doc/user/nexthop_groups.rst
bgpd/bgpd.c: In function peer_tcp_mss_set:
bgpd/bgpd.c:5787:52: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
bgpd/bgpd.c:5787:8: error: ALL_LIST_ELEMENTS undeclared (first use in this function)
bgpd/bgpd.c:5787:8: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgpd.c:5787:53: error: expected ; before ) token
bgpd/bgpd.c:5787:53: error: expected expression before ) token
bgpd/bgpd.c:5780:19: error: unused variable node [-Werror=unused-variable]
bgpd/bgpd.c: In function peer_tcp_mss_unset:

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14274/frr-source'
bgpd/bgpd.c: In function peer_tcp_mss_set:
bgpd/bgpd.c:5787:66: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
 5787 |                 for (ALL_LIST_ELEMENTS(peer->group->peer, node, p)) {
In file included from ./lib/if.h:10,
./lib/linklist.h:319: note: macro "ALL_LIST_ELEMENTS" defined here
bgpd/bgpd.c:5787:22: error: ALL_LIST_ELEMENTS undeclared (first use in this function)
 5787 |                 for (ALL_LIST_ELEMENTS(peer->group->peer, node, p)) {
bgpd/bgpd.c:5787:22: note: each undeclared identifier is reported only once for each function it appears in

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U22AMD64BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.14274/frr-source'
bgpd/bgpd.c: In function 'peer_tcp_mss_set':
bgpd/bgpd.c:5787:52: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
 5787 |   for (ALL_LIST_ELEMENTS(peer->group->peer, node, p)) {
In file included from ./lib/if.h:10,
./lib/linklist.h:319: note: macro "ALL_LIST_ELEMENTS" defined here
bgpd/bgpd.c:5787:8: error: 'ALL_LIST_ELEMENTS' undeclared (first use in this function)
 5787 |   for (ALL_LIST_ELEMENTS(peer->group->peer, node, p)) {
bgpd/bgpd.c:5787:8: note: each undeclared identifier is reported only once for each function it appears in

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U1804AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.14274/frr-source/doc/user/pbr.rst:50: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14274/frr-source/doc/user/nexthop_groups.rst
bgpd/bgpd.c: In function peer_tcp_mss_set:
bgpd/bgpd.c:5787:52: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
bgpd/bgpd.c:5787:8: error: ALL_LIST_ELEMENTS undeclared (first use in this function)
bgpd/bgpd.c:5787:8: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgpd.c:5787:53: error: expected ; before ) token
bgpd/bgpd.c:5787:53: error: expected expression before ) token
bgpd/bgpd.c:5780:19: error: unused variable node [-Werror=unused-variable]
bgpd/bgpd.c: In function peer_tcp_mss_unset:

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/DEB11AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14274/frr-source'
bgpd/bgpd.c: In function peer_tcp_mss_set:
bgpd/bgpd.c:5787:52: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
 5787 |   for (ALL_LIST_ELEMENTS(peer->group->peer, node, p)) {
In file included from ./lib/if.h:10,
./lib/linklist.h:319: note: macro "ALL_LIST_ELEMENTS" defined here
bgpd/bgpd.c:5787:8: error: ALL_LIST_ELEMENTS undeclared (first use in this function)
 5787 |   for (ALL_LIST_ELEMENTS(peer->group->peer, node, p)) {
bgpd/bgpd.c:5787:8: note: each undeclared identifier is reported only once for each function it appears in

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/DEB11AMD64/config.status/config.status

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U18I386BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.14274/frr-source/doc/user/pbr.rst:50: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14274/frr-source/doc/user/nexthop_groups.rst
bgpd/bgpd.c: In function peer_tcp_mss_set:
bgpd/bgpd.c:5787:52: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
bgpd/bgpd.c:5787:8: error: ALL_LIST_ELEMENTS undeclared (first use in this function)
bgpd/bgpd.c:5787:8: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgpd.c:5787:53: error: expected ; before ) token
bgpd/bgpd.c:5787:53: error: expected expression before ) token
bgpd/bgpd.c:5780:19: error: unused variable node [-Werror=unused-variable]
bgpd/bgpd.c: In function peer_tcp_mss_unset:

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.14274/frr-source'
bgpd/bgpd.c: In function peer_tcp_mss_set:
bgpd/bgpd.c:5787:52: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
bgpd/bgpd.c:5787:8: error: ALL_LIST_ELEMENTS undeclared (first use in this function)
bgpd/bgpd.c:5787:8: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgpd.c:5787:53: error: expected ; before ) token
bgpd/bgpd.c:5787:53: error: expected expression before ) token
bgpd/bgpd.c:5780:19: error: unused variable node [-Werror=unused-variable]
bgpd/bgpd.c: In function peer_tcp_mss_unset:

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/CI005BUILD/config.status/config.status

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/CI005BUILD/ErrorLog/log_make.txt)

pimd/pim_cmd_common.c:4899:2: warning: missing braces around initializer [-Wmissing-braces]
pimd/pim_cmd_common.c:4899:2: warning: (near initialization for sg.grp) [-Wmissing-braces]
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.  CC       mgmtd/mgmt.o
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed./home/ci/cibuild.14274/frr-source/doc/user/ospfd.rst:627: WARNING: Bullet list ends without a blank line; unexpected unindent.
/home/ci/cibuild.14274/frr-source/doc/user/ospfd.rst:642: WARNING: Cannot analyze code. No Pygments lexer found for "frr".
/home/ci/cibuild.14274/frr-source/doc/user/pbr.rst:50: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.14274/frr-source/doc/user/nexthop_groups.rst
/home/ci/cibuild.14274/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.14274/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.14274/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-14274/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.14274/frr-source'
bgpd/bgpd.c: In function 'peer_tcp_mss_set':
bgpd/bgpd.c:5787:52: error: macro "ALL_LIST_ELEMENTS" requires 4 arguments, but only 3 given
bgpd/bgpd.c:5787:8: error: 'ALL_LIST_ELEMENTS' undeclared (first use in this function)
bgpd/bgpd.c:5787:8: note: each undeclared identifier is reported only once for each function it appears in
bgpd/bgpd.c:5787:53: error: expected ';' before ')' token
bgpd/bgpd.c:5787:53: error: expected expression before ')' token
bgpd/bgpd.c:5780:19: error: unused variable 'node' [-Werror=unused-variable]
bgpd/bgpd.c: In function 'peer_tcp_mss_unset':

ton31337 · 2023-10-03T06:07:06Z

@forsunwell will you be able to fix the missing changes?

riw777

waiting on @ton31337 's comments, otherwise okay

riw777 · 2024-01-16T13:35:24Z

@forsunwell still looking at this?

riw777 · 2024-02-06T14:32:58Z

@frrbot autoclose in 1 month

frrbot bot added the bgp label Sep 20, 2023

github-actions bot added size/M master labels Sep 20, 2023

forsunwell mentioned this pull request Sep 20, 2023

BGP neighbor tcp-mss doesn't work when neighbor in passive mode #14413

Closed

forsunwell force-pushed the bugs/set_tcp_mss_on_listen_socket branch from ce9deab to a598e79 Compare September 20, 2023 04:12

ton31337 requested changes Sep 20, 2023

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

bgpd/bgp_network.c Show resolved Hide resolved

bgpd/bgpd.c Outdated Show resolved Hide resolved

bgpd/bgpd.c Outdated Show resolved Hide resolved

bgpd: Fix some bugs of set tcp-mss on listen socket.

65af397

Change ALL_LIST_ELEMENTS_RO to ALL_LIST_ELEMENTS. Signed-off-by: forsunwell <[email protected]>

ton31337 added this to the 9.1 milestone Oct 3, 2023

Jafaral requested a review from riw777 October 3, 2023 15:52

ton31337 removed this from the 9.1 milestone Nov 7, 2023

riw777 reviewed Jan 2, 2024

View reviewed changes

frrbot bot added the autoclose label Feb 6, 2024

github-actions bot added rebase PR needs rebase and removed autoclose labels Feb 6, 2024

frrbot bot closed this Mar 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bgpd: Fix some bugs of set tcp-mss on listen socket. #14449

bgpd: Fix some bugs of set tcp-mss on listen socket. #14449

forsunwell commented Sep 20, 2023 •

edited

Loading

NetDEF-CI commented Sep 20, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

ton31337 left a comment

NetDEF-CI commented Sep 20, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

ton31337 left a comment

NetDEF-CI commented Sep 21, 2023

ton31337 commented Oct 3, 2023

riw777 left a comment

riw777 commented Jan 16, 2024

riw777 commented Feb 6, 2024

bgpd: Fix some bugs of set tcp-mss on listen socket. #14449

bgpd: Fix some bugs of set tcp-mss on listen socket. #14449

Conversation

forsunwell commented Sep 20, 2023 • edited Loading

NetDEF-CI commented Sep 20, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

ton31337 left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Sep 20, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

ton31337 left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Sep 21, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

ton31337 commented Oct 3, 2023

riw777 left a comment

Choose a reason for hiding this comment

riw777 commented Jan 16, 2024

riw777 commented Feb 6, 2024

forsunwell commented Sep 20, 2023 •

edited

Loading

NetDEF-CI commented Sep 20, 2023 •

edited

Loading

NetDEF-CI commented Sep 20, 2023 •

edited

Loading