bgpd: Some BGP-LS adjustments #14536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://datatracker.ietf.org/doc/html/rfc7606 BGP-LS Attribute does have error handling consistent with Section 8 and thus are not further discussed herein. Section 8: The "treat-as-withdraw" approach is generally preferred and the "session reset" approach is discouraged. Signed-off-by: Donatas Abraitis <[email protected]>
Signed-off-by: Donatas Abraitis <[email protected]>
Increase to 2 bytes and also check if we don't go beyond the maximum packet size. When a BGP-LS Propagator finds that it is exceeding the maximum BGP message size due to the addition or update of some other BGP Attribute , it MUST consider the BGP-LS Attribute to be malformed, apply the "Attribute Discard" error-handling approach. Signed-off-by: Donatas Abraitis <[email protected]>
|
I'm going to say we should put a hold on this as that I plan to introduce a PR tomorrow morning that will back out the LS code until such time it is fixed in a different manner |
I am going to publish a patch on this today. Kindly let us some times for its review. There is no urgency to revert BGP Link-State at the moment. |
|
Here is the fix: #14539 |
louis-6wind
approved these changes
Oct 10, 2023
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Closing due to #14560. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.