-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: Handle FQDN capability using dynamic capabilities #14540
Merged
riw777
merged 3 commits into
FRRouting:master
from
opensourcerouting:feature/bgpd_handle_fqdn_capability_via_dynamic_capability
Oct 24, 2023
Merged
bgpd: Handle FQDN capability using dynamic capabilities #14540
riw777
merged 3 commits into
FRRouting:master
from
opensourcerouting:feature/bgpd_handle_fqdn_capability_via_dynamic_capability
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riw777
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ton31337
force-pushed
the
feature/bgpd_handle_fqdn_capability_via_dynamic_capability
branch
from
October 12, 2023 05:01
ccfbedf
to
d89bd9d
Compare
donaldsharp
reviewed
Oct 13, 2023
ton31337
force-pushed
the
feature/bgpd_handle_fqdn_capability_via_dynamic_capability
branch
from
October 14, 2023 07:44
d89bd9d
to
313daf4
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Donatas Abraitis <[email protected]>
…abilities For instance, it's not possible to resend FQDN capability without resetting the session, so let's create some more elegant way to do that. Signed-off-by: Donatas Abraitis <[email protected]>
For now it includes only FQDN capability, because other capabilities can be resend using specific knobs. Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
feature/bgpd_handle_fqdn_capability_via_dynamic_capability
branch
from
October 20, 2023 06:37
313daf4
to
49d1539
Compare
ton31337
deleted the
feature/bgpd_handle_fqdn_capability_via_dynamic_capability
branch
October 24, 2023 10:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.