Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Handle FQDN capability using dynamic capabilities #14540

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Oct 6, 2023

No description provided.

@github-actions github-actions bot added the master label Oct 6, 2023
@ton31337 ton31337 added this to the 9.1 milestone Oct 6, 2023
@github-actions github-actions bot added the size/L label Oct 6, 2023
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ton31337 ton31337 removed this from the 9.1 milestone Oct 11, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ton31337 ton31337 force-pushed the feature/bgpd_handle_fqdn_capability_via_dynamic_capability branch from ccfbedf to d89bd9d Compare October 12, 2023 05:01
@ton31337 ton31337 force-pushed the feature/bgpd_handle_fqdn_capability_via_dynamic_capability branch from d89bd9d to 313daf4 Compare October 14, 2023 07:44
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…abilities

For instance, it's not possible to resend FQDN capability without resetting
the session, so let's create some more elegant way to do that.

Signed-off-by: Donatas Abraitis <[email protected]>
For now it includes only FQDN capability, because other capabilities can be
resend using specific knobs.

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337 ton31337 force-pushed the feature/bgpd_handle_fqdn_capability_via_dynamic_capability branch from 313daf4 to 49d1539 Compare October 20, 2023 06:37
@riw777 riw777 merged commit b6b0001 into FRRouting:master Oct 24, 2023
79 checks passed
@ton31337 ton31337 deleted the feature/bgpd_handle_fqdn_capability_via_dynamic_capability branch October 24, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants