OSPF6 point to multipoint #14546
Merged
OSPF6 point to multipoint #14546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianomarto
force-pushed
the
ospf6-point-to-multipoint
branch
from
04d1271 to
554cbf7
Compare
|
please fold in the commits that fix the compile. From my perspective having code that does not compile completely breaks git bisecting and is a no go. |
This function is not implemented anywhere. Not sure it ever existed. Signed-off-by: David Lamparter <[email protected]>
Both for virtual links and correct PtMP operation, advertising local addresses as Intra-Prefix with LA set is a prerequisite. Add the appropriate entries. Signed-off-by: David Lamparter <[email protected]>
For PtMP the cost may need to be recalculated when the LL addr changes (since neighbors are configured by LL addr and a different entry with a different cost may match.) Signed-off-by: David Lamparter <[email protected]>
Add a list of configured neighbors for each interface. Only stores cost (and "existence") for now. Signed-off-by: David Lamparter <[email protected]>
This adds a knob to refuse forming adjacencies with neighbors not listed in the config. Only works on PtP/PtMP of course, otherwise the DR/BDR machinery gets broken. Signed-off-by: David Lamparter <[email protected]>
With the configured neighbor list, unicast hellos can be sent. Allow disabling multicast hellos for that scenario. Signed-off-by: David Lamparter <[email protected]>
Some lower layers still don't handle multicast correctly (or efficiently.) Add option to send unicast hellos on explicitly configured neighbors for PtP/PtMP. Signed-off-by: David Lamparter <[email protected]>
This adds the PtMP interface type, which is effectively identical to PtP except that all the database flooding & updates are unicast. Signed-off-by: David Lamparter <[email protected]>
To announce connected prefixes, or not to announce connected prefixes, that is the question... Signed-off-by: David Lamparter <[email protected]>
Update & add docs for all the stuff in the previous 10-ish commits. Signed-off-by: David Lamparter <[email protected]>
Including checksum in OSPF6 Hello messages. Signed-off-by: Adriano Marto Reis <[email protected]>
* Check if FRR is running * Check if OSPFv3 converges * Check OSPFv3 Routing Tables * Check Linux Kernel Routing Table Signed-off-by: Adriano Marto Reis <[email protected]>
adrianomarto
force-pushed
the
ospf6-point-to-multipoint
branch
from
846c975 to
ea97e98
Compare
|
I combined the commits that fixed the code compilation with those that broke it. |
Now OSPF6 shares the /128 prefix by default. Adjusting the expected number of next hops according to that. Signed-off-by: Adriano Marto Reis <[email protected]>
adrianomarto
force-pushed
the
ospf6-point-to-multipoint
branch
from
ea97e98 to
108adcd
Compare
riw777
reviewed
Oct 24, 2023
adrianomarto
force-pushed
the
ospf6-point-to-multipoint
branch
from
515250d to
06efab2
Compare
Moving ospf6_if_p2xp_neighcfg to ospf6_interface.h so we don't need to include ospf6_neighbor.h. Signed-off-by: Adriano Marto Reis <[email protected]>
adrianomarto
force-pushed
the
ospf6-point-to-multipoint
branch
from
06efab2 to
5a31132
Compare
Applying clang-format to the original commits. Signed-off-by: Adriano Marto Reis <[email protected]>
adrianomarto
force-pushed
the
ospf6-point-to-multipoint
branch
from
298e14e to
f83a824
Compare
|
ci failures are unrelated ... trying to rerun just the failures, let's see what happens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on the pull request #9198 by @eqvinox. It adds the following changes to it: