Zebra weighted ecmp #14553
Merged
Zebra weighted ecmp #14553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldsharp
force-pushed
the
zebra_weighted_ecmp
branch
from
c292248 to
5764cc4
Compare
|
Maybe we can have a test case to see how it works? |
donaldsharp
force-pushed
the
zebra_weighted_ecmp
branch
2 times, most recently
from
e43c042 to
93505a4
Compare
donaldsharp
force-pushed
the
zebra_weighted_ecmp
branch
from
93505a4 to
3854f22
Compare
Currently underlying asics get into a bit of trouble when the nexthop weight passed down varies wildly between the different numbers. Let's normalize the weight values between 1 and 255 Signed-off-by: Donald Sharp <[email protected]>
The weight scale value might be useful to have it change it's behavior at a later time or controlled by something depending on how FRR is compiled/ran. Let's start that process Signed-off-by: Donald Sharp <[email protected]>
Instead of scaling the bandwith to something between 1 and 100, just send down the bandwidth Available for the link. Signed-off-by: Donald Sharp <[email protected]>
Signed-off-by: Donald Sharp <[email protected]>
Old behavior was metric values between 1-100, now we have metric values between 1-255. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
zebra_weighted_ecmp
branch
from
3854f22 to
3d8ba5c
Compare
|
@ton31337 -> It already has a test case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits. Make unequal weighted costs controlled by zebra and normalize the values between 1 and 255. Modify bgp to pass down the unweighted costs.
This will allow other protocols to take advantage of the same process.