Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eigrp: use correct memory pool on interface deletion #14557

Merged
merged 1 commit into from
Oct 11, 2023
Merged

eigrp: use correct memory pool on interface deletion #14557

merged 1 commit into from
Oct 11, 2023

Conversation

1337kerberos
Copy link
Contributor

@1337kerberos 1337kerberos commented Oct 10, 2023 •
edited
Loading

Trying to delete an interface during the test test_eigrp_topo1.py triggers a crash.

2023/10/10 19:12:25.299840 EIGRP: [T6888-VVP0Y] Zebra: Interface[r1-eth0] state change to down.
2023/10/10 19:12:25.301524 EIGRP: [ZNQW6-A3MDH] Zebra: interface delete r1-eth0 index 2 flags 1002 metric 0 mtu 1500
2023/10/10 19:12:25.301529 EIGRP: lib/memory.c:73: mt_count_free(): assertion (mt->n_alloc) failed
EIGRP: Received signal 6 at 1696954345 (si_addr 0x840006315b, PC 0x7f246ad7200b); aborting...
EIGRP: zlog_signal+0x1b1                  7f246b04004b     7ffff0df59b0 /usr/lib//frr/libfrr.so.0 (mapped at 0x7f246af74000)
EIGRP: core_handler+0xfc                  7f246b08fc33     7ffff0df5ae0 /usr/lib//frr/libfrr.so.0 (mapped at 0x7f246af74000)
EIGRP: funlockfile+0x60                   7f246af35420     7ffff0df5c40 /lib/x86_64-linux-gnu/libpthread.so.0 (mapped at 0x7f246af21000)
EIGRP:     ---- signal ----
EIGRP: gsignal+0xcb                       7f246ad7200b     7ffff0df6810 /lib/x86_64-linux-gnu/libc.so.6 (mapped at 0x7f246ad2f000)
EIGRP: abort+0x12b                        7f246ad51859     7ffff0df6930 /lib/x86_64-linux-gnu/libc.so.6 (mapped at 0x7f246ad2f000)
EIGRP: _zlog_assert_failed+0x18c          7f246b0d2bbd     7ffff0df6a60 /usr/lib//frr/libfrr.so.0 (mapped at 0x7f246af74000)
EIGRP: mt_count_free+0x56                 7f246b0461a7     7ffff0df6b60 /usr/lib//frr/libfrr.so.0 (mapped at 0x7f246af74000)
EIGRP: qfree+0x2e                         7f246b0463f5     7ffff0df6ba0 /usr/lib//frr/libfrr.so.0 (mapped at 0x7f246af74000)
EIGRP: eigrp_if_delete_hook+0x8c          55fd2d095aee     7ffff0df6bc0 /usr/lib/frr/eigrpd (mapped at 0x55fd2d074000)
EIGRP: hook_call_if_del+0x5f              7f246b024214     7ffff0df6bf0 /usr/lib//frr/libfrr.so.0 (mapped at 0x7f246af74000)
EIGRP: if_delete_retain+0x1c              7f246b024947     7ffff0df6c30 /usr/lib//frr/libfrr.so.0 (mapped at 0x7f246af74000)
EIGRP: if_delete+0xfb                     7f246b024a7d     7ffff0df6c50 /usr/lib//frr/libfrr.so.0 (mapped at 0x7f246af74000)
EIGRP: if_destroy_via_zapi+0x69           7f246b024698     7ffff0df6c90 /usr/lib//frr/libfrr.so.0 (mapped at 0x7f246af74000)
EIGRP: zclient_interface_delete+0x57      7f246b0cb543     7ffff0df6cb0 /usr/lib//frr/libfrr.so.0 (mapped at 0x7f246af74000)
EIGRP: zclient_read+0x3d0                 7f246b0cfcbd     7ffff0df6cf0 /usr/lib//frr/libfrr.so.0 (mapped at 0x7f246af74000)
EIGRP: event_call+0xd8                    7f246b0aa2aa     7ffff0df6d50 /usr/lib//frr/libfrr.so.0 (mapped at 0x7f246af74000)
EIGRP: frr_run+0x271                      7f246b034012     7ffff0df6e10 /usr/lib//frr/libfrr.so.0 (mapped at 0x7f246af74000)
EIGRP: main+0x14b                         55fd2d0970d6     7ffff0df6f30 /usr/lib/frr/eigrpd (mapped at 0x55fd2d074000)
EIGRP: __libc_start_main+0xf3             7f246ad53083     7ffff0df6f80 /lib/x86_64-linux-gnu/libc.so.6 (mapped at 0x7f246ad2f000)
EIGRP: _start+0x2e                        55fd2d08996e     7ffff0df7050 /usr/lib/frr/eigrpd (mapped at 0x55fd2d074000)
EIGRP: in thread zclient_read scheduled from lib/zclient.c:4514 zclient_event()

ton31337
ton31337 reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put all the details that are in the PR's description in the commit directly?

@ton31337
Copy link
Member

@Mergifyio backport stable/8.5 stable/9.0

@mergify
Copy link

mergify bot commented Oct 10, 2023 •
edited
Loading

backport stable/8.5 stable/9.0

✅ Backports have been created

@ton31337
Copy link
Member

@Mergifyio backport dev/9.1 stable/8.5 stable/9.0

@mergify
Copy link

mergify bot commented Oct 10, 2023 •
edited
Loading

backport dev/9.1 stable/8.5 stable/9.0

✅ Backports have been created

eigrp: use correct memory pool on interface deletion
8ddf6a7 
Trying to delete an interface during the test test_eigrp_topo1.py triggers a crash.
```
EIGRP: abort+0x12b
EIGRP: _zlog_assert_failed+0x18c
EIGRP: mt_count_free+0x56
EIGRP: qfree+0x2e
EIGRP: eigrp_if_delete_hook+0x8c
EIGRP: hook_call_if_del+0x5f
EIGRP: if_delete_retain+0x1c
EIGRP: if_delete+0xfb
EIGRP: if_destroy_via_zapi+0x69
EIGRP: zclient_interface_delete+0x57
EIGRP: zclient_read+0x3d0
EIGRP: event_call+0xd8
EIGRP: frr_run+0x271
EIGRP: main+0x14b
EIGRP: __libc_start_main+0xf3
EIGRP: _start+0x2e
EIGRP: in thread zclient_read scheduled from lib/zclient.c:4514 zclient_event()
```

Signed-off-by: Volodymyr Huti <[email protected]>
@1337kerberos 1337kerberos force-pushed the EIGRP_IF_DELETE_CRASH branch from 7a50124 to 8ddf6a7 Compare October 10, 2023 17:02
@1337kerberos
Copy link
Contributor Author

I added a sanitized crash trace to the commit message as well.

riw777
riw777 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit 7bc23dd into FRRouting:master Oct 11, 2023
79 checks passed
This was referenced Oct 11, 2023
Merged
Merged
Merged
@donaldsharp
Copy link
Member

@Mergifyio backport dev/9.1

@mergify
Copy link

mergify bot commented Oct 11, 2023

backport dev/9.1

✅ Backports have been created

donaldsharp added a commit that referenced this pull request Oct 11, 2023
@donaldsharp
Merge pull request #14565 from FRRouting/mergify/bp/stable/8.5/pr-14557
795d710 
eigrp: use correct memory pool on interface deletion (backport #14557)
donaldsharp added a commit that referenced this pull request Oct 12, 2023
@donaldsharp
Merge pull request #14567 from FRRouting/mergify/bp/dev/9.1/pr-14557
bbad836 
eigrp: use correct memory pool on interface deletion (backport #14557)
donaldsharp added a commit that referenced this pull request Oct 12, 2023
@donaldsharp
Merge pull request #14566 from FRRouting/mergify/bp/stable/9.0/pr-14557
03fc69d 
eigrp: use correct memory pool on interface deletion (backport #14557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ton31337 ton31337 ton31337 left review comments

@riw777 riw777 riw777 approved these changes

Assignees
No one assigned
Labels
backport master size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1337kerberos @ton31337 @donaldsharp @riw777