lib: msg: make short-circuit connections guaranteed #14576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idryzhov
reviewed
Oct 12, 2023
When short circuiting is requested the caller can count on that being the connection type they get. Signed-off-by: Christian Hopps <[email protected]>
choppsv1
force-pushed
the
chopps/short-circuit-guarantee
branch
from
63f8463 to
11e8c90
Compare
Also retry the config read vs. aborting if we haven't got a FE client connection yet. Signed-off-by: Christian Hopps <[email protected]>
idryzhov
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When short circuiting is requested the caller can count on that being the connection type they get.