tests: Add OSPF test for issue 14488 #14582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
href
force-pushed
the
denis/topotest-for-14488
branch
from
d23e825 to
c2293f3
Compare
href
changed the title
href
force-pushed
the
denis/topotest-for-14488
branch
from
c2293f3 to
afbfcae
Compare
|
I'm testing this out and looking at the other PR this morning |
OSPF on IPv4/IPv6 removes the wrong routes in certain cases, causing issues when removing and re-enabling interfaces. This test proofs that. These tests all pass with FRRouting#13340 and the latest master (d2324b7). See FRRouting#14488 Signed-off-by: Denis Krienbühl <[email protected]>
href
force-pushed
the
denis/topotest-for-14488
branch
from
afbfcae to
616e1fa
Compare
|
FYI, I added slightly changed the uptime check to also include the time it took to run the test to the comparison. I'm not sure how useful this will proof to be, but maybe it helps you find the reason for the flakiness that you've discovered. I also discovered that for IPv6 the uptime check was not correct, as it compared strings instead of actual seconds. |
|
https://github.com/Mergifyio backport dev/9.1 |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
|
@Mergifyio backport dev/9.1 |
✅ Backports have been created
|
ton31337
added a commit
that referenced
this pull request
Oct 15, 2023
tests: Add OSPF test for issue 14488 (backport #14582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSPF on IPv4/IPv6 removes the wrong routes in certain cases, causing issues when removing and re-enabling interfaces. This test proofs that.
These tests all pass with #13340 and the latest master (d2324b7).
See #14488