mgmtd, lib: remove batch ids from cfg apply reply #14609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config is always applied fully, all batches are included. There's no need to pass a list of applied batches as it always contains all of them. Signed-off-by: Igor Ryzhov <[email protected]>
idryzhov
changed the title
|
@choppsv1 @pushpasis I pushed additional commit to completely remove batch ids. It simplifies the code and also prevents possible race condition from happening. The race condition happens when one of the backends is still stuck on the |
|
@idryzhov could you create a second PR for removing all batch IDs. Removing them in the initial commit is obvious. The second change is larger and I'd like to review it in a separate PR. |
idryzhov
force-pushed
the
cfg-apply-remove-batches
branch
from
51227d9 to
d2977d5
Compare
idryzhov
changed the title
|
@choppsv1 I removed the second commit. I'll open a new PR once this one is merged. |
choppsv1
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config is always applied fully, all batches are included. There's no
need to pass a list of applied batches as it always contains all of
them.