Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospf6d: Set loopback interface cost to 0 #14635

Merged

Conversation

ton31337
Copy link
Member

Closes #14632

@frrbot frrbot bot added ospfv3 tests Topotests, make check, etc labels Oct 23, 2023
@ton31337
Copy link
Member Author

@Mergifyio backport dev/9.1 stable/9.0

@mergify
Copy link

mergify bot commented Oct 23, 2023

backport dev/9.1 stable/9.0

✅ Backports have been created

@frrbot frrbot bot added the bugfix label Oct 23, 2023
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented Oct 24, 2023

no execution results, try again
ci:rerun

@ton31337 ton31337 force-pushed the fix/ospf6d_loopback_cost branch from 25221e5 to eae28aa Compare October 25, 2023 07:33
@riw777
Copy link
Member

riw777 commented Oct 25, 2023

unrelated failure in BGP ... trying again
ci:rerun

@riw777
Copy link
Member

riw777 commented Oct 25, 2023

unrelated failure in multicast ... trying again
ci:rerun

https://www.rfc-editor.org/rfc/rfc5340.html#page-37 states:

If the interface type is point-
      to-multipoint or the interface is in the state Loopback, the
      global scope IPv6 addresses associated with the interface (if any)
      are copied into the intra-area-prefix-LSA with the PrefixOptions
      LA-bit set, the PrefixLength set to 128, and the metric set to 0.

Signed-off-by: Donatas Abraitis <[email protected]>
Fixes: fa3140f ("ospf6d: Set loopback interface cost to 0")

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337 ton31337 force-pushed the fix/ospf6d_loopback_cost branch from eae28aa to 8aeb17d Compare October 26, 2023 04:40
@ton31337
Copy link
Member Author

ci:rerun CI stuck

@mobash-rasool mobash-rasool merged commit ed0cfbe into FRRouting:master Oct 30, 2023
79 checks passed
@ton31337 ton31337 deleted the fix/ospf6d_loopback_cost branch October 30, 2023 05:43
ton31337 added a commit that referenced this pull request Oct 30, 2023
ospf6d: Set loopback interface cost to 0 (backport #14635)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSPFv3 (IPv6) loopback metric wrong
4 participants