Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isisd: staticd: need to link directly against libyang #14664

Merged
merged 1 commit into from
Oct 27, 2023
Merged

isisd: staticd: need to link directly against libyang #14664

merged 1 commit into from
Oct 27, 2023

Conversation

choppsv1
Copy link
Contributor

No description provided.

@frrbot frrbot bot added the isis label Oct 27, 2023
@ton31337
Copy link
Member

@Mergifyio backport dev/9.1 stable/9.0

@mergify
Copy link

mergify bot commented Oct 27, 2023 •
edited
Loading

backport dev/9.1 stable/9.0

✅ Backports have been created

@ton31337 ton31337 merged commit 2f6fd43 into FRRouting:master Oct 27, 2023
80 checks passed
This was referenced Oct 27, 2023
Merged
Merged
@idryzhov
Copy link
Contributor

idryzhov commented Oct 27, 2023 •
edited
Loading

I know this is merged, just trying to clarify – why only isisd and staticd? What's different about these daemons? I don't see such linking in ripd, bfdd, etc.

@choppsv1
Copy link
Contributor Author

I know this is merged, just trying to clarify – why only isisd and staticd? What's different about these daemons? I don't see such linking in ripd, bfdd, etc.

Almost all uses of libyang happen in libfrr which is already linked against libyang. These daemons used a couple static inline "getter" functions (e.g., lyd_parent(node)) directly. Those libyang static inline functions were recently moved to be non-static non-inline and so isisd and staticd failed to link.

donaldsharp added a commit that referenced this pull request Oct 27, 2023
@donaldsharp
Merge pull request #14668 from FRRouting/mergify/bp/stable/9.0/pr-14664
a8c6a8a 
isisd: staticd: need to link directly against libyang (backport #14664)
@idryzhov
Copy link
Contributor

Thanks. Maybe it would be better to have wrappers for such functions in libfrr instead of additional linking, but it's not a big deal.

ton31337 added a commit that referenced this pull request Oct 27, 2023
@ton31337
Merge pull request #14667 from FRRouting/mergify/bp/dev/9.1/pr-14664
9923418 
isisd: staticd: need to link directly against libyang (backport #14664)
@choppsv1 choppsv1 deleted the chopps/ly2-ld-fix branch November 10, 2023 15:40
@choppsv1
Copy link
Contributor Author

@Mergifyio backport stable/8.5

@mergify Mergify
Copy link

mergify bot commented Jan 12, 2024 •
edited
Loading

backport stable/8.5

✅ Backports have been created

@choppsv1
Copy link
Contributor Author

@Mergifyio backport stable/8.4

@mergify Mergify
Copy link

mergify bot commented Jan 12, 2024 •
edited
Loading

backport stable/8.4

✅ Backports have been created

@choppsv1
Copy link
Contributor Author

@Mergifyio backport stable/8.3

@mergify Mergify
Copy link

mergify bot commented Jan 12, 2024 •
edited
Loading

backport stable/8.3

✅ Backports have been created

@choppsv1
Copy link
Contributor Author

@Mergifyio backport stable/8.2

This was referenced Jan 12, 2024
Merged
Merged
Merged
@mergify Mergify
Copy link

mergify bot commented Jan 12, 2024 •
edited
Loading

backport stable/8.2

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jan 12, 2024
Merged
donaldsharp added a commit that referenced this pull request Jan 16, 2024
@donaldsharp
Merge pull request #15143 from FRRouting/mergify/bp/stable/8.2/pr-14664
ff77ef5 
isisd: staticd: need to link directly against libyang (backport #14664)
donaldsharp added a commit that referenced this pull request Jan 16, 2024
@donaldsharp
Merge pull request #15142 from FRRouting/mergify/bp/stable/8.3/pr-14664
8bce49a 
isisd: staticd: need to link directly against libyang (backport #14664)
donaldsharp added a commit that referenced this pull request Jan 16, 2024
@donaldsharp
Merge pull request #15141 from FRRouting/mergify/bp/stable/8.4/pr-14664
34512bd 
isisd: staticd: need to link directly against libyang (backport #14664)
donaldsharp added a commit that referenced this pull request Jan 16, 2024
@donaldsharp
Merge pull request #15140 from FRRouting/mergify/bp/stable/8.5/pr-14664
b4c3ebe 
isisd: staticd: need to link directly against libyang (backport #14664)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ton31337 ton31337 ton31337 approved these changes

Assignees
No one assigned
Labels
backport isis master size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@choppsv1 @ton31337 @idryzhov