Workqueue cleanup #14724
Merged
Workqueue cleanup #14724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Recent Changes added the -Wimplicit-fallthrough flag to FRR's compilation. Implementor does not build with lua support and as such this one was missed in the compilation Signed-off-by: Donald Sharp <[email protected]>
Some Functions are not used outside of workqueue.c. Move them inside of workqueue.c to limit scope. Signed-off-by: Donald Sharp <[email protected]>
buffer.h -> Bring up to our standard if.h -> Bring up to our standard workqueue.h -> expand documentation slightly Signed-off-by: Donald Sharp <[email protected]>
These enum's have been around since 2005 and FRR still does not have any users of these particular values. After almost 20 years, let's simplify the code slightly and remove them. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
workqueue_cleanup
branch
from
9b4b481 to
2a65f05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual patches for discussion