isisd: Fix crash when enabling OpenFabric on an interface #14726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscarpitta
force-pushed
the
fix/fix-openfabric-crash
branch
from
d09f9b8 to
8d371d2
Compare
`isis_srv6_area_init` should not use `yang_get_default_*` functions for fabricd. Fixes: FRRouting#14722 Signed-off-by: Carmine Scarpitta <[email protected]>
Signed-off-by: Carmine Scarpitta <[email protected]>
cscarpitta
force-pushed
the
fix/fix-openfabric-crash
branch
from
8d371d2 to
ccd82b3
Compare
|
Have you gone through with all the other commands that were added for ISIS SRv6 and ensured that we have a second code path for fabricd? In other words is this operator going to report another crash in a week or two as they try different commands? |
|
@Mergifyio backport dev/9.1 stable/9.0 |
✅ Backports have been created
|
idryzhov
approved these changes
Nov 5, 2023
This was referenced Nov 5, 2023
idryzhov
added a commit
that referenced
this pull request
Nov 6, 2023
isisd: Fix crash when enabling OpenFabric on an interface (backport #14726)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isis_srv6_area_initshould not useyang_get_default_*functions for fabricd.Fixes: #14722