V6 rr semantics zrouter #14729
Merged
V6 rr semantics zrouter #14729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Nov 3, 2023
The v6_rr_semantics variable was being set but never reported and had to be inferred from watching netlink messages to the kernel. Let's add a bit of code to `show zebra` so that we can know how it is being used. Signed-off-by: Donald Sharp <[email protected]>
Move global variable v6_rr_semantics from a global data structure into the zrouter data structure. Signed-off-by: Donald Sharp <[email protected]>
The nexthop group route replace operation was made consistent across all versions of the kernel. A v6 route replacement does not need to do a delete than add when using nexthop groups Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
v6_rr_semantics_zrouter
branch
from
f2443d3 to
7e1b56b
Compare
|
@ton31337 -> I was thinking about this and realized that when using nexthop groups for installation there is no need to do anything special for v6 in regards to route replace semantics, as that they just work with nexthop groups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show zebrathe v6_rr_semantics flagLong term we need to figure out how to figure this out so we don't need to carry this anymore. v6_rr_semantics is fixed in latest kernels as far as I can tell now