pathd: fix space before pcep port in running-config #14762
Conversation
|
@Mergifyio backport dev/9.1 |
❌ No backport have been created
GitHub error: |
|
This is even not compiling yet. |
pguibert6WIND
force-pushed
the
show_pcep_port
branch
from
e122ddd to
28a6b2f
Compare
doc/user/pathd.rst
Outdated
| @@ -471,7 +471,7 @@ Configuration Commands | |||
| Disable or start the definition of a PCC. | |||
|
|
|||
|
|
|||
| .. clicmd:: msd (1-32) | |||
| .. clicmd:: msd [(1-32)] | |||
There was a problem hiding this comment.
For me it's unclear when reading here. Seems I'm able to enter just "msd", and what is the effect of that? Can it be clarified?
There was a problem hiding this comment.
which behaviour do you expect?
There was a problem hiding this comment.
No idea what would be the behavior here, is this something that is picked by default if I do not specify the depth?
There was a problem hiding this comment.
In general, there is a default value for MSD which depend of the hardware. For Linux Kernel, the default value is 32. This CLI is used to specify a different value as the default one. Thus, the CLI should keep the (1-32) syntax to force specifying the new value of MSD. The no MSD CLI acts as go back to the default value.
So, it is preferable to not change this.
doc/user/pathd.rst
Outdated
| @@ -471,7 +471,7 @@ Configuration Commands | |||
| Disable or start the definition of a PCC. | |||
|
|
|||
|
|
|||
| .. clicmd:: msd (1-32) | |||
| .. clicmd:: msd [(1-32)] | |||
There was a problem hiding this comment.
In general, there is a default value for MSD which depend of the hardware. For Linux Kernel, the default value is 32. This CLI is used to specify a different value as the default one. Thus, the CLI should keep the (1-32) syntax to force specifying the new value of MSD. The no MSD CLI acts as go back to the default value.
So, it is preferable to not change this.
The below running-configuration has extra spaces before the pce port configuration: > segment-routing > traffic-engineering > pce test > address ip 192.0.2.2 port 1234 > Fix this by keeping only one space. > address ip 192.0.2.2 port 1234 Fixes: efba098 ("pathd: Add optional support for PCEP to pathd") Signed-off-by: Philippe Guibert <[email protected]>
It should be possible to reset the configured msd value, and not mentioning the previous msd value. > ubuntu2204(config-sr-te-pcep-pcc)# no msd > % Command incomplete: no msd > ubuntu2204(config-sr-te-pcep-pcc)# Fix this by defining the msd parameter optional, and separating the 'no msd' command from the 'msd' command. Fixe: efba098 ("pathd: Add optional support for PCEP to pathd") Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
show_pcep_port
branch
from
28a6b2f to
d6d2527
Compare
The below running-configuration has extra spaces before the pce port configuration:
Fix this by keeping only one space.
Fixes: efba098 ("pathd: Add optional support for PCEP to pathd")