bgpd: Enable combined logging for UPDATEs #14809
Conversation
Before this patch if we enable two commands: * `debug bgp updates in 10.0.0.1` * `debug bgp updates prefix 192.168.0.0/24` We never check both conditions if a prefix and neighbor match. If we see that we enabled logging for a specific neighbor, then we log all the messages related to that neighbor and ignore what prefix we expect. With this patch, we have a combined check and look at prefix + neighbor. Signed-off-by: Donatas Abraitis <[email protected]>
|
I completely disagree with how this change modifies the semantics of debugs. Two conditions in a single statement should be treated as an AND. Two conditions in separate statements should be treated as an OR. This is how pretty much everything else in FRR works, e.g. route-maps, and changing these semantics would remove the ability for an operator to debug updates EITHER for a prefix from any peer OR any prefix to/from a peer. I would be on board with a change that allowed an operator to AND the two debug conditions, but that should fall within a single debug statement. |
|
I agree and disagree here, but having a command as you suggested makes more sense. Will add such a feature to an existing command as an extension to avoid breaking stuff. |
ton31337
deleted the
feature/bgp_debug_updates_combined_prefix_neighbor
branch
Before this patch if we enable two commands:
debug bgp updates in 10.0.0.1debug bgp updates prefix 192.168.0.0/24We never check both conditions if a prefix and neighbor match. If we see that we enabled logging for a specific neighbor, then we log all the messages related to that neighbor and ignore what prefix we expect.
With this patch, we have a combined check and look at prefix + neighbor.