Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: use LYD_VALIDATE_MULTI_ERROR only if available #14831

Merged

Conversation

eqvinox
Copy link
Contributor

@eqvinox eqvinox commented Nov 20, 2023

LYD_VALIDATE_MULTI_ERROR was added in libyang 2.1.36. The currently enforced minimum of libyang is 2.0.0. Stick an #ifdef around it.


Fixes #14800

LYD_VALIDATE_MULTI_ERROR was added in libyang 2.1.36.  The currently
enforced minimum of libyang is 2.0.0.  Stick an #ifdef around it.

Fixes: 51a2a4b ("lib: print all errors when validating a config")
Cc: Igor Ryzhov <[email protected]>
Signed-off-by: David Lamparter <[email protected]>
@idryzhov
Copy link
Contributor

Well, the fix makes sense, but I think we already actually require even higher version because of some other fixes in libyang that we rely on. @choppsv1 I think you recently changed some code that requires newer libyang?

@choppsv1 choppsv1 merged commit 9c1b357 into FRRouting:master Nov 20, 2023
83 checks passed
@choppsv1
Copy link
Contributor

choppsv1 commented Nov 20, 2023

@idryzhov there's a bunch of version stuff going on, there's a range where things are broken in libyang that doesn't appear to have been packaged. We should up our requirement to 2.1.80 I believe.

@choppsv1
Copy link
Contributor

choppsv1 commented Nov 20, 2023

@idryzhov there's a bunch of version stuff going on, there's a range where things are broken in libyang that doesn't appear to have been packaged. We should up our requirement to 2.1.80 I believe.

but we'll need to see how that affects OS release packages and if we care or not (i.e., just require build form source, or use frrouting package if the OS package is too old).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants